[Resolved] Hit Counter

Elwaryn

I am just trying to make a very simple hit counter. I want to open the file "counter.txt", get the number in there, increment it, print it to screen, then write it back to the file. Here is the code I am trying to get to work.

<?php
	$file = fopen("counter.txt", "w+");
	$data = fgets($file, 100);
	$data = $data + 1;
	print("<p class='center'>$data</p>");
	fputs($file, "$data");
	fclose($file);
?>

It will open the file, read the "0" in there, increment it, print a "1", and write it back to the file, but it won't go to "2" if I refresh. Why not?

Merve

You can use [man]fread/man and [man]fwrite/man.

[man]fgets/man and [man]fputs/man are often used in conjunction with [man]feof/man.

Elwaryn

Grr, it still does the same thing.

tommynanda

Small changes in your code

<?php
  if(file_exists("counter.txt"))
  {
  	$file = fopen("counter.txt", "r");
    $data = trim(fgets($file));
    fclose($file);
  }
  else
    $data=0;
  unlink("counter.txt");
    $file = fopen("counter.txt", "w");
    $data++;
    print("<p class='center'>$data</p>");
    fwrite($file, $data);
    fclose($file);
?>

This should do the job

Good Luck
TommYNandA

Elwaryn

Thanks. Works beautifully. I need to find out what the unlink() function is.

tommynanda

YW, unlink() deletes a file

Have Fun Coding!
TommYNandA

Joseph_Sliker

Hi;

I am trying to get this to work on some simple pages I have. What does the "counter.txt" file contain? I can't seem to get the counter to say anthing other than "1".

Thanks

robert_w_ark

<?php

/* Start Hit Counter */

$file = fopen("hitslog.log", "w");
if($file)
{
  $hits = file_get_contents("hitslog.log");
  if(!is_numeric($hits) || empty($hits)) $hits = 1;
  $hits++;
  fwrite($file, $hits);
  fclose($hits);  

}

/* End Hit Counter */

?>

Maybe that helps 🙂

Note: If on *nix, make sure the "hitslog.log" chmod is 777

bradgrafelman

Or, you could add the user the webserver is running under to a special group all users belong to, and use a '770' permission level so that only the owner and the webserver can modify/read the file.

Again, this is only a 'nix based solution.

abc

If you just doing a simple counter, I would just use 'r+' and set the file to cetrain length then just use fgets();, fseek(); and fputs(); This way you dont have to to call (2) IO operations.

<?

$max = 8; // counter digits

$file = 'counter.txt';

if ( ! file_exists ( $file ) )
{
	$fp = fopen ( $file, 'w' );
	fputs ( $fp, sprintf ( '%' . $max . 's', 1 ) );
}
else
{
	$fp = fopen ( $file, 'r+' );
	$data = trim ( fgets ( $fp, ( $max + 1 ) ) );
	fseek ( $fp, 0 );
	fputs ( $fp, sprintf ( '%' . $max . 's', ++$data ) );
}

	fclose ( $fp );

?>

abc