[Resolved] Bad Query?

AndrewWest

Hello, Could someone help me figure out what's wrong witht this query? It's late so it could be easy, but I don't think that's it..

$result = mysql_query("SELECT id FROM members WHERE name=".$m.");
if (!$result) {
   die('Invalid query: ' . mysql_error());
}

The error thrown is:

Invalid query: Unknown column 'Andrew' in 'where clause'

Btw the $m variable is Andrew, but I don't know what it's saying unknown column, because Andrew IS in the name colum in the table Members

Also, FYI this has a mysql connection attached to it that works elsewhere so it is connecting to the DB..

Thanks,
Andrew

PallaviDalvi

try doing this
$result = mysql_query("SELECT id FROM members WHERE name='".$m."');

since name is a field with text values(i assume so) it needs to be checked against a text value. hope this helps.

tommynanda

I guess vB messed up Pallavi's code... anyways u could do this way too... u dont have to concat... Note the single qoutes around $m than . .

$result = mysql_query("SELECT id FROM members WHERE name='$m'"); 
if (!$result) { 
   die('Invalid query: ' . mysql_error()); 
}

Good Luck
TommYNandA

Ravenous

The above post should solve your problem. Without the single quotes, MySQl thinks the variable name is another field. Add the single quotes and all should be well. Also, I am unsure as to the truth of this, but I think PHP will parse the string faster when you do not use concatenation. Can anyone back this up?

nitelight

actually u can shorten it to:
$result = mysql_query("SELECT id FROM members WHERE name='$m'") or die('Invalid query: ' . mysql_error());

instead of:

$result = mysql_query("SELECT id FROM members WHERE name='$m'");

if (!$result) {

die('Invalid query: ' . mysql_error());

}

they are the same thing, but shorter. (:
hope i helped. ^_

AndrewWest

Thanks guys! All better. Was stupid mistake.. :rolleyes: I've done a lot of them lately.

I've got this discussion board about 100% based out. After the base out is done I'm going to take my time adding features, and limitations to it.

I am going to definately have lots of fun making it secure. o-O