quick function query

[Lcousins]

another problem proving my php skills (or at least memory)are declining fast...

I wish to put:

$db = mysql_connect("localhost", "username", "password");
mysql_select_db("ufaadmin_virtualufa",$db);

into a function due to it being repeated a zillion times accross the site.

dbconnect(){
$db = mysql_connect("localhost", "username", "password");
mysql_select_db("ufaadmin_virtualufa",$db);
}

which I then call

dbconnect();
$result = mysql_query("select * from int_resources where cat='$cat' and live='yes' order by subcat asc",$db);

its coming up with a not a valid mysql link resource thingy error, but seeing as how it workeed before I put the first part into a function what am I doing wrong!!??

thanks in advance!

m.

[TheDefender]

Instead of calling functions all over the place, I typically use a separate include file called connect.inc.php and have my connection script included in that at the top of my pages.

Just food for thought...

[cLFlaVA]

Is this function in a separate file? If so, then you need to declare $db globally.

Otherwise, you're setting $db in the file which the function resides in, but once you bring focus back to the calling script, $db is blank.

[Lcousins]

Hi,

sorry I should have made it clear, the dbconnect function is stored in a seperate inc file along with a number of other functions used repeatedly around the site.

Thanks for the responses, I guess I am getting confused about global variables, Im using the other functions Ive put in the inc file for big blocks of html, which I guess doesnt need anything to be declared as a global variable.

So how do I tell what I need to declare and what just works ??

m.

[TheDefender]

No, you made it clear... What I am saying is why functionalize it at all, since you are including it in that file anyhow? It's one less line of code to have to debug later, should you have script problems...

Instead of functionalizing it, just put it at the top of your include file as:

$db = mysql_connect("localhost", "username", "password"); 
mysql_select_db("ufaadmin_virtualufa",$db);

That way, the call is made to the DB, whenever it is needed, automatically, and since MySQL will close the connection at scripts end automatically, you don't even have to clean up after it. This way, you won't have to remember to code your function call before you code the query... It's always there. Just write the query and go.