Image Upload Fails - Code Segment - What's Wrong?

[BLottman]

Here's the error I'm getting:

Warning: move_uploaded_file(/home/public_html/img/shuffleboard.jpg): failed to open stream: No such file or directory in /home/solidsns/public_html/uploadpictures.php on line 349

---

Here's the form section:

<form enctype="multipart/form-data" action="<?=$_SERVER['PHP_SELF']?>" method="post">
<input name="upload1" type="file"><br>
Photo 1 Upload (Max Image File Size 500K😎:<br><br><br>
<input name="upload2" type="file"><br>
Photo 2 Upload (Max Image File Size 500K😎:<br><br><br>
<input name="upload3" type="file"><br>
Photo 3 Upload (Max Image File Size 500K😎:<br><br><br>
<input type="hidden" name="MAX_FILE_SIZE" value="500000">
<input type="submit" name="submit" value="Upload"><br>
</table>
</form>

Here's the code segment to process on submit:

$dest_dir = '/home/solidsns/public_html/img/';
$uploadfile1 = $dest_dir . $_FILES['upload1']['name'];
$uploadfile2 = $dest_dir . $_FILES['upload2']['name'];
$uploadfile3 = $dest_dir . $_FILES['upload3']['name'];

if (isset($_FILES['upload1']))
   {
             if ($_FILES['upload1']['size'] > "500000")
                 {
           			error('File upload failed! File size greater than 500 KB');
                 }
             else
                 {
                    move_uploaded_file($_FILES['upload1']['tmp_name'], $uploadfile1);
                 } // End of File Size Check
   } // End if isset file uploaded

---

There are three uploads: upload1, upload2, and upload3

I've searched plenty of problem records on the site, have RTFM till I'm blue, and have tried so many different ways and still no success. What am I doing wrong?

I'd appreciate any help you can provide. Thanks.

[sneakyimp]

what is the significance of the path (/home/public_html/img/shuffleboard.jpg)

is that your TMP folder? usually tmp_name refers to the path to the file's temporary location.

i would recommend adding some more error checking code to your move_uploaded_file() function. right now, we have no idea what this function does.

I use file placement code that goes something like this:

	$tmp_name = $_FILES[$img_field_name]['tmp_name'];
	$filename = $_FILES[$img_field_name]['name'];
	$filesize = $_FILES[$img_field_name]['size'];
	$filetype = $_FILES[$img_field_name]['type'];

if ((!$tmp_name) || (!$filename) || (!filesize)) {
	$error = "Critical field left blank: $tmp_name, $filename, $filesize";
}

if (!file_exists($tmp_name)) { 
	$error .= "$filename failed to upload!"; 
}
// check the file size must be less than the maximum size (see config.php) 
if ($filesize >= MAX_UPLOAD_SIZE) { 
	$error .= "File $filename is too big!"; 
}
// check the file type 
if (($filetype != 'image/gif')  && 
	($filetype != 'image/pjpeg')) { 
	$error .= "The file can only be a GIF or JPEG.  This file was type:" . $filetype;
}

// see if the file exists on the server already
if(file_exists(FS_UPLOAD . "/" . $filename)) { 
    $error .= "A file named '" . $filename . "' already exists. Please rename the file and try again.";
}

// if there are no errors, TRY TO PLACE THE FILE IN THE UPLOAD DIRECTORY
if (!$error) {
	// this is where it will go...
	$image_destination_path = FS_UPLOAD . "/" . $filename;
	// try to copy it
	if(!copy($tmp_name, $image_destination_path)) { 
		// if that doesn't work, try to change permissions
		if(!chmod(FS_UPLOAD, 0777)) {
			$error .= "The webserver's file permissions do not allow you to upload. CHMOD check failed.";
		} else {
			// if the permissions attempt succeeded, try to copy again.
			if(!copy($tmp_name, $image_destination_path)) { 
				$error .= "FILE COPY OPERATION FAILED.  Please notify the webmaster.";
			} //copy image to correct location again
		} // if not copy, try chmod then copy
	} // try to copy it
}

//ONE LAST CHECK.
if (!file_exists($image_destination_path)) {
	$error .= "FILE PLACEMENT OPERATION FAILED FOR UNKNOWN REASON.  File not found.";
}


if ($error) {
	echo "FAILED: $error";
}