echoing twice?

[mabans]

I have a script that shows information on a game server. Shows like player name and score, etc..

Now within the site I have each clan member registers their in game handle so people know who each member in the clan is.

Now in the script that shows the game server info it shows the player name, and by my theory the same name in the clan is the same name used in the actual game, which get's displayed.

Now what I'm trying to do is a query gets done and gets all the member handles and compares it to the list in the game server info. If the in game handle within the game matches the handle that is in the MySQL database it creates a link to that member's profile page.

Now this is what I have created:

    <?php

$p = "SELECT * FROM clanMembers";
$r = mysql_query($p);
$player = array();

while($userRow = mysql_fetch_assoc($r))
	{
	$player[$userRow['ID']] = array	(
									'ID' => $userRow['ID'],
									'haloHandle' => $userRow['haloHandle']
									);
	}

foreach($player as $id => $playerInfo)
	{
	if ($data[$server_id][players][$np][player] == $playerInfo['haloHandle'])
		{
		echo "<a href=\"" .$_SERVER['PHP_SELF'] ."?action=members&memrefID=" .$playerInfo['ID'] ."\">" .$playerInfo['haloHandle'] ."</a>";
		}
	else
		{
		echo $data[$server_id][players][$np][player];
		}
	}
?>

Now the problem is it displays and creates the link fine, but then echos the player name again. so you would get duplicate names rather than just echoing it just once. What can I do it so it just echo's once. Any help would be great.

Here's the link:
http://www.unisonclan.com/index.php?action=test&game=halo you'll see what I'm talking about. BTW I'm "MÂßÂѧ" on there.

[dnast]

Unless you left out some code, I don't see any way it could echo a name twice.

BTW, [player] and [players] should have quotes i.e. ['player'] and ['players'].

[mabans]

If you follow the link you will see what I mean. Your right nothing is left out, no idea why it's doing it twice.

For the sake of being well informed here's the entire script where that portion is found.

<table width="535" border="0" cellspacing="0" cellpadding="0">
      <tr>
        <td><img src="images/sitewide/news_a_01.gif" width="535" height="10"></td>
  </tr>
</table>
      <table width="535" border="0" cellspacing="0" cellpadding="0">
        <tr>
          <td bgcolor="#666666"><table width="100%" border="0" cellspacing="5" cellpadding="0">
            <tr>
              <td>


<?php // include the script
include('includes/gameq/class.gameq.php');

switch($game)
{
case "halo":

// define the servers
include('includes/gameq/halo.php');

// initialise class
$query = new GameQ;

// query the servers
$data = $query->getInfo($servers);

// go through all servers
foreach ($servers AS $server_id => $values)
{
    // if there are no error messages, print out the data for the server
    if (!isset($query->err_msg[$server_id]))
    {
?>

<table width="100%" align="center">
  <tr>
    <td valign="top">	<table width="100%">
        <tr>
          <td width="100%" class="TitleName"><?php echo $data[$server_id][custom][name]; ?></td>
        </tr>
        <tr>
          <td>Teamspeak Server IP: <strong>67.18.159.178:5580</strong></td>
        </tr>
        <tr>
          <td>Server IP address: <b><?php echo   $data[$server_id][custom][address]
	.":"
	.$data[$server_id][custom][query_port] ?></b></td>
        </tr>
        <tr>
          <td>Running Version: <b><?php echo $data[$server_id][gamever]; ?></b></td>
        </tr>
        <tr>
          <td height="14">This is currently a
              <?php if ($data[$server_id][gamemode] == openplaying)
	{
	echo "<b>public</b>";
	}
else
	{
	echo "<b>private</b>";
	} ?>
    Server</td>
        </tr>
        <tr>
          <td height="14">There are <b><?php echo 
        $data[$server_id][numplayers]
	." out of a maximum "
	.$data[$server_id][maxplayers]
 ?></b> Players</td>
        </tr>
        <tr>
          <td height="14">Current game is <b><?php echo $data[$server_id][gametype]; ?></b>
 of type <b>"<?php echo $data[$server_id][gamevariant];?>"</b> settings.
          </td>
        </tr>
        <tr>
          <td height="14">The Frag/Score Limit is <b><?php echo $data[$server_id][fraglimit]; ?></b>.</td>
        </tr>
    </table>	</td>
    <td width="175">
      <div align="center"><img src="/images/mapname/<?php echo $data[$server_id][mapname]; ?>.gif" width="175" height="143"><br>
          <b>
          <?php
							 switch($data[$server_id][mapname])
							 {
							 	case "beavercreek":
									echo "Battle Creek";
									break;
								case "bloodgulch":
									echo "Blood Gulch";
									break;
								case "boardingaction":
									echo "Boarding Action";
									break;
								case "carousel";
									echo "Derelict";
									break;
								case "chillout";
									echo "Chillout";
									break;
								case "damnation";
									echo "Damnation";
									break;
								case "dangercanyon";
									echo "Danger Canyon";
									break;
								case "deathisland";
									echo "Death Island";
									break;
								case "gephyrophobia";
									echo "Gephryophobia";
									break;
								case "hangemhigh";
									echo "Hang 'Em High";
									break;
								case "icefields";
									echo "Ice Fields";
									break;
								case "infinity";
									echo "Infinity";
									break;
								case "longest";
									echo "Longest";
									break;
								case "prisoner";
									echo "Prisoner";
									break;
								case "putput";
									echo "Chiron TL34";
									break;
								case "ratrace";
									echo "Rat Race";
									break;
								case "sidewinder";
									echo "Sidewinder";
									break;
								case "timberland";
									echo "Timberland";
									break;
								case "wizard";
									echo "Wizard";
									break;
								case "unknown";
									echo "Unknown";
									break;							}
							?>
      </b> </div></td>
  </tr>
</table>

<?php
if	($data[$server_id][teamplay] == 1)
 	{
?>
<p>
<table border="0" cellspacing="0" cellpadding="2" align="center">
  <tr align="center">
    <td colspan="2" class="TitleName" nowrap>Current Match Standings</td>
  </tr>
  <tr align="center">
    <td>
	<b><font color="#FF0000">
	<?php
	echo $data[$server_id][team_t0];
	?>
	</font></b>
	<?php
	echo ":"
		.$data[$server_id][score_t0];
	?>
	</td>
    <td>
	<b><font color="#0000FF">
	<?php
	echo $data[$server_id][team_t1];
	?>
	</font></b>
	<?php
	echo ":"
		.$data[$server_id][score_t1];
	?>
	</td>
  </tr>
</table>
</p>
<?php
}
?>

<table width="100%" border="0" cellspacing="0" cellpadding="2" align="center">
  <tr>
    <td class="TitleName" align="center" colspan="3" nowrap>Player list and Information</td>
  </tr>
  <tr align="center" class="StatsInfo">
    <td width="33%">Halo Handle </td>
    <td width="33%">Score</td>
<?php
if	($data[$server_id][teamplay] == 1)
 	{
?>
<td width="33%">Team</td>
<?php
}
?>
  </tr>

<?php
for($np=0;$np<$data[$server_id][numplayers];$np++)
{
?>
<tr  align="center">
    <td>
    <?php

$p = "SELECT * FROM clanMembers";
$r = mysql_query($p);
$player = array();

while($userRow = mysql_fetch_assoc($r))
	{
	$player[$userRow['ID']] = array	(
									'ID' => $userRow['ID'],
									'haloHandle' => $userRow['haloHandle']
									);
	}

foreach($player as $id => $playerInfo)
	{
	if ($data[$server_id][players][$np][player] == $playerInfo['haloHandle'])
		{
		echo "<a href=\"" .$_SERVER['PHP_SELF'] ."?action=members&memrefID=" .$playerInfo['ID'] ."\">" .$playerInfo['haloHandle'] ."</a>";
		}
	else
		{
		echo $data[$server_id][players][$np][player];
		}
	}
?>



</td>
<td><?php echo $data[$server_id][players][$np][score]; ?></td>
<?php
if	($data[$server_id][teamplay] == 1)
 	{
?>
    <td>
	<?php
	if ($data[$server_id][players][$np][team] == 0)
		{
	?>
	<font color="#FF0000"><b>
	<?php
	echo $data[$server_id][team_t0];
	?>
	</b></font>
	<?php
		}
	else
		{
	?>
	<font color="#0000FF"><b>
	<?php
	echo $data[$server_id][team_t1];
	?>
	</b></font>
	<?php
		}
	?>


</td>
<?php
	}
	}
?>
</tr>
</table>

<?php
		}
	}
}
?></td>
            </tr>
          </table></td>
          <td width="10" bgcolor="#999999"><img src="images/blank.gif" width="10" height="10"></td>
        </tr>
      </table>
      <table width="535" border="0" cellspacing="0" cellpadding="0">
        <tr>
          <td width="35"><img src="images/sitewide/news_a_03.gif" width="35" height="35"></td>
          <td><table width="100%" height="35" border="0" cellpadding="0" cellspacing="0">
            <tr>
              <td bgcolor="#666666">&nbsp;</td>
            </tr>
            <tr>
              <td height="10" bgcolor="#999999"><img src="images/blank.gif" width="10" height="10"></td>
            </tr>
          </table></td>
          <td width="35"><img src="images/sitewide/news_a_02.gif" width="35" height="35"></td>
        </tr>
        <tr>
          <td>&nbsp;</td>
          <td align="right" class="gameQ">Powered by: <a href="http://gameq.sourceforge.net/" target="_blank">GameQ</a></td>
          <td>&nbsp;</td>
        </tr>
</table>

[mabans]

I'm suspecting it's the something to do with this

foreach($player as $id => $playerInfo)
{
}

Something to do with that is messing stuff up..

[dnast]

Hmm...you think you might have duplicate (but one with maybe whitespace around it) names in $player?

You can use [man]print_r/man; before the loop and see if that's the case.

[mabans]

I FIXED IT!!!!!!! yay!!!!

This is what I did.

<?php
	$playerName = $data[$server_id][players][$np][player];
	$s = "SELECT * FROM clanMembers WHERE haloHandle = '$playerName'";
	$r = mysql_query($s);
	$n = mysql_num_rows($r);

if ($n < 1)
	{
echo $playerName;
	}
else
	{
	$player = mysql_fetch_array($r);
	echo "<a href=\"" .$_SERVER['PHP_SELF'] ."?action=members&memrefID=" .$player['ID'] ."\">" .$player['haloHandle'] ."</a>";
	}

?>

See it in action:

http://www.unisonclan.com/index.php?action=serverinfo&game=halo