[Resolved] some help required with my code... it wont remove 2 characters

ajdegans

Ok i have this code. Now the problem is... its suppose to show some downloads in a list... to achieve that i had to put in a drive letter since the map is on another drive (its a windows server)

But now the problem is when the files are showing up it also shows the drive number E: i want to be hidden

i put in the function text2text() to remove the e: but it wont remove the thing... the function works so it must be in the function call to recursedir()

can someone look at the code, test it and see if theres a sollution to my problem?

Many thanks in advance 😃

<?php
$downloads = "e:" . "download";
$url = "http://www.yourdomain.com";

//removes the E: from the path
function text2text($input) 
{ $output = str_replace("e:","&nbsp;",$input); 
return $output; 
} 

//lists the files and folders
function recursedir($downloads) {
       $hndl=opendir($downloads);
       while($file=readdir($hndl)) {
               if ($file=='.' || $file=='..') continue;
                       $completepath="$downloads/$file";
                       if (is_dir($completepath)) {
                               # its a dir, recurse.
                               recursedir($downloads.'/'.$file);
                               //print "<a href='$url/$downloads/$file'>$downloads/$file</a><br>\n";
                       } //end if 
             	       else {
                               # its a file.
                               print "<a href='$url/$downloads/$file'>$downloads/$file</a><br>\n";
                       }
       } //end while
} //end function

//shows the content
$content = recursedir($downloads);
$content = text2text($content); 
echo $content;

?>

Weedpacket

The problem is that your recursedir() function outputs all the text it generates - it doesn't return anything to be put into $content. So all you're ever sending to text2text is an empty string, and all that HTML ("e:" and all) is already cheerfully heading out to the client. (You'd've noticed this if you'd taken out that echo $content at the bottom.)

Try something more like this:

$downloads = "e:" . "downloads";
$url = "http://www.example.com";

//removes the E: from the path
function text2text($input) 
{ $output = str_replace("e:","&nbsp;",$input); 
return $output; 
} 

//lists the files and folders
function recursedir($downloads) {
	global $url;
	$html = '';
	$hndl=opendir($downloads);
	while($file=readdir($hndl)) {
		if ($file=='.' || $file=='..') continue;
		$completepath="$downloads/$file";
		if (is_dir($completepath)) {
			# its a dir, recurse.
			$html .= recursedir($downloads.'/'.$file);
			//print "<a href='$url/$downloads/$file'>$downloads/$file</a><br>\n";
		} //end if
		else {
			# its a file.
			$html .= "<a href='$url/$downloads/$file'>$downloads/$file</a><br>\n";
		}
	} //end while
	return $html;
} //end function

//shows the content
$content = recursedir($downloads);
$content = text2text($content); 
echo $content;

(And note that I've fixed your $url as well - otherwise it would have been an empty string inside the function.)

ajdegans

Hah thanks, it works 😃

I overlooked your code...

        if (is_dir($completepath)) { 
            # its a dir, recurse. 
            $html .= recursedir($downloads.'/'.$file); 
            //print "<a href='$url/$downloads/$file'>$downloads/$file</a><br>\n"; 
        } //end if 
        else { 
            # its a file. 
            $html .= "<a href='$url/$downloads/$file'>$downloads/$file</a><br>\n"; 
        } 
    } //end while 
    return $html; 
} //end function

I understand the $html values make it so that the recursedir() is no empty string anymore? (or however you say it :mad: )

Also you said you fixed the $url... i noticed you put in 'global $url;'

But when i tested it without, the url was just fine... So what does the global do then? since it seems it doesnt actually make any diference? or am i missing something here 🙂

And yes i know the $downloads and $url is headed out to the client but for the people who come on my site most dont even know how to view the source of the page... and aslong as i do not put in a echo $downloads; or whatever it doesnt show...

anyway, thanks for helping me out that quick 😃 😃

Weedpacket

Originally posted by ajdegans
Also you said you fixed the $url... i noticed you put in 'global $url;'

But when i tested it without, the url was just fine... So what does the global do then? since it seems it doesnt actually make any diference? or am i missing something here 🙂

Because inside the function, $url wasn't defined. Look at the generated HTML (you might assume your users are too thick to use "view source", but you should be able to do it) with and without the "global $url" line. Don't just assume that whatever you see in the address bar when you click on a link is what the link actually contains.

I understand the $html values make it so that the recursedir() is no empty string anymore?

Yes, I put that in so that recursedir() would actually do something other than just send stuff to the client.

And yes i know the $downloads and $url is headed out to the client

I meant that the recursedir() function was sending everything to the client - it was doing all the printing itself. It wasn't returning anything to the rest of the script, so nothing was getting into $content, and so nothing was getting into text2text(). Which is why your function wasn't working.

ajdegans

ok 🙂 ic now...

Thanks!