This does not add!!

NZ_Kiwi

Any ideas why?

<?php
mysql_connect (localhost, user, pass);
mysql_select_db (databasename);
?>

<?php


if ($action == "save")
{


$result = mysql_query ("INSERT INTO news Values ('','$header','$from','$body,'$source','$pic','$result','$AKL','$BCC','$WCB','$NPL','$PMR','$WLG','$OHA','$CHC','$AGE,'$NZK','$NZW')");



?>


<title>Rugby League in New Zealand Admin</title>


<br>
<strong><font face="Verdana" size="2">All done!</font></strong><font face="Verdana"><strong><font size="2"><br>
</font>
</strong><font size="2">Your news item has been added.</font></font></p>
<p><font face="Verdana"
size="2"><a href="index.php">Return to the the main menu</a>

<?php


} else {

?>
<p>
<font face="Verdana"
size="2">
<p>
<strong>Rugby League in New Zealand Administration</strong> &nbsp; -
</font>
<font face="Verdana"
size="1"><a href="index.php">Back to the main</a></font><p>
<font face="Verdana" size="1">Enter your club details below, if you have any 
questions please contact <a href="mailto:ff@ff.com">me</a></font><hr><font face="Verdana"
size="2">

<form method="POST" action="addnews.php?action=save">
  <p><strong style="font-weight: 400">Title: 
  </strong><font face="Verdana" size="3">
  <input name="header" size="40" style="text-decoration: none; border-style: solid; border-width: 1px"></font> </p>
	<p>Author <font face="Verdana" size="3">
  <input name="from" size="40" style="text-decoration: none; border-style: solid; border-width: 1px"></font></p>
	<p>Source <font face="Verdana" size="3">
  <input name="source" size="40" style="text-decoration: none; border-style: solid; border-width: 1px"></font></p>
<p>Front Page Picture
	<select size="1" name="pic" style="text-decoration: none; border-style: solid; border-width: 1px">
	</select></p>



<p>


<textarea rows="17" name="body" cols="86" style="border-style: solid; border-width: 1px"></textarea></p>
<hr color="#000000" size="1">
<table border="0" width="100%" id="table1">
	<tr>
		<td width="50%" align="left" valign="top"><font face="Verdana"
size="2">

		<input type="checkbox" name="AKL" value="ON">Auckland<p>
		<input type="checkbox" name="BCC" value="ON">Bartercard Cup</p>
		<p><input type="checkbox" name="WCB" value="ON">Waicoa Bay</p>
		<p><input type="checkbox" name="PMR" value="ON"> Western Alliance</font></p>
		<p><font face="Verdana"
size="2">

		<input type="checkbox" name="AGE" value="ON">Age Groups</font></p>
		<p>&nbsp;</td>
		<td align="left" valign="top" width="50%"><font face="Verdana"
size="2">

		<input type="checkbox" name="WLG" value="ON">Wellington</font><p>
		<font face="Verdana"
size="2">

		<input type="checkbox" name="CHC" value="ON">Canterbury</font></p>
		<p><font face="Verdana"
size="2">

		<input type="checkbox" name="DUD" value="ON">Southern Alliance</font></p>
		<p><font face="Verdana"
size="2">

		<input type="checkbox" name="NZK" value="ON">New Zealand Kiwis</font></p>
		<p><font face="Verdana"
size="2">

		<input type="checkbox" name="NZW" value="ON">New Zealand Warriors</font></p>
		<p>&nbsp;</td>
	</tr>
</table>
<hr color="#000000" size="1">
<p>&nbsp;</p>
  <p>
	  <br><br>

  <input type="submit" value="Save" name="B1" style="text-decoration: none; font-family: Verdana; border-style: solid; border-width: 1px"></p>
</form>

<?php

}


?>
</body>
</font>
</html>

tsinka

Hi,

add mysql_error like

$result = mysql_query("INSERT .....") or die("INSERT error: ".mysql_error());

This should print any mysql errors (syntax error, connection error ...)

Change

and use

$_POST['action'] instead of $action

Thomas

mourisj

$result = mysql_query ("INSERT INTO news Values ('','$header','$from','$body,'$source','$pic','$re
sult','$AKL','$BCC','$WCB','$NPL','$PMR','$WLG','$
OHA','$CHC','$AGE,'$NZK','$NZW')");

You have a variable $result in your insert statement AND a variable $result as the "answer" from the database!!

Either, this doesn't work at all, or, at least, it overwrites the value of your $result variable with the result from the database.

So, anyway, you should avoid this!!

HTH

JJ Mouris

NZ_Kiwi

Originally posted by mourisj
$result = mysql_query ("INSERT INTO news Values ('','$header','$from','$body,'$source','$pic','$re
sult','$AKL','$BCC','$WCB','$NPL','$PMR','$WLG','$
OHA','$CHC','$AGE,'$NZK','$NZW')");

You have a variable $result in your insert statement AND a variable $result as the "answer" from the database!!

Either, this doesn't work at all, or, at least, it overwrites the value of your $result variable with the result from the database.

So, anyway, you should avoid this!!

HTH

JJ Mouris

<?php
mysql_connect (localhost, username, pass);
mysql_select_db (table);
?>

<?php


if ($action == "save")
{


$result = mysql_query ("INSERT INTO news Values ('','$header','$from','$IMG,'$body','$source','$result_id','$WRE','$AKL','$TRG','$PMR','$NPL','$WLG','$OHA','$CHC','$DUD','$NZK','$NZW','$NZI','$AGE','$EDI','$BCC','$BULLS','$FLA','$REP')");



?>


<title>Rugby League in New Zealand Admin - Add News</title>


<br>
<font face="Verdana">
<strong><font size="2">All Done!<br>
</font>
</strong><font size="2">The news item has been added.<br>
&nbsp;</font></font></font></p>
<p><font face="Verdana"
size="2"><a style="text-decoration: none" href="index.php">Return to the main menu</a>

<?php


} else {

?>
<p>

<font face="Verdana" size="1">
<a style="text-decoration: none" href="index.php">Back to the main</a></font><p>
<font face="Verdana" size="1">If you have any questions please contact
<a style="text-decoration: none" href="mailto:bevan@rugbyleaguenz.com">Bevan</a></font><hr>
<font face="Verdana" size="2">

<form method="POST" action="addnews.php?action=save">



<font face="Verdana" size="2">Header: <br><input name="header" size="40" style="font-family: Verdana; border-style: solid; border-width: 1px"></font><p>

<font face="Verdana" size="2">From:<br> <input name="from" size="40" style="font-family: Verdana; border-style: solid; border-width: 1px"></font><p>

<font face="Verdana" size="2">Image:<br> <input name="IMG" size="40" style="font-family: Verdana; border-style: solid; border-width: 1px"></font><p>

<font face="Verdana" size="2">Body: <br><textarea rows="10" name="body" cols="77" style="font-family: Verdana; border-style: solid; border-width: 1px"></textarea>

<font face="Verdana" size="2">Source:<br> <input name="source" size="40" style="font-family: Verdana; border-style: solid; border-width: 1px"></font><p>

<font face="Verdana" size="2">Result ID:<br> <input name="result_id" size="40" style="font-family: Verdana; border-style: solid; border-width: 1px"></font><p>





<p>
<input type="checkbox" value="1" name="WRE"> Northland <br>
<input type="checkbox" value="1" name="AKL"> Auckland <br>
<input type="checkbox" value="1" name="TRG"> Waicoa Bay <br>
<input type="checkbox" value="1" name="PMR"> Western Alliance <br>
<input type="checkbox" value="1" name="NPL"> Taranaki <br>
<input type="checkbox" value="1" name="WLG"> Wellington <br>
<input type="checkbox" value="1" name="OHA"> Defence <br>
<input type="checkbox" value="1" name="CHC"> Canterbury RL <br>
<input type="checkbox" value="1" name="DUD"> Southern Alliance <br>
<input type="checkbox" value="1" name="NZK"> New Zealand Kiwis <br>
<input type="checkbox" value="1" name="NZW"> New Zealand Warriors <br>
<input type="checkbox" value="1" name="NZI"> New Zealand International <br>
<input type="checkbox" value="1" name="AGE"> Age Groups <br>
<input type="checkbox" value="1" name="EDI"> Editorials <br>
<input type="checkbox" value="1" name="BCC"> Bartercard Cup <br>
<input type="checkbox" value="1" name="BULLS"> Canterbury Bulls <br>
<input type="checkbox" value="1" name="FAL"> Central Falcons <br>
<input type="checkbox" value="1" name="REP"> Rep Footie 



  <p align="center">
	  <br><br>

  <input type="submit" value="Save" name="B1" style="border-style: solid; border-width: 1px"></p>
</form>

<?php

}


?>
</body>
</font>
</html>

and my table is set up like this

CREATE TABLE news (
id int(10) NOT NULL auto_increment,
header varchar(250) NOT NULL default '',
from varchar(250) NOT NULL default '',
IMG varchar(250) NOT NULL default '',
body text NOT NULL,
source varchar(250) NOT NULL default '',
result_id int(11) default NULL,
WRE int(11) default NULL,
AKL int(11) default NULL,
TRG int(11) default NULL,
PMR int(11) default NULL,
NPL int(11) default NULL,
OHA int(11) default NULL,
WLG int(11) default NULL,
CHC int(11) default NULL,
DUD int(11) default NULL,
NZK int(11) default NULL,
NZW int(11) default NULL,
NZI int(11) default NULL,
AGE int(11) default NULL,
EDI int(11) default NULL,
BCC int(11) default NULL,
BULLS int(11) default NULL,
FAL int(11) default NULL,
REP int(11) default NULL,
KEY id (id)
) TYPE=MyISAM AUTO_INCREMENT=2 ;

Uchiha_Sasuke

hmm...try this, for the PHP part

<?php

if ($action == "save")
{

$result = mysql_query ("INSERT INTO news VALUES ('','$header','$from','$body,'$source','$pic','$result','$AKL','$BCC','$WCB','$NPL','$PMR','$WLG','$OHA','$CHC','$AGE,'$NZK','$NZW')");

eriksmoen

make sure you check the spelling of the variables you are sending... upon quick glance, i noticed the table and select option field name were "FAL" and you have "FLA" in your query statement... which will cause it to break. just go through each line verifying that every variable is correctly spelled.

Also remember, as mentioned earlier, that you can not have $result = mysql_query("....$result....") ... you will need to change all instances of either one $result or the other... whichever is easier to change, i would recommend it.

hope that helps.

NZ_Kiwi

Originally posted by Uchiha Sasuke
hmm...try this, for the PHP part

<?php

if ($action == "save")
{

$result = mysql_query ("INSERT INTO news VALUES ('','$header','$from','$body,'$source','$pic','$result','$AKL','$BCC','$WCB','$NPL','$PMR','$WLG','$OHA','$CHC','$AGE,'$NZK','$NZW')");

?>

fixed the FAL and i get this error

INSERT error: You have an error in your SQL syntax near 'NZRL','','','','','','','','1','','',','','','','','','','','')' at line 1

eriksmoen

what is 'NZRL' ?

eriksmoen

also just discovered this...
INSERT error:
You have an error in your SQL syntax near 'NZRL','','','','','','','','1','','',','','','','','','','','')' at line 1
----------------------------------------------------------------^

there is a single quote somewhere in your syntax or the string being passed to mysql.

NZ_Kiwi

Originally posted by eriksmoen
also just discovered this...
INSERT error:
You have an error in your SQL syntax near 'NZRL','','','','','','','','1','','',','','','','','','','','')' at line 1
----------------------------------------------------------------^

there is a single quote somewhere in your syntax or the string being passed to mysql.

not sure what you mean.. but you see all my code above... this has me 😕

eriksmoen

the 3rd quote set after the '1' only has 1 quote... which would mess it up. basically it's where $IMG is....

change

$result = mysql_query ("INSERT INTO news Values ('','$header','$from','$IMG,'$body','$source','$result_id','$WRE','$AKL','$TRG','$PMR','$NPL','$WLG','$OHA','$CHC','$DUD','$NZK','$NZW','$NZI','$AGE','$EDI','$BCC','$BULLS','$FLA','$REP')");

$result = mysql_query ("INSERT INTO news Values  ('','$header','$from','$IMG','$body','$source','$result_id','$WRE','$AKL','$TRG','$PMR','$NPL','$WLG','$OHA','$CHC','$DUD','$NZK','$NZW','$NZI','$AGE','$EDI','$BCC','$BULLS','$FLA','$REP')");

NZ_Kiwi

Originally posted by eriksmoen
the 3rd quote set after the '1' only has 1 quote... which would mess it up. basically it's where $IMG is....

change

$result = mysql_query ("INSERT INTO news Values ('','$header','$from','$IMG,'$body','$source','$result_id','$WRE','$AKL','$TRG','$PMR','$NPL','$WLG','$OHA','$CHC','$DUD','$NZK','$NZW','$NZI','$AGE','$EDI','$BCC','$BULLS','$FLA','$REP')");

$result = mysql_query ("INSERT INTO news Values  ('','$header','$from','$IMG','$body','$source','$result_id','$WRE','$AKL','$TRG','$PMR','$NPL','$WLG','$OHA','$CHC','$DUD','$NZK','$NZW','$NZI','$AGE','$EDI','$BCC','$BULLS','$FLA','$REP')");

[/B]

ok, this is my code now

<?php
mysql_connect (localhost, user, pass);
mysql_select_db (table);
?>

<?php 


if ($action == "save") 
{ 

$result = mysql_query ("INSERT INTO news Values '','$header','$from','$IMG','$body','$source','$result_id','$WRE','$AKL','$TRG','$PMR','$NPL','$WLG','$OHA','$CHC','$DUD','$NZK','$NZW','$NZI','$AGE','$EDI','$BCC','$BULLS','$FLA','$REP')") or die("INSERT error: ".mysql_error()); 


?>

<title>Rugby League in New Zealand Admin - Add News</title>


<br>
<font face="Verdana">
<strong><font size="2">All Done!<br>
</font>
</strong><font size="2">The news item has been added.<br>
&nbsp;</font></font></font></p>
<p><font face="Verdana"
size="2"><a style="text-decoration: none" href="index.php">Return to the main menu</a>

<?php


} else {

?>
<p>

<head>
<script type="text/javascript">
			<!--
			function processchange ()
			{
				var theForm = document.getElementById('news');

			theForm.source.value = theForm.source2.value;
		}
		//-->
	</script>
</head>

<font face="Verdana" size="1">
<a style="text-decoration: none" href="index.php">Back to the main</a></font><p>
<font face="Verdana" size="1">If you have any questions please contact
<a style="text-decoration: none" href="mailto:bevan@rugbyleaguenz.com">Bevan</a></font><hr>
<font face="Verdana" size="2">

<form method="POST" action="addnews.php?action=save" id="news">



<font face="Verdana" size="2">Header: <br><input name="header" size="40" style="font-family: Verdana; border-style: solid; border-width: 1px"></font><p>

<font face="Verdana" size="2">From:<br> <input name="from" size="40" style="font-family: Verdana; border-style: solid; border-width: 1px"></font><p>

<font face="Verdana" size="2">Image:<br> <input name="IMG" size="40" style="font-family: Verdana; border-style: solid; border-width: 1px"></font><p>

<font face="Verdana" size="2">Body: <br><textarea rows="30" name="body" cols="77" style="font-family: Verdana; border-style: solid; border-width: 1px"></textarea>
<p>


<font face="Verdana" size="2">Source:<br> 
<input name="source" size="40" style="font-family: Verdana; border-style: solid; border-width: 1px"></font><p>

<font face="Verdana" size="1">Please select one of the options below as your source if you need to.<br>
<select name="source2" onchange="processchange();">
<option>Select a option</option>
<option value="NZRL">NZRL</option>
<option value="Vodafone Warriors">Vodafone Warriors</option>	

<br>			


		</select>
<p>


<font face="Verdana" size="2">Result ID:<br> <input name="result_id" size="40" style="font-family: Verdana; border-style: solid; border-width: 1px"></font><p>





<p>
<input type="checkbox" value="1" name="WRE"> Northland <br>
<input type="checkbox" value="1" name="AKL"> Auckland <br>
<input type="checkbox" value="1" name="TRG"> Waicoa Bay <br>
<input type="checkbox" value="1" name="PMR"> Western Alliance <br>
<input type="checkbox" value="1" name="NPL"> Taranaki <br>
<input type="checkbox" value="1" name="WLG"> Wellington <br>
<input type="checkbox" value="1" name="OHA"> Defence <br>
<input type="checkbox" value="1" name="CHC"> Canterbury RL <br>
<input type="checkbox" value="1" name="DUD"> Southern Alliance <br>
<input type="checkbox" value="1" name="NZK"> New Zealand Kiwis <br>
<input type="checkbox" value="1" name="NZW"> New Zealand Warriors <br>
<input type="checkbox" value="1" name="NZI"> New Zealand International <br>
<input type="checkbox" value="1" name="AGE"> Age Groups <br>
<input type="checkbox" value="1" name="EDI"> Editorials <br>
<input type="checkbox" value="1" name="BCC"> Bartercard Cup <br>
<input type="checkbox" value="1" name="BULLS"> Canterbury Bulls <br>
<input type="checkbox" value="1" name="FAL"> Central Falcons <br>
<input type="checkbox" value="1" name="REP"> Rep Footie 



  <p align="center">
	  <br><br>

  <input type="submit" value="Save" name="B1" style="border-style: solid; border-width: 1px"></p>
</form>

<?php

}


?>
</body>
</font>
</html>

if I enter GG to my fields and 11 into the result_id field and do not select any boxes i get this error

INSERT error: You have an error in your SQL syntax near ''','gg','gg','gg','gg','gg','11','','','','','','','','','','','','','','','',''' at line 1

eriksmoen

there are 25 fields in your mysql table, and only 23 are inserted... since it is not specified, mysql thinks that all fields are to be inserted into. so either you need to figure out which fields you are not entering data into, and enter NULL ('') values into, or you can change your query to something like:

insert into news(field1,field2,etc) values('value1','value2',etc)

where you replace field1 and field2 with the ones you use, and value1 and value2 with the values you use. note the ticks (``) in news are different than the single quotes('') you use in the values.

NZ_Kiwi

Originally posted by eriksmoen
there are 25 fields in your mysql table, and only 23 are inserted... since it is not specified, mysql thinks that all fields are to be inserted into. so either you need to figure out which fields you are not entering data into, and enter NULL ('') values into, or you can change your query to something like:

insert into news(field1,field2,etc) values('value1','value2',etc)

where you replace field1 and field2 with the ones you use, and value1 and value2 with the values you use. note the ticks (``) in news are different than the single quotes('') you use in the values.

So..........


$result = mysql_query ("INSERT INTO news (''','$header','$from','$IMG','$body','$source','$re
 sult_id','$WRE','$AKL','$TRG','$PMR','$NPL','$WLG'
,'$OHA','$CHC','$DUD','$NZK','$NZW','$NZI','$AGE',
'$EDI','$BCC','$BULLS','$FLA','$REP') Values ('','$header','$from','$IMG','$body','$source','$re
 sult_id','$WRE','$AKL','$TRG','$PMR','$NPL','$WLG'
,'$OHA','$CHC','$DUD','$NZK','$NZW','$NZI','$AGE',
'$EDI','$BCC','$BULLS','$FLA','$REP')") or die("INSERT error: ".mysql_error());

eriksmoen

this is your table:

id int(10) NOT NULL auto_increment,
header varchar(250) NOT NULL default '',
from varchar(250) NOT NULL default '',
IMG varchar(250) NOT NULL default '',
body text NOT NULL,
source varchar(250) NOT NULL default '',
result_id int(11) default NULL,
WRE int(11) default NULL,
AKL int(11) default NULL,
TRG int(11) default NULL,
PMR int(11) default NULL,
NPL int(11) default NULL,
OHA int(11) default NULL,
WLG int(11) default NULL,
CHC int(11) default NULL,
DUD int(11) default NULL,
NZK int(11) default NULL,
NZW int(11) default NULL,
NZI int(11) default NULL,
AGE int(11) default NULL,
EDI int(11) default NULL,
BCC int(11) default NULL,
BULLS int(11) default NULL,
FAL int(11) default NULL,
REP int(11) default NULL

^-- these are you field names.

$blah is an example of variables (which contain values)

so it needs to be something like:

insert into news(header,from,IMG,body,etc...) values('$header','$from','$IMG','$body',etc...)

NZ_Kiwi

Originally posted by eriksmoen
this is your table:

id int(10) NOT NULL auto_increment,
header varchar(250) NOT NULL default '',
from varchar(250) NOT NULL default '',
IMG varchar(250) NOT NULL default '',
body text NOT NULL,
source varchar(250) NOT NULL default '',
result_id int(11) default NULL,
WRE int(11) default NULL,
AKL int(11) default NULL,
TRG int(11) default NULL,
PMR int(11) default NULL,
NPL int(11) default NULL,
OHA int(11) default NULL,
WLG int(11) default NULL,
CHC int(11) default NULL,
DUD int(11) default NULL,
NZK int(11) default NULL,
NZW int(11) default NULL,
NZI int(11) default NULL,
AGE int(11) default NULL,
EDI int(11) default NULL,
BCC int(11) default NULL,
BULLS int(11) default NULL,
FAL int(11) default NULL,
REP int(11) default NULL

^-- these are you field names.

$blah is an example of variables (which contain values)

so it needs to be something like:

insert into news(header,from,IMG,body,etc...) values('$header','$from','$IMG','$body',etc...)

$result = mysql_query ("INSERT INTO news ('id','header','from','IMG','body','source','
result_id','WRE','AKL','TRG','PMR','NPL','WLG','OHA','CHC','DUD','NZK','NZW','NZI','AGE','EDI','BCC','BULLS','FLA','REP') Values ('','$header','$from','$IMG','$body','$source','$result_id','$WRE','$AKL','$TRG','$PMR','$NPL','$WLG','$OHA','$CHC','$DUD','$NZK','$NZW','$NZI','$AGE','$EDI','$BCC','$BULLS','$FLA','$REP')") or die("INSERT error: ".mysql_error());

eriksmoen

almost...

$result = mysql_query ("INSERT INTO news (id,header,from,IMG,body,source,result_id,WRE,AKL,TRG,PMR,NPL,WLG,OHA,CHC,DUD,NZK,NZW,NZI,AGE,EDI,BCC,BULLS,FLA,REP) Values('','$header','$from','$IMG','$body','$source','$result_id','$WRE','$AKL','$TRG','$PMR','$NPL','$WLG','$OHA','$CHC','$DUD','$NZK','$NZW','$NZI','$AGE','$EDI','$BCC','$BULLS','$FLA','$REP')") or die("INSERT error: ".mysql_error());

remember what i said about using the ticks (``)... located to the left of the '1' key.

NZ_Kiwi

Very very good!! well done... thanks so much