[Resolved] Upload problems

[furious5]

I've just written an upload script, however when I try to use the copy function my script cannot recognise the directory I am trying to copy to, even though it knows the file exists.

Can anyone help me out?

if(($_FILES['userfile']['type'] == "image/pjpeg") || ($_FILES['userfile']['type'] == "image/gif") && ($_FILES['userfile']['size'] < 122880)) {

// Check Directory Exists
if(!file_exists($logo_dir)){

	$oldUmask = umask(0); # set mask

	if(mkdir($dir, 0777)){ # create base directory
		mkdir($logo_dir, 0777); # create logo directory
	}

	umask($oldUmask); # unset mask

} 

if(file_exists($logo_dir)) {
	echo 'Perform Upload in second selection';

	if(copy($_FILES['userfile']['tmp_name'], $logo_dir)){
		echo 'File uploaded succesfully.';
	} else {
		echo 'File upload failed, please contact Jobclever support.';
	}

}

// Upload

} else {
	echo 'An error occured uploading the specified file. This could have occured because:<br/>';
	echo '- The file was an incorrect filetype, please supply the image in either GIF or JPEG formats.<br/>';
	echo '- The file was larger than 120KB.<br/>';
} 

[Shrike]

Where do you set the variable $logodir? Also what error does PHP give you? Set error_reporting(E_ALL) if you get no error.

[furious5]

$logo_dir is set above the script.

The error being thrown out is:

Warning: copy(/hsphere/local/home/test/media/10/logo/): failed to open stream: Is a directory

[Shrike]

So your using file_exists() on a directory?

[furious5]

Hmm yes, slight oversight on my part. However it was still entering the loop to perform the copy. Have now amended this to read:

if(is_dir($logo_dir)){

It seems to be the copy line where things are falling down

[Shrike]

if(copy($_FILES['userfile']['tmp_name'], $logo_dir . "mynewfilename.ext")){
...

[furious5]

Thanks Shrike, I realised as I was reading round you had to specify the full path and file name.

All working!