[Resolved] LOST MY SESSION_ variables

[xxbeejayxx]

Folks - below is some crappy code I wrote to test something out. It picks up a username & password then posts that to a form and sets a session_ variable with the username. that works fine. I then want to post some more data on the second form and confirm that on a third page. It loses the session_username on the third one with some unintelligible (by me) message from the browser about the session already started. what?

For you helpful people's info I've got globals 'on' and the SID stuff on. I know I should be using $_SESSION[] and all that but I want to get a crude version going before going all flash like that.

Anybody got any clues? I've seen lots of posts like this but can't glean what I want from all the clever answers.

Here's the code:

---

TEST1.php

---

<FORM ACTION="HandleNewUser.php" METHOD=POST>
Username <INPUT TYPE=TEXT NAME="Username" SIZE=15><BR>
Password <INPUT TYPE=PASSWORD NAME="Password" SIZE=15><BR>
<INPUT TYPE=SUBMIT NAME="SUBMIT" VALUE="Submit!">

---

HandleNewUser.php

---

<?php

session_register("Username");

// register the "username" variable and give output.
if (session_register("Username")) {
echo("User field set to $Username.");
} else {
echo("Could not set the session variable!");
}

if (($Username) && ($Password)) {
print ("Your request was successfully processed!<BR>\n".$Username);
} else {
print ("Please enter a Username and Password!\n");
}
//continues all same page

<FORM ACTION="Page3.php>" METHOD=POST>
Hair Colour <INPUT TYPE=TEXT NAME="HairColor" SIZE=15><BR>
Age <INPUT TYPE=PASSWORD NAME="Age" SIZE=15><BR>
<INPUT TYPE=SUBMIT NAME="SUBMIT" VALUE="Submit!">
</FORM>
</BODY>
</HTML>

---

Page3.php

---

<?php

if (($HairColor) && ($Age)) {
print ("Your request was successfully processed.. ".$Username);
} else {
print ("Please enter a hair color & age\n");
}

?>
</body>
</html>

---

Page3 is where I get no more values out of the session. Why? This is doing my nut in!. Thanks anyone who can help.

[bubblenut]

1. What's "flash" about using $_SESSION, it is infact easier than using session_register because you don't even have to call a function you just stick it in the array. Besides, even if you are using session_register you really, really, really should be using the super globals array for retrieving the data.

2. The error message may be unintelligible by you but I can garunte you it won't be by a lot of the people on this board. Post it!

3. This get's mentioned over and over again, please put php code in &#91;php]&#91;/php] tags, it makes the code so much easier to read.
   [/list=1]

   Make the changes and post back 🙂

[xxbeejayxx]

Thanks, with some minor revisions I've got the error messages stopped but it still wont read back the session variable on the third script!
(Please note all php tags in place)

test1.php

---

<? session_start();?>
<form action="handlenewuser.php" method=post>
username <input type=text name="username" size=15><br>
password <input type=password name="password" size=15><br>
<input type=submit name="submit" value="submit!">

---

handlenewuser.php

---

<?php
session_register("username");

// register the "username" variable and give output.
if (session_register("username")) {
echo("user field set to $username.");
} else {
echo("could not set the session variable!");
}

if (($username) && ($password)) {
print ("your request was successfully processed!<br>\n".$username);
} else {
print ("please enter a username and password!\n");
}

?>
//continues all same page

<form action="page3.php>" method=post>
hair colour <input type=text name="haircolor" size=15><br>
age <input type=password name="age" size=15><br>
<input type=submit name="submit" value="submit!">
</form>
</body>
</html>

---

page3.php

---

<?php

if (($haircolor) && ($age)) {
print ("your request was successfully processed.. ".$username);
} else {
print ("please enter a hair color & age\n");
}
?>

[bubblenut]

Getting the error messages stopped before the error is fixed is a bad thing. place this line at the top of your code and hope fully they'll come back and then you can post them up here.

error_reporting(E_ALL);

[edit]
No! All php tags are NOT in place. I'm not talking about your <?php ?> php tags or else I'd have said that. I'm talking about the &#91;php]&#91;/php] phpbb tags which highlight the code and make it readable, like I said above :rolleyes:
[/edit]

[xxbeejayxx]

I used that command to display errors, moved the session start() tags to a point before anything sent to browser via HTML and I got no further errors.
I'm not sure what you mean about the tags, I am rather busy on other things though.

test1.php

---

<? session_start();?>
<form action="handlenewuser.php" method=post>
username <input type=text name="username" size=15><br>
password <input type=password name="password" size=15><br>
<input type=submit name="submit" value="submit!">

---

handlenewuser.php

---

<?php
session_register("username");

// register the "username" variable and give output.
if (session_register("username")) {
echo("user field set to $username.");
} else {
echo("could not set the session variable!");
}

if (($username) && ($password)) {
print ("your request was successfully processed!<br>\n".$username);
} else {
print ("please enter a username and password!\n");
}

?>
//continues all same page

<form action="page3.php>" method=post>
hair colour <input type=text name="haircolor" size=15><br>
age <input type=password name="age" size=15><br>
<input type=submit name="submit" value="submit!">
</form>
</body>
</html>

[ppowell]

Folks, I'll do it for him because he's not understanding what you mean by the tags required by PHPBuilder.com to DISPLAY PHP (not the PHP tags themselves):

<? session_start();?>
<form action="handlenewuser.php" method=post>
username <input type=text name="username" size=15><br>
password <input type=password name="password" size=15><br>
<input type=submit name="submit" value="submit!">

handlenewuser.php

<?php

session_register("username");

// NO NO, do this instead:
// session_start();

// register the "username" variable and give output.
/*
if (session_register("username")) {
 echo("user field set to $username.");
} else {
 echo("could not set the session variable!");
}
*/

// Let's try that again:

if ($_SESSION['username']) {
 echo "User field set to $username.";
 $username = $_SESSION['username'];
} elseif (@!session_is_registered('username')) {
 echo 'Could not set the session variable!';
} else {
 echo 'User field not yet set';
}

if (($username) && ($password)) {
 print ("your request was successfully processed!<br>\n".$username);
} else {
 print ("please enter a username and password!\n");
}

?>
//continues all same page

<form action="page3.php>" method=post>
hair colour <input type=text name="haircolor" size=15><br>
age <input type=password name="age" size=15><br>
<input type=submit name="submit" value="submit!">
</form>
</body>
</html>

Phil

PS: I hope you're not putting $password in the session! That is a HUGE security gaping hole, VERY bad idea!!!

[bubblenut]

Originally posted by xxbeejayxx
I am rather busy on other things though.

I'll give you the benifit of the doubt and assume you didn't mean that comment as it sounded. Don't ever assume that your time is in any way more valuable than anyone elses here. We're all very busy but we take time out of busy lives, for free, to help people. I'm not just some bum sitting around my house in my underwear answering other peoples questions because I have nothing better to do (not between 9 and 6 Monday to Friday anyway) so please respect that.

Also, you haven't put in the code I metioned regarding [man]error_reporting()[/man] or else a couple of other notices/warnings would have come up. Please put it in and post up the complete output.

Another couple of bits of info which might be helpfull are.
Operating System which this is running on (if it's a Win32 machine you'll have to set your session path in php.ini)

[Weedpacket]

Originally posted by xxbeejayxx
but it still wont read back the session variable on the third script!

if (($haircolor) && ($age)) { 
print ("your request was successfully processed.. ".$username); 
} else { 
print ("please enter a hair color & age\n"); 
} 

[/B]

And have you used session_start() (and those old session_register() things!) on this third page?

[xxbeejayxx]

Thanks for help. Will try out those solutions.

All my code will be in proper quotes now.
I may be in a rush but I do realise about the globals vs HTTP_VARS argument. I just want to get it up and running, then make it more compliant to more current conventions. And NO I wouodn't stick a password, encrypted or otherwise into a cookie. I've got a an SQL database for that. It's safe as houses!
Apols if anybody was perplexed by my use of this site but I am no natural born programmer, just need a quick fix so to speak.
Though Bubblebut I don't remember asking what you wore when logging onto this site!:queasy: