formatting php

[ronjon]

im trying to make 4 columns with whatever i retrieve from the database... the inner while statement doesnt seem to move the index 'extract' index to the next value... i cant find a command that would move it to then next value... anybody have any ideas?

this is what i end up getting...
the first row is displays the first product four times then moves to the next product on the next row. i want to have extract move to the next product on the next column..

can anybody help me?

<?

				While ($row = mysql_fetch_array($result))
				{
					$counter =4;
					While (($row = mysql_fetch_array($result)) AND ($counter > 0))
					{

extract ($row);
$image1 = $Pphotoloc;
$desc1 = $Pdesc;

extract ($row);
$image2 = $Pphotoloc;
$desc2 = $Pdesc;

extract ($row);
$image3 = $Pphotoloc;
$desc3 = $Pdesc;

extract ($row);
$image4 = $Pphotoloc;
$desc4= $Pdesc;

					$counter--;
					}


					echo '
						<tr>
						<td align=left valign=top><a href="../product.php"><img src="../../images/products/newproducts/'.$image1.'.jpg" width="100" height="100" border="0"></a><br>'.$desc1.'</td>
						<td align=left valign=top><a href="../product.php"><img src="../../images/products/newproducts/'.$image2.'.jpg" width="100" height="100" border="0"></a><br>'.$desc2.'</td>
						<td align=left valign=top><a href="../product.php"><img src="../../images/products/newproducts/'.$image3.'.jpg" width="100" height="100" border="0"></a><br>'.$desc3.'</td>
						<td align=left valign=top><a href="../product.php"><img src="../../images/products/newproducts/'.$image4.'.jpg" width="100" height="100" border="0"></a><br>'.$desc4.'</td>
						</tr>'
						;
				}
				?>

[PallaviDalvi]

there is a logical prob with the way the loops are implemented. the inner loop...reads a record and extracts it 4 times...obviously the data will be printed 4 times.
u need to change the code to something like this

While ($row = mysql_fetch_array($result)) 
{ 
	echo "<tr>";
	$counter =4; 
	do
	{ 
		extract ($row); 
		$image1 = $Pphotoloc; 
	       $desc1 = $Pdesc;

	echo '<td align=left valign=top><a href="../product.php"><img src="../../images/products/newproducts/'.$image1.'.jpg" width="100" height="100" border="0"></a><br>'.$desc1.'</td>';

	$counter--; 

}While (($row = mysql_fetch_array($result)) AND ($counter > 0));
echo '</tr>'; 

}

this shud moreorless solve ur prob.

[ronjon]

  <?While ($row = mysql_fetch_array($result))  

          {  

            echo "<tr>"; 
            $counter =4;  

            do 
                 {
                       extract ($row);  

        	       $image1 = $Pphotoloc;  

           	       $desc1 = $Pdesc; 

                   echo '<td align=left valign=top><a href="../product.php"><img src="../../images/products/newproducts/'.$image1.'.jpg" width="100" height="100" border="0"></a><br>'.$desc1.'</td>'; 

	        $counter--;  

	        }While (($row = mysql_fetch_array($result)) AND ($counter > 0)); 
							  echo '</tr>';  
}                                       
?>

although... i have five products that its stored in the resultset... im positive.. i tested it.... but its only iterating throug the fourth one...its not starting the second row or its not getting to the last product... i dont get it...🙁

somebody help me out?

i have the page here (will edit this later and put url here... right now im at work and cant get to my computer to add the latest portion of the code.)

[rachel2004]

<?php 
$i=0; // begin your counter at 0 
do { 
  $i++; // increment the counter with each iteration

  /* show your stuff here or whatever.  I won't do it for 
     you since you aren't having problems with that part. */

  /* create an "if" check.  If we are at 4 (meaning 4 columns), 
     start new row, right? */
  if (($i%4) == 0)
  {
      echo "<br />"; // to begin the next row
  }
} while($row = mysql_fetch_array($result)); // keep this up while we have records
?>

HTH.

[ronjon]

<? //213
While ($row = mysql_fetch_array($result))  

{  

     echo '<tr>';
     $i=0; // begin your counter at 0 
     do{
          $i++; // increment the counter with each iteration
          echo '<td align=left valign=top><a href="../product.php"><img src="../../images/products/newproducts/'.$image1.'.jpg" width="100" height="100" border="0"></a><br>'.$desc1.'</td>';
          if (($i%4) == 0)
          {echo '</br>'; // to begin the next row}
          }while($row = mysql_fetch_array($result)); // keep this up while we have records
          echo '</tr>';
}
?>

I KEEP GETTING...

Parse error: parse error, unexpected ';', expecting T_WHILE in C:\Inetpub\wwwroot\products\catagorypages\results.php on line 229

and i just cant find what the problem is

[ronjon]

damnit i see it now.... its amazing how much easier it is to see errors with color coded code.

[rachel2004]

I don't believe you need to have two "while" statements. Just use the do/while as I have it for you. Here's another tip:

www.zend.com

Get their Zend Studio Lite (it's free).

[ronjon]

because i need to test for empty resultsets... i dont want the thing create a table unless theres something to put in it...

does that sound right to you?

or you think an if resultset !=0 is better?

[rachel2004]

ronjon, format the code to just use a while loop and eliminate the do/while part. Anything within the while loop will happen only for as long as the boolean expression is true (mysql_fetch_array($result) in this case).

If you want to be more defensive about it:

$num = mysql_num_rows($result);
if ($num > 0)
{
    while ($row_mysql_fetch_array($result))
    {
        // create table with results in the cells.
    }
}

HTH.