[Resolved] Help please

[Iquil]

hello all i've just recently gotten into PHP and i am stuck.

I'm using mysql_fetch_array() & mysql_fetch_row() but i get this error when i open the page

supplied argument is not a valid MySQL result resource in C:\Documents and Settings\Iquil\My Documents\CID\CDDB\common.php on line 35

i'm using the newest version of PHP.

any help would be great

Thanks

Iquil

oh and this is the code

function cdlist() {
	global $dbName, $table;

$dbLink = Connect($dbName);

if(!$dbName) error_msg(sql_error());

$cdQuery = "SELECT count(*) FROM ".$table;
$cdResult = mysql_query($cdQuery);

if(!$cdResult) sql_error();

$cdData = mysql_fetch_row($cdResult);

if(!$cdData[0]) $cdlist = "There are currently no albums listed in the database.";
else {
	$cdQuery = "SELECT Artist, Album FROM ".$table["iquil"];
	$cdResult = mysql_query($cdQuery);

	if(!$cdResult) error_msg(sql_error());

	$cdlist = "<table class=\"td\"><tr><td>Artist</td><td>Album</td></tr>";
	while($cdData = mysql_fetch_array($cdResult)) {
		$cdlist .= "<tr><td class=\"td\">$cdData[Artist]</td><td class=\"td\">$cdData[Album]</td></tr>";
	}
	$cdlist .= "</table>";
}

include "template.php";
}

[rachel2004]

I'm not sure if the code that you posted is your common.php and since I don't know what line 35 of common.php is, I'm going to guess that your link resource is incorrectly syntaxed.

Still, give this a try in the code that you did post. If it doesn't work, you'll need to post common.php and indicate where line 35 is in the code so someone can help you:

$cdResult = mysql_query($cdQuery, $dbLink)
    or die(mysql_error());

[Iquil]

oops :bemused:

sorry i only took out the function not the entire code

this is the entire code

<?php

$dbHost = "localhost";
$dbUname = "root";
$dbPass = "root";
$dbName = "cds";

$table["iquil"] = "iquil";

$MYSQL_ERRNO = "";
$MYSQL_ERROR = "";

function cdlist() {
	global $dbName, $table;

$dbLink = Connect($dbName);

if(!$dbName) error_msg(sql_error());

$cdQuery = "SELECT count(*) FROM ".$table;
$cdResult = mysql_query($cdQuery);

if(!$cdResult) sql_error();

$cdData = mysql_fetch_row($cdResult);

if(!$cdData[0]) $cdlist = "There are currently no albums listed in the database.";
else {
	$cdQuery = "SELECT Artist, Album FROM ".$table["iquil"];
	$cdResult = mysql_query($cdQuery);

	if(!$cdResult) error_msg(sql_error());

	$cdlist = "<table class=\"td\"><tr><td>Artist</td><td>Album</td></tr>";
	while($cdData = mysql_fetch_array($cdResult)) {
		$cdlist .= "<tr><td class=\"td\">$cdData[Artist]</td><td class=\"td\">$cdData[Album]</td></tr>";
	}
	$cdlist .= "</table>";
}

include "template.php";
}

function error_msg() {
}

function Connect() {
	global $dbHost, $dbUname, $dbPass, $dbName;
	global $MYSQL_ERRNO, $MYSQL_ERROR;

$link_id = mysql_connect($dbHost, $dbUname, $dbPass);
if(!$link_id) {
	$MYSQL_ERRNO = 0;
	$MYSQL_ERROR = "The connection has failed";
	return 0;
}
elseif(empty($dbName) && !mysql_select_db($dbName)) {
	$MYSQL_ERRNO = mysql_errno;
	$MYSQL_ERROR = mysql_error;
	return 0;
}
else return $link_id;
}

function sql_error() {
	global $MYSQL_ERRNO, $MYSQL_ERROR;

if(empty($MYSQL_error)) {
	$MYSQL_ERRNO = mysql_errno;
	$MYSQL_ERROR = mysql_error;
}
return "<br>$MYSQL_ERRNO<br>$MYSQL_ERROR<br><br>";
}

cdlist();

?>

i put in the code you gave me and i now get this

No Database Selected

[rachel2004]

And line 35 is... ?

[Iquil]

again sorry..... :bemused:

line 35 is

while($cdData = mysql_fetch_array($cdResult)) {

also line 26 causes the same error

$cdData = mysql_fetch_row($cdResult);

but with row instead of array

[rachel2004]

Try this:

// $dbLink = Connect($dbName);
$dbLink = Connect();

$db_selected = mysql_select_db($dbName, $dbLink);
if (!$db_selected) {
   die (mysql_error());

if(!$dbName) error_msg(sql_error()); 

[Iquil]

now i get this error

Parse error: parse error, unexpected $end in C:\Documents and Settings\Iquil\My Documents\CID\CDDB\common.php on line 86

line 86:

?>

[Iquil]

Yay it works 🙂 thank you very much rachel2004.

that last error was because i left out this "}"

Thank you 😃

[rachel2004]

You're welcome...🙂

[Iquil]

it is strange tho because i got it to work before :bemused: