noob trouble understanding how to make variables accessible scriptwide?

etrooper

Hi all,

OK, I am trying to get the variable $currentid to be accessible throughout the script... How is this done?

The function changeid does not seem to help.

I am getting an error every time when I try and use id="$currentid" in a function that did not define it to start with...

So the idea is to have a choice of the database listings at first, then be able to assign a permanent value to $id so that all fomrs etc will use the id selected at first.

Sorry if this is confusing... I am confusing myself just trying to ask the question.

Thanks

Lucas

<?php
include "timing1.php";

$db = mysql_connect("localhost", "user", "blahblah");
mysql_select_db("mydbname",$db);

function changeid()
{
global $currentid;
$currentid = $id;
echo "this is the current: <br>", $currentid, "<br>";
return $currentid;
}

if ($submit) {

$add1 = '<P class=normal>';
$add2 = '</P><br>';
if ($radio1) {
$add1 = '<P class=title2>';
}
if ($radio2) {
$add1 = '<div class="center"><table class=main cellpadding="5" cellspacing="0"><tr><td>';
$add2 = '</td></tr></table></div><br>';
}

$entercontent = nl2br("$entercontent");

$entercontentb = $add1.$entercontent.$add2;

$result = mysql_query("SELECT * FROM add1 WHERE id='$currentid'",$db);
$myrow = mysql_fetch_array($result);

$newvar = $myrow['content'].$entercontentb;

$sql = "UPDATE add1 SET content = '$newvar', date = NOW() WHERE id = '$currentid'";
$result = mysql_query($sql);
if (!$result) {
echo "<P class=header>Sorry there was an Error, Please try again</P>";
} else {
// echo "<P class=header>thankyou information updated</P>";
}
}

if ($link) {

changeid();

$result = mysql_query("SELECT * FROM add1 WHERE id=$currentid");
echo $result;
echo "that was the result";
while ($myrow = mysql_fetch_array($result)) {
printf("%s", $myrow['content']);
}
if (!$myrow['content']) {
echo 'There is no output to display, please start creating the page below';
}

<form action="<?php echo $PHP_SELF ?>" enctype="multipart/form-data" method="POST">

<tr><td><input type="Submit" name="submit" value="Enter information"></td>
<td><input type="radio" name="radio1">Colour text Red,
<input type="radio" name="radio2">Command text box     
</td></tr>
<td><a href=<?php echo $PHP_SELF?>?id=<?php echo $currentid ?>&edita=yes>Edit</a> </td></tr>
</table>

</form>

<?php

}

if (!$currentid) {
$sql = "SELECT * FROM add1";

$result = mysql_query($sql);

while ($myrow = mysql_fetch_array($result)) {
printf("<a href=%s?id=%s&link=yes>%s</a><br>", $PHP_SELF, $myrow['id'], $myrow['title']);
} }

$result = mysql_query("SELECT * FROM add1",$db);
$myrow = mysql_fetch_array($result);

printf('<P class=footnoteb>This page was last updated on the %s</P>', $myrow['date']);

include "timing2.php";

devinemke

your changeid function returns the $currentid but when you call it you are not capturing the output to anything. you need to do:

$currentid = changeid();

etrooper

Thanks for your reply, I tried it, but it did not seem to solve the problem. Maybe I am not assigning the value correctly in the first place.

I keep getting the folloiwng error:

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /var/www/linuxlogic.org/test/newaddtest2.php on line 76

I think its this line that is actually causing the problem:

$result = mysql_query("SELECT * FROM add1 WHERE id=$currentid");

Here is the whole code:

<html>
<head>
<title></title>
<link href="llstylesheet.css" rel="stylesheet">
</head>
<body>

<?php
include "timing1.php";

$db = mysql_connect("localhost", "xxx", "xxx");
mysql_select_db("xxxxxxx",$db);

function changeid() 
{
global $currentid;
$currentid = $id;
echo "this is the current: <br>", $currentid, "<br>";
return $currentid;
}



//if ($currentid) {
//	echo 'ok you have a variable';
//	echo $currentid;
//} else {
//	echo 'there is no variable, so far so good';
//}

if ($submit) {


$add1 = '<P class=normal>';
$add2 = '</P><br>';
if ($radio1) {
$add1 = '<P class=title2>';
}
if ($radio2) {
$add1 = '<div class="center"><table class=main cellpadding="5" cellspacing="0"><tr><td>';
$add2 = '</td></tr></table></div><br>';
}
// diag echo "<br>";
$entercontent = nl2br("$entercontent");
// diag only echo nl2br("$entercontent");
$entercontentb = $add1.$entercontent.$add2;
// diag echo $entercontentb;
$result = mysql_query("SELECT * FROM add1 WHERE id='$currentid'",$db);
$myrow = mysql_fetch_array($result);
// diag echo "this is the myrow variable <br>",  $myrow['content'];
// diag echo "<br>";
// diag echo "this is the form box input variable $entercontent <br>";
$newvar = $myrow['content'].$entercontentb;
// diag echo $newvar;
$sql = "UPDATE `add1` SET `content` = '$newvar', date = NOW() WHERE `id` = '$currentid'";   

$result = mysql_query($sql);
if (!$result) {
echo "<P class=header>Sorry there was an Error, Please try again</P>"; 
} else {
// echo "<P class=header>thankyou information updated</P>";
}
}





if ($link) {

$currentid = changeid();


$result = mysql_query("SELECT * FROM add1 WHERE id=$currentid");
echo $result;
echo "that was the result";
while ($myrow = mysql_fetch_array($result)) {
printf("%s", $myrow['content']);
}
if (!$myrow['content']) {
	echo 'There is no output to display, please start creating the page below';
}

?>

<form action="<?php echo $PHP_SELF ?>" enctype="multipart/form-data" method="POST">

<table class=small border="1">

<tr><td>Text to add</td><td><textarea type="text" name="entercontent" rows="2" cols="80"></textarea></td></tr>

<tr><td><input type="Submit" name="submit" value="Enter information"></td>
<td><input type="radio" name="radio1">Colour text Red, 
<input type="radio" name="radio2">Command text box   &nbsp;&nbsp;&nbsp;&nbsp;
</td></tr>
<td><a href=<?php echo $PHP_SELF?>?id=<?php echo $currentid ?>&edita=yes>Edit</a> </td></tr>
</table>

</form>

<?php

}



if (!$currentid) {
$sql = "SELECT * FROM add1";

$result = mysql_query($sql);	

while ($myrow = mysql_fetch_array($result)) {
printf("<a href=%s?id=%s&link=yes>%s</a><br>", $PHP_SELF, $myrow['id'], $myrow['title']);
} }









$result = mysql_query("SELECT * FROM add1",$db);
$myrow = mysql_fetch_array($result);

printf('<P class=footnoteb>This page was last updated on the %s</P>', $myrow['date']);

include "timing2.php";


?>

</body>
</html>

devinemke

your query is failing because you are using $currentid before it is set:

$result = mysql_query("SELECT * FROM add1 WHERE id='$currentid'",$db);

what is $currentid? it has not been set yet. (unless it is being set in include timing1.php).

etrooper

Thanks for the reply.

$currentid is the id value which I want to use wih the scripts instead of the normal $id. It is not defined in timing1.php

The goal of the page is to first present database listings as links with:

if (!$currentid) {
$sql = "SELECT * FROM add1";

$result = mysql_query($sql);    

while ($myrow = mysql_fetch_array($result)) {
printf("<a href=%s?id=%s&link=yes>%s</a><br>", $PHP_SELF, $myrow['id'], $myrow['title']);
} }

notice I am using id=$myrow['id'].

All I want to do is, once id has been selected (by the above link creation) set $id to $currentid and do not change it. The purpose being so I can then print output from one section of one row (with printf ...$myrow['current'] WHERE id=$currentid) then edit it, process it WHERE id='$currentid' and then redisplay the output with the new changes.

Does that make any sense?

I am beginning to wonder if sessions will do this?

Thanks