[Resolved] Spot the error - mysql update

[move3rd]

Getting an error but I carnt find the problem!

$query = "UPDATE `news` SET `title`='$title' `newstext`='$text' ".
"WHERE `artist`='"
.$_SESSION['member']."' AND `id`=".$_POST['news_id'].""; 
$result = mysql_query($query); 
// Report Db errors
if (!$result) {
   $content .= "Could not successfully run query ($sql) from DB: "
 . mysql_error() . "<br>";
              }

[dcav]

I didn't try to run your code but perhaps you could try this:

$query = 
"UPDATE news FROM tablename
SET title='$title', newstext='$text'
WHERE artist='" .$_SESSION['member']."' AND id='".$_POST['news_id']."'";  

$result = mysql_query($query);  

// Report Db errors 
if (!$result) { 
   $content .= "Could not successfully run query ($sql) from DB: " 
 . mysql_error() . "<br>"; 
}

You are missing a comma after title and
table name and
a single quote after ID.
Good luck

[move3rd]

Thanks dcav,

It's still gives an error just a differant one.

Heres what I have now:

$query = "UPDATE `news` SET `title`='$title', `newstext`='$text' ".
"WHERE `artist`='".$_SESSION['member']."' AND `id`='"
.$_POST['news_id']."' LIMIT 1"; 
$result = mysql_query($query); 
// Report Db errors
if (!$result) {
   $content .= "Could not successfully run query ($sql) from DB: " 
. mysql_error() . "<br>";
              }

[dcav]

what is the stated error message?

You did not give a table name, sql does not know which table you want to update.

[move3rd]

The table is news.

This is what I have now. It doesnt give an error but it doesnt update either.

$query = "UPDATE `news` SET `title`='$title', `newstext`='$text' ".
"WHERE `artist`='".$_SESSION['member']."' AND `id`='".$_POST['news_id'].
"' LIMIT 1"; 
$result = mysql_query($query); 
// Report Db errors
if (!$result) {
   $content .= "Could not successfully run query ($sql) from DB: "
 . mysql_error() . "<br>";
              }

[dcav]

Sorry for the update thing, forgot the syntax myself :p

Why did you assign a limit in your SQL statement? If you are using an ID, I assume you only have 1 record associated with it.

Try this:

$sMember = $_SESSION['member'];
$pID = $_POST['news_id'];

$query = "UPDATE news SET title='$title', newstext='$text'
WHERE artist='$sMember' AND id='$pID'";

$result = mysql_query($query);  

Much cleaner and should be correct syntax.
If it still does not update, perhaps you should try to echo out $sMember, $pID and $query and see if something is wrong with them.

Also, since you posted on a newbie forum, I might as well ask you if you have established a connection first.Consult this page if you haven't done so:
http://www.php.net/manual/en/ref.mysql.php

Good luck

[move3rd]

It's working correctly now. 😃

Thanks for your help dcav🙂