detecting visitor's browser - comparing code

[helz]

Here is the code in PHPNuke's counter.php file, it detects the visitors browser:

if((ereg("Nav", $_SERVER["HTTP_USER_AGENT"])) || (ereg("Gold", $_SERVER["HTTP_USER_AGENT"])) || (ereg("X11", $_SERVER["HTTP_USER_AGENT"])) || (ereg("Mozilla", $_SERVER["HTTP_USER_AGENT"])) || (ereg("Netscape", $_SERVER["HTTP_USER_AGENT"])) AND (!ereg("MSIE", $_SERVER["HTTP_USER_AGENT"]) AND (!ereg("Konqueror", $_SERVER["HTTP_USER_AGENT"])))) $browser = "Netscape";
elseif(ereg("MSIE", $_SERVER["HTTP_USER_AGENT"])) $browser = "MSIE";
elseif(ereg("Lynx", $_SERVER["HTTP_USER_AGENT"])) $browser = "Lynx";
elseif(ereg("Opera", $_SERVER["HTTP_USER_AGENT"])) $browser = "Opera";
elseif(ereg("WebTV", $_SERVER["HTTP_USER_AGENT"])) $browser = "WebTV";
elseif(ereg("Konqueror", $_SERVER["HTTP_USER_AGENT"])) $browser = "Konqueror";
elseif((eregi("bot", $_SERVER["HTTP_USER_AGENT"])) || (ereg("Google", $_SERVER["HTTP_USER_AGENT"])) || (ereg("Slurp", $_SERVER["HTTP_USER_AGENT"])) || (ereg("Scooter", $_SERVER["HTTP_USER_AGENT"])) || (eregi("Spider", $_SERVER["HTTP_USER_AGENT"])) || (eregi("Infoseek", $_SERVER["HTTP_USER_AGENT"]))) $browser = "Bot";
else $browser = "Other";

i decided to make my own code, since ive always preferred to code it all myself so i can fully understand it.
are there any things that can be done to the code below to see if it can be made faster or more efficient?

<?
$browsers = array(// start array of different browsers
				"bot" => array(
					"bot",//start bot array
					"Google",
					"Slurp",
					"Scooter",
					"Spider",
					"Infoseek"),
				"browser" => array(
					"MSIE",//start browser array: IE and Konqueror first!
					"Konqueror",
					"Netscape",
					"Lynx",
					"Opera",
					"WebTV",
					"Mozilla")
			);
foreach($browsers as $name2 => $value2) {
	foreach($value2 as $name => $value) {
		if((strpos($_SERVER['HTTP_USER_AGENT'],$value)) !== FALSE) {//check for browser ID within http_user_agent, get rid of False ones
			$currentbrowser = $value;
			break;//stop loop to save time and get rid of fakers
		} else {//current browser is not in the list, so set it to Other
			$currentbrowser = "Other";
		}
	}
}
echo '<br>'.$currentbrowser;
?>

thanks in advance!

[eoghain]

Well I'd change it this way to gain just a little bit more speed:

$currentbrowser = "Other";
$found = false;
foreach($browsers as $name2 => $value2) { 
    foreach($value2 as $name => $value) { 
        if((strpos($_SERVER['HTTP_USER_AGENT'],$value)) !== FALSE) {//check for browser ID within http_user_agent, get rid of False ones 
            $currentbrowser = $value; 
            $found = true;
            break;//stop loop to save time and get rid of fakers 
        } 
    } 
    if ($found) {
        break;
    }
} 
echo '<br>'.$currentbrowser;

Not much is changed, but by setting the $currentbrowser to "Other" in the beginning we don't have to set it for every false hit in the inner loop. Also by setting the $found value we can break out of both loops when we've got a match. As your code was originally built you'd get an "Other" answer whenever a "bot" came to your site.

[helz]

Thanks for that!
I think I should start reading through my code after coding it, missed the "bot" bug 🙂
also just found out that google's bot is:
Googlebot
so ive added that to the list.

I think I prefer it the way I did it aswell, seems alot easier to add new items into the array.

Thanks again!