Rank system count in %

[Chrysanthus]

Hi everybody.

It has been a wille but in back..

I made this rank skript for myc community and i wonder if some one have some better idé of how i can make this code better..

sow here it is.

<?
include ("../management/connectdb/mysqlcondblg.php");
$result = mysql_query("SELECT * FROM ranglog WHERE usernameID='$_SESSION[regid]'");
$row = mysql_fetch_array($result);

##The requerments for the ranks!

$gkrt = 150;       ## Guestbook post master. 
$mlrt = 30;         ## Mail master.
$fmrt = 75;         ## Forum post master.
$lkrt = 7;            ## Logbook master.
$lnrt = 7;            ## Login master.

$setl=$gkrt+$mlrt+$fmrt+$lkrt;   ## Site master.

$gktl = $row['gkpost_total'];    ## Value of total posts this month on guestbookpoststhat has been gained to the requerments..
$mltl = $row['mlpost_total'];   ## Value of total sent messages this month that has been gained to the requerments.
$fmtl = $row['fmpost_total'];    ## Value of total posts this month on forumposts that has been gained to the requerments..
$lktl = $row['lkpost_total'];  ## Value of total logbookposts this month that has been gained to the requerments.
$lntl = $row['ln_total'];      ## Value of total logins this month on that has been gained to the requerments.


$gk_result = $gktl / $gkrt * 100;   ## count to 100%
$ml_result = $mltl / $mlrt * 100;
$fm_result = $fmtl / $fmrt * 100;
$lk_result = $lktl / $lkrt * 100;
$ln_result = $lntl / $lnrt * 100;

$lntl / $lnrt;
## Change color when rank is gained!

if ($gktl >= $gkrt){                  

$gkpost ='Guestbook mastering.';
$gkok = "<font color='green'>";
$gkoks = "</font>";
}
if ($mltl >= $mlrt){                  

$mlpost ='Mail mastering.';
$mmok = "<font color='green'>";
$mmoks= "</font>";
}
if ($fmtl >= $fmrt) {                  

$fmpost ='Forum mastering.';
$fmok = "<font color='green'>";
$fmoks= "</font>";
}
if ($lktl >= $lkrt) {                  

$lbpost ='Logbook mastering.';
$lkok= "<font color='green'>";
$lkoks= "</font>";
}
if ($lktl >= $lnrt) {                  

$lnpost ='Login mastering.';
$lnok= "<font color='green'>";
$lnoks= "</font>";
}

## round up

if(strlen($gk_result <= 5 || strlen($gk_result >= 3))){
$flgk_result = round( $gktl / $gkrt * 100, 2);
}else{
$flgk_result =  $gktl / $gkrt * 100;
}

if(strlen($ml_result <= 5) || strlen($ml_result >= 3)){
$flml_result = round($mltl / $mlrt * 100, 2);
}else{
$flml_result = $mltl / $mlrt * 100;
}

if(strlen($fm_result <= 5) || strlen($fm_result >= 3)){
$flfm_result = round($fmtl / $fmrt * 100, 2);
}else{
$flfm_result = $fmtl / $fmrt * 100;
}

if(strlen($lk_result <= 5) || strlen($lk_result >= 3)){
$fllk_result = round($lktl / $lkrt * 100, 2);
}else{
$fllk_result = $lktl / $lkrt * 100;
}

if(strlen($ln_result <= 5) || strlen($ln_result >= 3)){
$flin_result = round($lntl / $lnrt  * 100, 2);
}else{
$flin_result = $lntl / $lnrt  * 100;
}

$co = '<font style="color: red;"><b>';
$co1 = '<font></b>';
?>
<table border=0 cellpadding=0 cellspacing=0 align=left>
<tr>
<td align=left  height=25 width="80"><b>Rank info:</b></td>
</tr>
<tr>
<td align=left  height=25 width="150">The rank log resets every last day in the end of month at 00:00</td>
</tr>
<td width=100% colspan="3"><hr noshade></td>
</tr>
<tr> 
<td align=left class="bold" height=25 width="30">Username:<td width="130" class="bold"><?php echo $nrow['username'];?></td>
</tr>
<tr>
<td height=25 width="100" align=left class="bold">Rank's:</td><td width="80" class="bold">Have Gained:</td><td width="180" class="bold">Needed:</td>
</td>
</tr>
<td width=100% colspan="3"><hr noshade></td>
</tr>

<td height=30 align=left class="bold"><? echo $gkok ?>Guestbook<br>mastering.<? echo $gkoks ?></td><td width="180" class="bold"><? echo $co.$flgk_result."%".$co1 ?></td><td width="15" class="bold">100%</td>
</tr>
<td height=30 align=left class="bold"><? echo $mmok ?>Mail<br>mastering.<? echo $mmoks ?></td><td width="180" class="bold"><? echo $co.$flml_result."%".$co1 ?></td><td width="15" class="bold">100%</td>
</tr>
<td height=30 align=left class="bold"><? echo $fmok ?>Forum<br>mastering.<? echo $fmoks ?></td><td width="180" class="bold"><? echo $co.$flfm_result."%".$co1 ?></td><td width="15" class="bold">100%</td>
</tr>
<td height=30 align=left class="bold"><? echo $lkok ?>Logbook<br>mastering.<? echo $lkoks ?></td><td width="180" class="bold"><? echo $co.$fllk_result."%".$co1 ?></td><td width="15" class="bold">100%</td>
</tr>
<td height=30 align=left class="bold"><? echo $lnok ?>Login<br>mastering.<? echo $lnoks ?></td><td width="180" class="bold"><? echo $co.$flin_result."%".$co1 ?></td><td width="15" class="bold">100%</td>
</tr>
<tr>
<td width=100% colspan="3"><hr noshade></td>
</tr>
<tr>
</table>

[drawmack]

could you post the structure of the relevent table from you database. I have an idea for make this code much briefer but I need the db structure to make the changes and test them.

[Chrysanthus]

It look like this if it that you mean?

Row Type Attribut Null Standard Extras

usernameID int(3)--------- Nej ----- 0

gkpost_total int(3)--------- Nej ----- 0

fmpost_total int(3)--------- Nej ----- 0

mlpost_total int(3)--------- Nej ----- 0

lkpost_total int(3)--------- Nej ----- 0

ln_total int(3)--------- Nej ----- 0

[drawmack]

here's what I came up with by making it array based instead of scalar based:

<?php
include ("../management/connectdb/mysqlcondblg.php");
//changed to 1 because my test script doesn't have the session id
$sql    = "SELECT gkpost_total,mlpost_total,fmpost_total,lkpost_total";
$sql   .= ",ln_total FROM ranglog WHERE usernameID=1";
$result = mysql_query($sql); 
$row    = mysql_fetch_assoc($result); 

//The requerments for the ranks!
$required = array (
    'gkpost_total'=>150,
    'mlpost_total'=>75,
    'fmpost_total'=>30,
    'lkpost_total'=>7,
    'ln_total'=>7
);
//display names of the fields 
$names    = array (
    'gkpost_total' => 'Guestbook',
    'mlpost_total'=>'Mail',
    'fmpost_total'=>'Forum',
    'lkpost_total'=>'Logbook',
    'ln_total'=>'Login'
); 

$result = array(); //holds the results column
$posts  = array(); //holds the posts column
$colors = array(); //holds the font tags
$ends   = array(); //holds the end font tags

foreach(array_keys($row) as $key) {
    $result[$key] = ($row[$key]/$required[$key]) * 100;
    if($row[$key] >= $required[$key]) {
        $posts[$key]  = $names[$key] . ' mastering.';
        $colors[$key] = '<font color="green">';
        $ends[$key]   = '</font>';
    } else {
        $posts[$key]  = $names[$key];
        $colors[$key] = '';
        $ends[$key]   = '';
    } //end if

if(strlen($result[$key]) <= 5 || strlen($result[$key]) >= 3)
    $result[$key] = round($result[$key],2);
} //end foreach
$reset_date = time() + ((date('t') - date('j')) * 86400);
if(date('t') == date('j')) 
    $reset_date += 86400; 

$co = '<font style="color: red;"><b>'; 
$co1 = '<font></b>'; 
?> 
<table width="325" border="0" cellpadding="0" cellspacing="0" align="left"> 
  <tr> 
    <td align="left"  height="25" width="80" colspan="3"><b>Rank info:</b></td> 
  </tr> 
  <tr> 
    <td align="left"  height="25" width="150" colspan="3">
        The rank log will be reset 
        <?php echo date('M d, Y',$reset_date) . ' 12:00 am'?>
    </td> 
  </tr> 
    <td width="100%" colspan="3"><hr noshade></td> 
  </tr>
<!-- took this out because I don't have the $nrow variable set up 
  <tr> 
    <td align=left class="bold" height=25 width="30">Username: </td>
    <td width="130" class="bold"><?php /*echo $nrow['username']*/;?></td> 
  </tr> 
-->
  <tr> 
    <td height="25" width="150" align=left class="bold">Rank's:</td>
    <td width="100" class="bold">Have Gained:</td>
    <td width="75" class="bold">Needed:</td> 
  </tr> 
    <td width="100%" colspan="3"><hr noshade></td> 
  </tr> 
<?php foreach(array_keys($row) as $key) { ?>
  <tr>
    <td height="30" align="left" class="bold">
        <? echo $colors[$key] . $posts[$key] . $ends[$key] ?>
    </td>
    <td class="bold"><? echo $co . $result[$key] . "%" . $co1 ?></td>
    <td class="bold">100%</td> 
  </tr>
<?php }?>
  <tr> 
    <td width="100%" colspan="3"><hr noshade></td> 
  </tr> 
</table>

[Chrysanthus]

Wow nice, looks realy diffrent from my script but it look's like the % is counting wrong.

Are im wrong?

I feal lost on your script! it sow good, i't will take me a day or 2 to know how i't works but is good and clean i see and that should you take credit for 😃..

<?

include ("../management/connectdb/mysqlcondblg.php"); 
//changed to 1 because my test script doesn't have the session id 
$sql    = "SELECT gkpost_total,mlpost_total,fmpost_total,lkpost_total FROM ranglog WHERE usernameID='$_SESSION[regid]'"; 
$result = mysql_query($sql);  

$row    = mysql_fetch_assoc($result);  

//The requerments for the ranks! 
$required = array ( 
    'gkpost_total'=>150, 
    'mlpost_total'=>75, 
    'fmpost_total'=>30, 
    'lkpost_total'=>7, 
    'ln_total'=>7 
); 
//display names of the fields 
$names    = array ( 
    'gkpost_total' => 'Guestbook', 
    'mlpost_total'=>'Mail', 
    'fmpost_total'=>'Forum', 
    'lkpost_total'=>'Logbook', 
    'ln_total'=>'Login' 
);  

$result = array(); //holds the results column 
$posts  = array(); //holds the posts column 
$colors = array(); //holds the font tags 
$ends   = array(); //holds the end font tags 

foreach(array_keys($row) as $key) { 
    $result[$key] = ($row[$key]/$required[$key]) * 100; 
    if($row[$key] >= $required[$key]) { 
        $posts[$key]  = $names[$key] . ' mastering.'; 
        $colors[$key] = '<font color="green">'; 
        $ends[$key]   = '</font>'; 
    } else { 
        $posts[$key]  = $names[$key]; 
        $colors[$key] = ''; 
        $ends[$key]   = ''; 
    } //end if 

if(strlen($result[$key]) <= 5 || strlen($result[$key]) >= 3) 
    $result[$key] = round($result[$key],2); 
} //end foreach 
$reset_date = time() + ((date('t') - date('j')) * 86400); 
if(date('t') == date('j'))  

    $reset_date += 86400;  

$co = '<font style="color: red;"><b>';  

$co1 = '<font></b>';  

?>  

<table width="325" border="0" cellpadding="0" cellspacing="0" align="left"> 
  <tr> 
    <td align="left"  height="25" width="80" colspan="3"><b>Rank info:</b></td> 
  </tr> 
  <tr> 
    <td align="left"  height="25" width="150" colspan="3"> 
        The rank log will be reset 
        <?php echo date('M d, Y',$reset_date) . ' 12:00 am'?> 
    </td> 
  </tr> 
    <td width="100%" colspan="3"><hr noshade></td> 
  </tr> 
<!-- took this out because I don't have the $nrow variable set up 
  <tr> 
    <td align=left class="bold" height=25 width="30">Username: </td> 
    <td width="130" class="bold"><?php /*echo $nrow['username']*/;?></td> 
  </tr> 
--> 
  <tr> 
    <td height="25" width="150" align=left class="bold">Rank's:</td> 
    <td width="100" class="bold">Have Gained:</td> 
    <td width="75" class="bold">Needed:</td> 
  </tr> 
    <td width="100%" colspan="3"><hr noshade></td> 
  </tr> 
<?php foreach(array_keys($row) as $key) { ?> 
  <tr> 
    <td height="30" align="left" class="bold"> 
        <? echo $colors[$key] . $posts[$key] . $ends[$key] ?> 
    </td> 
    <td class="bold"><? echo $co . $result[$key] . "%" . $co1 ?></td> 
    <td class="bold">100%</td> 
  </tr> 
<?php }?> 
  <tr> 
    <td width="100%" colspan="3"><hr noshade></td> 
  </tr> 
</table> 

[drawmack]

Originally posted by Chrysanthus
Wow nice, looks realy diffrent from my script but it look's like the % is counting wrong.

Are im wrong?

that could be I just used the same calculation you were using but make it work on the arrays instead of the scalars. In my test db entry I just used the numbers to make the percents come out to 100, I'll try some different numbers now and let you know the results:

Just tried it with four different sets of numbers and it appears to be working okay to me.

[Chrysanthus]

Okey becous i seem to get diffrent results from my old code thats why i wonder...

i look in to i't

[Chrysanthus]

No it works great now... thanks for the help..