[Resolved] editing problems

[lee_umney]

I have redone a website, using PHP/MySQL to make it easier to update.
It works fine on my test server on my laptop but once its on the actual server it doesn't work.
The part that is failing is the edit page, there is on main problem.

There are upto 12 photos per page and they upload fine, when I edit the page the ones currently on the page disappear from the db. Script is below (script2)

Script1, this extracts data from the db to be displayed on a html form.
<?
SESSION_START();

include("header.php");
$reg=$_GET['view'];
$photodir = "/home/smegsmeg/public_html/photos/";
$photobase = "http://mhautobody.co.uk/photos/";

//echo"$reg";
$db=mysql_connect("localhost", "mhautobody", "") or die(mysql_error());
mysql_select_db("mhautobody");

$query = "select * from cars where reg = '$reg'";
$result = mysql_query($query);

// extract data
$car = mysql_fetch_assoc($result);
$reg		= $car['reg'];
$make		= $car['make'];
$model		= $car['model'];
$section	= $car['section'];
$description= $car['description'];
$photo1		= $car['photo1'];
$photo2     = $car['photo2'];
$caption1   = $car['caption1'];
$photo3     = $car['photo3'];
$photo4     = $car['photo4'];
$caption2   = $car['caption2'];
$photo5     = $car['photo5'];
$photo6	    = $car['photo6'];
$caption3   = $car['caption3'];
$photo7		= $car['photo7'];
$photo8		= $car['photo8'];
$caption4   = $car['caption4'];
$photo9		= $car['photo9'];
$photo10    = $car['photo10'];
$caption5   = $car['caption5'];
$photo11    = $car['photo11'];
$photo12	= $car['photo12'];
$caption6	= $car['caption6'];

session_register('photo1', 'photo2','photo3','photo4','photo5','photo6','photo7','photo8','photo9','photo10','photo11','photo12');

$reg = urldecode($reg);

//echo "$make $section, $photo1, $photo2, $photo3, $photo4";
include("file:///A|/mhnew/admin/admin_edit.html");
include("file:///A|/mhnew/admin/footer.php");
?>

Script2 this is the update script.
<?
SESSION_START();

include("paths.php");
//include("connect_db.php");

$reg = $POST['reg'];
$make = $POST['make'];
$model = $POST['model'];
$section = $POST['section'];
$description= $POST['description'];
$caption1 = $POST['caption1'];
$caption2 = $POST['caption2'];
$caption3 = $POST['caption3'];
$caption4 = $POST['caption4'];
$caption5 = $POST['caption5'];
$caption6 = $_POST['caption6'];

$photo1 = $_POST['photo1'];

echo "$reg, $make, $model, $section, p1=$photo1, p2=$photo2, $caption_1, $photo3, p4=$photo4, $caption2, $photo5.";

//del pictures if selected
if($_POST['photo1_del'] == 1)
{
unlink($photodir . $photo1);
$photo1 = '';
}

if($_POST['photo2_del'] == 1)
{
	unlink($photodir . $photo2);
	$photo2 = '';
}

if($_POST['photo3_del'] == 1)
{
	unlink($photodir . $photo3);
	$photo3 = '';
}

if($_POST['photo4_del'] == 1)
{
	unlink($photodir . $photo4);
	$photo4 = '';
}
if($_POST['photo5_del'] == 1)
{
	unlink($photodir . $photo5);
	$photo5 = '';
}
if($_POST['photo6_del'] == 1)
{
	unlink($photodir . $photo6);
	$photo6 = '';
}
if($_POST['photo7_del'] == 1)
{
	unlink($photodir . $photo7);
	$photo7 = '';
}

F95
if($POST['photo8_del'] == 1)
{
unlink($photodir . $photo8);
$photo8 = '';
}
if($POST['photo9_del'] == 1)
{
unlink($photodir . $photo9);
$photo9 = '';
}
if($POST['photo10'] == 1)
{
unlink($photodir . $photo10);
$photo10 = '';
}
if($POST['photo11_del'] == 1)
{
unlink($photodir . $photo11);
$photo11 = '';
}
if($_POST['photo12_del'] == 1)
{
unlink($photodir . $photo12);
$photo12 = '';
}
// process photo uploads
if($HTTP_POST_FILES['photo_1']['size'] > 1)
{
copy($HTTP_POST_FILES['photo_1']['tmp_name'], $photodir.$HTTP_POST_FILES['photo_1']['name']);
$photo1 = $HTTP_POST_FILES['photo_1']['name'];
}

if($HTTP_POST_FILES['photo_2']['size'] > 1)
{
	copy($HTTP_POST_FILES['photo_2']['tmp_name'], $photodir.$HTTP_POST_FILES['photo_2']['name']);
	$photo2 = $HTTP_POST_FILES['photo_2']['name'];		
}
if($HTTP_POST_FILES['photo_3']['size'] > 1)
{
	copy($HTTP_POST_FILES['photo_3']['tmp_name'], $photodir.$HTTP_POST_FILES['photo_3']['name']);
	$photo3 = $HTTP_POST_FILES['photo_3']['name'];		
}
if($HTTP_POST_FILES['photo_4']['size'] > 1)
{
	copy($HTTP_POST_FILES['photo_4']['tmp_name'], $photodir.$HTTP_POST_FILES['photo_4']['name']);
	$photo4 = $HTTP_POST_FILES['photo_4']['name'];		
}
if($HTTP_POST_FILES['photo_5']['size'] > 1)
{
	copy($HTTP_POST_FILES['photo_5']['tmp_name'], $photodir.$HTTP_POST_FILES['photo_5']['name']);
	$photo5 = $HTTP_POST_FILES['photo_5']['name'];
}
if($HTTP_POST_FILES['photo_6']['size'] > 1)
{
	copy($HTTP_POST_FILES['photo_6']['tmp_name'], $photodir.$HTTP_POST_FILES['photo_6']['name']);
	$photo6 = $HTTP_POST_FILES['photo_6']['name'];		
}
if($HTTP_POST_FILES['photo_7']['size'] > 1)
{
	copy($HTTP_POST_FILES['photo_7']['tmp_name'], $photodir.$HTTP_POST_FILES['photo_7']['name']);
	$photo7 = $HTTP_POST_FILES['photo_7']['name'];		
}
if($HTTP_POST_FILES['photo_8']['size'] > 1)
{
	copy($HTTP_POST_FILES['photo_8']['tmp_name'], $photodir.$HTTP_POST_FILES['photo_8']['name']);
	$photo8 = $HTTP_POST_FILES['photo_8']['name'];		
}
if($HTTP_POST_FILES['photo_9']['size'] > 1)
{
	copy($HTTP_POST_FILES['photo_9']['tmp_name'], $photodir.$HTTP_POST_FILES['photo_9']['name']);
	$photo9 = $HTTP_POST_FILES['photo_9']['name'];
}
if($HTTP_POST_FILES['photo_10']['size'] > 1)
{
	copy($HTTP_POST_FILES['photo_10']['tmp_name'], $photodir.$HTTP_POST_FILES['photo_10']['name']);
	$photo10 = $HTTP_POST_FILES['photo_10']['name'];		
}
if($HTTP_POST_FILES['photo_11']['size'] > 1)
{
	copy($HTTP_POST_FILES['photo_11']['tmp_name'], $photodir.$HTTP_POST_FILES['photo_11']['name']);
	$photo11 = $HTTP_POST_FILES['photo_11']['name'];		
}
if($HTTP_POST_FILES['photo_12']['size'] > 1)
{
	copy($HTTP_POST_FILES['photo_12']['tmp_name'], $photodir.$HTTP_POST_FILES['photo_12']['name']);
	$photo12 = $HTTP_POST_FILES['photo_12']['name'];		
}

$db=mysql_connect ("localhost", "smegsmeg_bodysho", "mainstream") or die ('I cannot connect to the database because: ' . mysql_error());
mysql_select_db ("smegsmeg_mhautobody");

$query = "update cars set reg ='$reg', make='$make', model='$model', section='$section', description='$description', photo1='$photo1', photo2='$photo2', caption1='$caption1', photo3='$photo3', photo4='$photo4', caption2='$caption2', photo5='$photo5', photo6='$photo6', caption3='$caption3', photo7='$photo7', photo8='$photo8', caption4='$caption4', photo9='$photo9', photo10='$photo10', caption5='$caption5', photo11='$photo11', photo12='$photo12', caption6='$caption6' where reg ='$reg'";
mysql_query($query);

echo "<p>$reg, $make, $model, $section, p1=$photo1, p2=$photo2, $caption_1, P5=$photo5, $photo4, $caption2.</p>";
include("show_menu.php");
?>

Any help is greatly appreciated.

[Weedpacket]

1. You haven't shown the HTML, but I'm betting you haven't been putting quotes around your tags' attributes.

2. Awfully ugly code, not helped by the failure to use &#91;php] forum tags. Why do you sometimes use $POST and sometimes $HTTP_POST_VARS? Why not use $SESSION instead of session_register()? Or [man]move_uploaded_file[/man]? And why not use arrays a bit more, as suggested in the manual's own FAQ? That would cut your code down to something like 10% its current size, and leave people with less to wade through.

Your question is also ambiguous. "The [pictures] currently on the page disappear." Do you mean they're deleted from the server? They're dropped from the database? The images fail to load, leaving broken images? The page loads fine but without any images?

[lee_umney]

Its my first real PHP project, I'm still learning.
The pictures go from the database, everytime I edit a page the pictures from the original page are deleted when it updates.

Thanks for the comments on tidying up the coding, I will be looking at that shortly.

[Weedpacket]

Originally posted by lee_umney
Its my first real PHP project, I'm still learning.
The pictures go from the database, everytime I edit a page the pictures from the original page are deleted when it updates.

So it sounds like the unlink() calls are happening every time....

Okay, so what does the HTML for the bit of form that deals with uploading/deleting/andsoforth one of these pictures look like? If those unlink()s are happening when they shouldn't be, it probably means that $_POST['photo8_del'] et al. is equal to 1 when it shouldn't be.

[lee_umney]

Thankyou for the reply.
Here is the HTML form, it works perfect in testing, I can run the site on my PC and laptop and it works spot on. Must be something I'm missing.

<body>

<form enctype="multipart/form-data" method="post" action="admin_update.php">
<table width="800" border="1" align="center" cellpadding="0" cellspacing="0">
<tr>
<td colspan="2"> <div align="center">
<h2><strong>Edit a Page. </strong></h2>
</div></td>
</tr>
<tr>
<td width="133"><b>Reg Number:</b></td>
<td><? echo"<input type=text name=reg size=40 maxlength=80 value=\"$reg\">"; ?></td>
</tr>
<tr>
<td width="133"><b>Make:</b></td>
<td width="661">
<? echo"<input type=\"text\" name=\"make\" size=\"40\" maxlength=\"80\" value=\"$make\">"; ?>
</td>
</tr>
<tr>
<td width="133"><b>Model:</b></td>
<td width="661">
<? echo"<input type=\"text\" name=\"model\" size=\"40\" maxlength=\"80\" value=\"$model\">"; ?>
</td>
</tr>
<tr>
<td width="133"><b>Section:</b></td>
<td width="661">
<? if($section=="presrep"){$section1="Present Repairs";}
if($section=="presstyle"){$section1="Present Bodystyling";}
if($section=="presrest"){$section1="Present Restorations";}
if($section=="pastrep"){$section1="Past Repairs";}
if($section=="paststyle"){$section1="Past Bodystyling";}
if($section=="pastrest"){$section1="Past Restorations";}
echo"<select name=section size=1>
<option value=presrep>Present Repairs</option>
<option value=presstyle>Present Styling</option>
<option value=presrest>Present Restoration</option>
<option value=pastrep>Past Repairs</option>
<option value=paststyle>Past Styling</option>
<option value=pastrest>Past Restoration</option>
<option value=$section selected>$section1</option>
</select>"; ?>
</td>
</tr>
<tr>
<td width="133"><b>Description:</b></td>
<td width="661">
<? echo"<textarea name=description cols=80 rows=15>$description</textarea>"; ?>
</td>
</tr>
<tr>
<td width="133"><b>Photo 1:</b></td>
<td width="661"><? if(strlen($photo1) > 1)
{

	echo "<img src=$photobase$photo1 width=100 name=photo_1 value=\"$photo1\"><br>".
			"<input type=checkbox name=photo1_del value=1>".
			" &nbsp; Delete above image";
}?>

	<input type="file" name="photo_1" size="40" maxlength="80">

  </td>
</tr>
<tr> 
  <td width="133"><b>Photo 2:</b></td>
  <td width="661"><? if(strlen($photo2) > 1)
{

	echo "<img src=$photobase$photo2 width=100 name=\"photo_2\" value=\"$photo2\"><br>".
			"<input type=checkbox name=photo2_del value=1>".
			" &nbsp; Delete above image";
}?>

<input type="file" name="photo_2" size="40" maxlength="80">
  </td>
</tr>
<tr> 
  <td width="133"><b>Caption 1:</b></td>
  <td width="661"> 
    <?echo "<input type=\"text\" name=\"caption1\" size=\"40\" maxlength=\"200\" value=\"$caption1\">"; ?>
  </td>
</tr>
<tr> 
  <td width="133"><b>Photo 3:</b></td>
  <td width="661"><? if(strlen($photo3) > 1)
{

	echo "<img src=$photobase$photo3 width=100 name=\"photo_3\" value=\"$photo3\"><br>".
			"<input type=checkbox name=photo3_del value=1>".
			" &nbsp; Delete above image";
}?>
<input type="file" name="photo_3" size="40" maxlength="80">

  </td>
</tr>
<tr>
  <td width="133"><b>Photo 4:</b></td>
  <td><? if(strlen($photo4) > 1)
{

	echo "<img src=$photobase$photo4 width=100 name=\"photo_4\" value=\"$photo4\"><br>".
			"<input type=checkbox name=photo4_del value=0>".
			" &nbsp; Delete above image";
}?>
<input type="file" name="photo_4" size="40" maxlength="80">
  </td>
</tr>
<tr> 
  <td width="133"><b>Caption 2:</b></td>
  <td width="661"> 
    <? echo"<input type=\"text\" name=\"caption2\" size=\"40\" maxlength=\"200\" value=\"$caption2\">"; ?></td>
</tr>
<tr> 
  <td width="133"><b>Photo 5:</b></td>
  <td width="661"> 
    <?if(strlen($photo5) > 1)
{

	echo "<img src=$photobase$photo5 width=100 name=\"photo_5\" value=\"$photo5\"><br>".
			"<input type=checkbox name=photo5_del value=1>".
			" &nbsp; Delete above image";
}?>
	<input type="file" name="photo_5" size="40" maxlength="80">

  </td>
</tr>
<tr> 
  <td width="133"><b>Photo 6:</b></td>
  <td width="661"> 
    <?if(strlen($photo6) > 1)
{

	echo "<img src=$photobase$photo6 width=100 name=\"photo_6\" value=\"$photo6\"><br>".
			"<input type=checkbox name=photo6_del value=1>".
			" &nbsp; Delete above image";
}?>
<input type="file" name="photo_6" size="40" maxlength="80">
  </td>
</tr>
<tr> 
  <td width="133"><b>Caption 3:</b></td>
  <td width="661"> 
    <? echo"<input type=\"text\" name=\"caption3\" size=\"40\" maxlength=\"200\" value=\"$caption3\">"; ?>
  </td>
</tr>
<tr> 
  <td width="133"><b>Photo 7:</b></td>
  <td width="661"> 
    <?if(strlen($photo7) > 1)
{

	echo "<img src=$photobase$photo7 width=100 name=\"photo_7\" value=\"$photo7\"><br>".
			"<input type=checkbox name=photo7_del value=1>".
			" &nbsp; Delete above image";
}?>
<input type="file" name="photo_7" size="40" maxlength="80">
  </td>
</tr>
<tr> 
  <td width="133"><b>Photo 8:</b></td>
  <td width="661"> 
    <?if(strlen($photo8) > 1)
{

	echo "<img src=$photobase$photo8 width=100><br>".
			"<input type=checkbox name=photo8_del value=1>".
			" &nbsp; Delete above image";
}?>

	<input type="file" size="40" maxsize="80" name="photo_8"></td>
</tr>
<tr> 
  <td width="133"><b>Caption 4:</b></td>
  <td width="661"> 
    <? echo"<input type=\"text\" name=\"caption4\" size=\"40\" maxlength=\"200\" value=\"$caption4\">"; ?>
  </td>
</tr>
<tr> 
  <td width="133"><b>Photo 9:</b></td>
  <td width="661"> 
    <?if(strlen($photo9) > 1)
{

	echo "<img src=$photobase$photo9 width=100><br>".
			"<input type=checkbox name=photo9_del value=1>".
			" &nbsp; Delete above image";
}?>
<input type="file" size="40" maxsize="80" name="photo_9">
  </td>
</tr>
<tr> 
  <td width="133"><b>Photo 10:</b></td>
  <td width="661"> 
    <?if(strlen($photo10) > 1)
{

	echo "<img src=$photobase$photo10 width=100><br>".
			"<input type=checkbox name=photo10_del value=1>".
			" &nbsp; Delete above image";
}?>
<input type="file" size="40" maxsize="80" name="photo_10">

  </td>
</tr>
<tr> 
  <td width="133"><b>Caption 5:</b></td>
  <td width="661"> 
    <? echo"<input type=\"text\" name=\"caption5\" size=\"40\" maxlength=\"200\" value=\"$caption5\">"; ?>
  </td>
</tr>
<tr> 
  <td width="133"><b>Photo 11:</b></td>
  <td width="661"> 
    <?if(strlen($photo11) > 1)
{

	echo "<img src=$photobase$photo11 width=100><br>".
			"<input type=checkbox name=photo11_del value=1>".
			" &nbsp; Delete above image";
}?>
<input type="file" size="40" maxsize="80" name="photo_11">
  </td>
</tr>
<tr> 
  <td width="133"><b>Photo 12:</b></td>
  <td width="661"> 
    <?if(strlen($photo12) > 1)
{

	echo "<img src=$photobase$photo12 width=100><br>".
			"<input type=checkbox name=photo12_del value=1>".
			" &nbsp; Delete above image";
}?>
<input type="file" size="40" maxsize="80" name="photo_12">
  </td>
</tr>
<tr> 
  <td width="133"><b>Caption 6:</b></td>
  <td width="661"> 
    <? echo"<input type=\"text\" name=\"caption6\" size=\"40\" maxlength=\"200\" value=\"$caption6\">"; ?>
  </td>
</tr>
<tr> 
  <td colspan="2"> 
    <div align="center"> 

	  <input type="submit" name="Submit" value="Edit Page">
    </div>
  </td>
</tr>

</table>
</form>
</body>
</html>

[lee_umney]

I have sorted the first problem, Weedpacket was right, I had left the quotes out. Damn silly mistake.

I think the problem of 'losing' the pictures is due to the information not being passed from the form to the update script but I can't see where I have gone wrong.
I don't want some-one to do the coding for me just to point me in the right direction, so I can learn from the mistake.
Thanks in advance.

[lee_umney]

bump

[cbj4074]

Bumping your own thread (especially so quickly) is the best way not to receive a response. As others in this thread have suggested, it's a bit cumbersome to read 300 lines of PHP when you could have written it in 30 with minimal effort and a short read of the basic PHP documentation.

That being said, the first thing I notice is that you haven't enclosed at least half of your HTML element attributes (e.g. <input name=somename />) in quotes (preferably double quotes, as that is the W3C standard). Many browsers will not correctly pass form element attributes that are not properly quoted. You may want to check into that issue if you haven't yet figured out the problem. Perhaps it works on your laptop because you're using a browser that doesn't care if the quotes are absent...

[lee_umney]

Thanks for the reply and sorry for bumping my post so quickly. This is my first PHP project and while it works perfect on my test server on my laptop it doesn't work as it should on the 'net, I'm anxious to know where I have gone wrong. I will look at what you have said regarding the quotes.
Thank you for the reply.

[lee_umney]

Thank you for the replies, I have now sorted the problem. It was to do with the values of the photos not being passed to the update page.