[Resolved] Uploaded image disappears when updating

kekke

Hi!

I have a problem with the function UPDATE in sql. Posting and updating works fine except that I need to upload my image everytime when I want to update an, for an example, newsitem.

I know there is a way to make the already uploaded image to stay, but I don´t know how to do that.

Can anyone help me please? Thanks in advance!

Below is the code for the update-page.


<HTML>

<body bgcolor="#ADC5DE">

<FONT FACE="verdana" SIZE="1"><B>

<?php

if($submit)

{

if (is_uploaded_file($_FILES['userfile1']['tmp_name'])) { 

$webpath = 'http://www.my-domain.com/images/'; 

$folder = '/my/full/path/images/'; 

$imagelocation = $webpath.$_FILES['userfile1']['name']; 

move_uploaded_file($_FILES['userfile1']['tmp_name'], $folder.$_FILES['userfile1']['name']); 

echo "<BR>"; 

echo "Bilden uppladdad.<BR>"; 

} else { 

$imagelocation = ''; 

echo "Ingen bild uppladdad.<BR>"; 

}



// Koppla till DB

$db = mysql_connect("localhost", "username", "password"); mysql_select_db("my_db"); 

$sql = "INSERT INTO front (titel, text, imagelocation, sortorder) 

VALUES ('$titel','$text','$imagelocation','$sortorder')";

$result = mysql_query($sql);

echo "Nyheten är publicerad.\n";

}

else if($update)

{

if (is_uploaded_file($_FILES['userfile1']['tmp_name'])) { 

$webpath = 'http://www.my-domain.com/images/'; 

$folder = '/my/full/path/images/'; 

$imagelocation = $webpath.$_FILES['userfile1']['name']; 

move_uploaded_file($_FILES['userfile1']['tmp_name'], $folder.$_FILES['userfile1']['name']); 

echo "<BR>"; 

echo "Bilden uppladdad. "; 

} else { 

$imagelocation = '';

echo "Ingen bild uppladdad.<BR>";

}

$db = mysql_connect("localhost", "username", "password"); mysql_select_db("my_db"); 

$sql = "UPDATE front SET titel='$titel', 

text='$text',imagelocation='$imagelocation',sortorder='$sortorder' WHERE id=$id";

$result = mysql_query($sql);

echo "Nyheten är uppdaterad.\n";

}

else if($id)

{

$db = mysql_connect("localhost", "username", "password"); mysql_select_db("my_db"); 

$result = mysql_query("SELECT * FROM front WHERE id=$id",$db);

$myrow = mysql_fetch_array($result);

?>

<form method="post" action="<?php echo $PHP_SELF?>" ENCTYPE="multipart/form-data">

<input type="hidden" name="id" value="<?php echo $myrow["id"]?>">

<FONT FACE="verdana" SIZE="1"><B>S/O:<BR> <input type="Text" size="3" name="sortorder" value="<?php echo $myrow["sortorder"]?>"><br>

<FONT FACE="verdana" SIZE="1"><B>Titel:<BR> <input type="Text" name="titel" value="<?php echo $myrow["titel"]?>"><br>

<FONT FACE="verdana" SIZE="1"><B>Brödtext:<BR> <textarea rows="10" name="text" cols="36"><?php echo $myrow["text"]?></textarea><br>

<b>Ladda upp ny bild:<BR></b>

<input type="file" name="userfile1" size="35">

<BR><input type="Submit" name="update" value="Uppdatera"></form>

<?

}

else

{

?>

<form method="post" action="<?php echo $PHP_SELF?>" ENCTYPE="multipart/form-data">

<FONT FACE="verdana" SIZE="1"><B>S/O:<BR> <input type="Text" size="3" name="sortorder" value="<?php echo $myrow["sortorder"]?>"><br>

<FONT FACE="verdana" SIZE="1"><B>Titel:<BR><input type="Text" name="titel"><br>

<FONT FACE="verdana" SIZE="1"><B>Brödtext:<BR><input type="Textarea" rows="10" cols="30" name="text"><br>

<?php

print("<input type=\"file\" name=\"userfile1\" size=\"35\">\n");

?>

<input type="Submit" name="submit" value="Enter information"></form>

<?

}

?>

</HTML>

kekke

Anyone have any ideas? Is there a tutorial about this?

kekke

Now I have tried just about everything that I could think of but with no result! :glare:

I really don´t know what to do.
Am I on the right track when I am thinking it has to do with some sort of if-statement?

I just want the update-page not to remove the already uploaded image!

Please help, I really need to get this to work! 🙁

kekke

Anyone? Sorry if I am nagging but I really need help on this one! I have tried for a week now... 🙁

travelbuff

Kekke:

It appears to me that when you are doing the update, your are overwriting the existing file info (assuming that a new file is not uploaded).

Look at this:

else if($update) { 

if  (is_uploaded_file($_FILES['userfile1']['tmp_name'])) {
 //This is saying "if a new file has been uploaded, process it 
   $webpath = 'http://www.my-domain.com/images/';  

   $folder = '/my/full/path/images/';  

   $imagelocation = $webpath.$_FILES['userfile1']['name'];  

   move_uploaded_file($_FILES['userfile1']['tmp_name'],
  $folder.$_FILES['userfile1']['name']);  

echo "<BR>";  

echo "Bilden uppladdad. ";  

} else {  

$imagelocation = '';  //This is saying "If no file was uploaded, the image location is "blank", or none. Later, in the $sql variable, you are writing that info to the DB....

echo "Ingen bild uppladdad.<BR>"; 
}

So you have 2 choices:
1. Have the image info default to the values currently stored in the DB
2. Build the query so that it does not change the image location in the DB if a new file is not uploaded.

Number 2 is the simplest, you can do it like this:

if  (is_uploaded_file($_FILES['userfile1']['tmp_name'])) {   

  $webpath = 'http://www.my-domain.com/images/';  

  $folder = '/my/full/path/images/';  

  $imagelocation = $webpath.$_FILES['userfile1']['name'];  

   move_uploaded_file($_FILES['userfile1']['tmp_name'], 
   $folder.$_FILES['userfile1']['name']);  

//query that writes new image location info
$sql = "UPDATE front SET titel='$titel', text='$text',imagelocation='$imagelocation',
sortorder='$sortorder' WHERE id=$id"; 

echo "<BR>";  

echo "Bilden uppladdad. ";  

} else {  

$imagelocation = ' '; 
//query that does not write to image location field
$sql = "UPDATE front SET titel='$titel', 
 text='$text',sortorder='$sortorder' WHERE id=$id"; 

echo "Ingen bild uppladdad.<BR>"; 

} 

$db = mysql_connect("localhost", "username", "password"); mysql_select_db("my_db");  

 $result = mysql_query($sql); 

echo "Nyheten är uppdaterad.\n"; 

}

Make sense?

kekke

Thanks!

It does actually make sense to me 😉

But...it does not make any changes at all!
I´ll go through the code again to see if I can find whats wrong!

kekke

Now I can´t get anywhere!
Please...does anyone have any ideas?

kkobashi

kekke:

Put some print statements in your code to trace the thread of execution along with the values of your variables.

Also, I noticed you didn't give us your entire code. We don't know if your $submit, $update, $id blocks are getting executed. Those variable values are unknown and look uninitialized to me.

Are you sure the proper block of code is getting executed? For example you have the $submit if block, the $update if block, the $id if block, etc. Place print statements in there to debug it. Perhaps they are not getting executed as you think they are?

kekke

kkobashi:

Thanks for your input, I´ll try it out. I think i know what the problem is now! 😃 (I hope)

kekke

travelbuff: I tried your second option and in theory I do understand how to do this. The problem I have now is how to implement the form for updating. I really don´t know where to put it! I have tried all possible places but with no result. 🙁

What I want to do is to have a page with a form with the previously posted content already filled in the formfields.

This did work with my old code and the updating process worked fine, except for the imagefunction.

Now I also made it possible to view the previously uploaded image. But still the problem is that the image disappears when I hit the button "Update".

It might be worth mentioning that I access this page from another page in my admin. So this page gets the results based on what id it has.

Make sense? Please tell me if you don´t understand!

travelbuff

I tried your second option and in theory I do understand how to do this. The problem I have now is how to implement the form for updating. I really don´t know where to put it! I have tried all possible places but with no result.

I'm sorry, I don't understand what you mean - where to put it? You mean where in your code?

It appears to me that in your original code you had this as the primary conditional:

if ($submit) {
insert data into the db

} else if ($update) {
update the data in the db

} else if ($id) {
show the update form w/data pre-populated

} else {
show the new data form
}

So when UPDATE is TRUE you need to preserve the image location data for the image using one of the two methods in my original post.

kekke

Hi!

All I want to do with the page is to UPDATE the previously posted content. Thats all, and to keep the image there.

I don´t need to post anything new, I have another page for this, and it works perfect.

What I need to know is were to put the code for the update form.

And also, if possible while were at it, slim the code. I belive at least 30% of the code is unnecessary. Or is it?

Perhaps I can do something like this:

if ($update) { 
update the data in the db 

} else if ($id) { 
show the update form w/data pre-populated 
Form code here
}

travelbuff

ok, I couldn't help myself, I pretty much rewrote your code. Let me explain a bit of what I did:
I broke the script into one main conditional - either the form has been submitted or it has not. Everything else is contigent upon that. You cannot use an else if $id as you suggested becasue $id is ALWAYS going to be present if the script is working right (you are setting $id as a hidden field in your form).
Underneath that main conditional I am doing the other things like checking for the presence of an uploaded file and building the sql statement accordingly.

NOTE: even with the my (sloppy) revisions, the code is still...well....sub-optimal:
1. you are not validating the uploaded file - very dangerous
2. you are assuming register globals is on...
3. you are not performing verifications after each step (I added a couple, but there should be more).

<?
if($update) { 
//the form has been submitted, process it
	if  (is_uploaded_file($_FILES['userfile1']['tmp_name'])) { 
	//the user uploaded a file with the form, we need to move it and build a 
	//sql statement to update the data in the db

	$webpath = 'http://www.my-domain.com/images/'; 
	$folder = '/my/full/path/images/'; 
	$imagelocation = $webpath.$_FILES['userfile1']['name']; 

	if (move_uploaded_file($_FILES['userfile1']['tmp_name'], $folder.
	$_FILES['userfile1']['name'])) { 

		$sql = "UPDATE front SET titel='$titel', text='$text',imagelocation='$imagelocation',
		sortorder='$sortorder' WHERE id=$id LIMIT 1";

		$conf_msg = " <BR/> Bilden uppladdad.<BR/>"; 

	} else {

		$conf_msg = "There was a problem processing the image...please notify the 
					SysAdmin at [email]myemail@mydomain.com[/email]";
	} //end if else for a sucessful copy

} else { 
//the form was submitted, but no image was uploaded with it

$sql = "UPDATE front SET titel='$titel', text='$text',
		sortorder='$sortorder' WHERE id=$id LIMIT 1";
	//notice that this sql statement DOES NOT change image location


} //done w/image processing stuff, now we need to finish processing
 // the form.

//db connection data
$db = mysql_connect("localhost", "username", "password"); mysql_select_db("my_db"); 

//run the query
$result = mysql_query($sql) OR DIE ("Could not update the data in the database" . mysql_error());

//I didn't add an if to make sure the query ran sucessfully
// because I used OR DIE to kill the script if there is a db problem
$conf_msg .= "Nyheten är publicerad.\n";

echo $conf_msg ;

} else {
//the form has not been submitted
//that does not need to be an else if, we are going to 
//check for a $id value underneath the main else - if
	if (!$id) {

	echo "No record was selected to update.";
	exit ;
}

// $id is present, get the data to prepopulate the form
$db = mysql_connect("localhost", "username", "password"); mysql_select_db("my_db"); 

$result = mysql_query("SELECT * FROM front WHERE id=$id",$db) OR DIE 
      	("Could not retrieve the record from the database" . mysql_error())

$myrow = mysql_fetch_array($result);
?>	
<form method="post" action="<?php echo $PHP_SELF?>" ENCTYPE="multipart/form-data">

<input type="hidden" name="id" value="<?php echo $myrow["id"]?>">

<FONT FACE="verdana" SIZE="1"><B>S/O:<BR> <input type="Text" size="3" name="sortorder" value="<?php echo $myrow["sortorder"]?>"><br>

<FONT FACE="verdana" SIZE="1"><B>Titel:<BR> <input type="Text" name="titel" value="<?php echo $myrow["titel"]?>"><br>

<FONT FACE="verdana" SIZE="1"><B>Brödtext:<BR> <textarea rows="10" name="text" cols="36"><?php echo $myrow["text"]?></textarea><br>

<b>Ladda upp ny bild:<BR></b>

<input type="file" name="userfile1" size="35">

  <BR><input type="Submit" name="update" value="Uppdatera">

</form> 
<?
} //close the else, we're done
?>

Hope that helps a bit.

kekke

Travelbuff...

You are a genius! It worked! I can´t thank you enough...really...I have struggled with this for months now!

Thank you sooo much!

Now I will study this code really carefully and learn!

Thanks again! 🙂 You´re the best!