Loop Questions

[dmacman1962]

Hello all,

I have a table with products listed in it. for example:

1 Apples
2 Oranges
3 Carrots
4 Melons
5 Grapefruit

and I am building the links dynamically from the list and want anything greater than 4 to have a different dynamic page than items 1-3. Here is the code I have so far:

[
$sql = "SELECT * FROM ptproducts";
$result = mysql_query($sql, $connpt) or die(mysql_error());

	if (mysql_num_rows($result) < 1) {
	print "There are no products to display.";
		} else {
	while ($row = mysql_fetch_array($result, MYSQL_ASSOC)) {
	$Name = $row['Name'];
	$ID = $row['ID'];
	print "<li>'<a href=http://www.ptideas.com/dev/printtech/template.php?ID=$ID>'$Name</li>";
	}
	}

]

I tried to change my code and create and if else loop [ if ($result) <0 && ($result) <4) ] but I get double listed items, items 1-5, not just 1-3.

I don't know if this is making sense, but if not, I can repost to the questions.

Thanks in advance,
Dmacman

[bubblenut]

Is this what you mean?

$sql = "SELECT * FROM ptproducts";
$result = mysql_query($sql, $connpt) or die(mysql_error());

if (mysql_num_rows($result) < 1) {
	print "There are no products to display.";
} else {
	for ($i=0;$row = mysql_fetch_array($result, MYSQL_ASSOC);$i++) {
		$Name = $row['Name'];
		$ID = $row['ID'];
		if($i<3) {
			print "<li><a href=\"http://www.ptideas.com/dev/printtech/template.php?ID=$ID\">$Name</a></li>";
		} else {//it's more than three
			print "<li><a href=\"http://www.ptideas.com/dev/printtech/template2.php?ID=$ID\">$Name</a></li>";
		}
	}
} 

[dmacman1962]

Thanks Bubblenut,

That is exactly what I mean, almost. I tried your code and get a parse error. It seems to cover what I am looking , but I just haven't figured out where the parse error is.

Did I miss something?

Thanks,

Dmacman

[bubblenut]

Try doing a bit of work for yourself. We're here to help, not do everything for you. Parse errors are usually very easy to debug, it tells you which line it's on so you can just go to that line and scoure it and the line before it.

[dmacman1962]

Bubblenut,

I did not expect you to do all the work for me. I tried debugging the code and I believe the error is in either this line:

[
for ($i=0;$row = mysql_fetch_array($result, MYSQL_ASSOC);$i++) {
]

or this line:
[
if($i<3) {
]

As far as going to the line the parse error reports, I have never been able to get even close to the correct line with those error messages. It reports line 124, there is no code on that line and the 6 lines before it are rem'd out and the 4 lines after are just selecting the database. I even tried to copy and paste the exact code for those lines in from another file that works, and I still get the error.

Sorry, but I 'm new at this and I looked et every character in the code and did not identify an error yet.

thanks,

Dmacman

[bubblenut]

Well there's nothing wrong with either of the two lines you put forward and the exact and complete error you are getting.

[dmacman1962]

Bubblenut,

Here is the error:

[
Parse error: parse error in /home/ptideas/ptideas.com/dev/printtech/pt2a.php on line 124

Here are lines before and after 124:

123 $totalRows_RSproducts = mysql_num_rows($RSproducts);/
124
125 $sql = "SELECT FROM ptproducts";

]

Here is all of my php code - minus the username and password info

[
<?
$hostname_connpt = "xx";
$database_connpt = "xx";
$username_connpt = "xx";
$password_connpt = "xx";
$connpt = mysql_pconnect($hostname_connpt, $username_connpt, $password_connpt) or trigger_error(mysql_error(),E_USER_ERROR);
mysql_select_db($database_connpt, $connpt);
/$query_RSproducts = "SELECT FROM ptproducts";
$RSproducts = mysql_query($query_RSproducts, $connpt) or die(mysql_error());
$row_RSproducts = mysql_fetch_assoc($RSproducts);
$totalRows_RSproducts = mysql_num_rows($RSproducts);*/

	$sql = "SELECT * FROM ptproducts";
	$result = mysql_query($sql, $connpt) or die(mysql_error());

	if (mysql_num_rows($result) < 1) {
	print "There are no products to display.";
} else {

for ($i=0;$row = mysql_fetch_array($result, MYSQL_ASSOC);$i++) {
$Name = $row['Name'];
$ID = $row['ID'];
if($i<3) {
print "<li><a href=\"http://www.ptideas.com/dev/printtech/template.php?ID=$ID\">$Name</a></li>";
} else {//it's more than three
print "<li><a href=\"http://www.ptideas.com/dev/printtech/template.php?ID=$ID\">$Name</a></li>";
}
}
}
?>
]

i do not see an error, but there is on in there somewhere.

Thanks again,

Dmacan

[bubblenut]

Well, I just ran it on my machine with

php -l ./test.php

to test for syntax errors and it came up with nothing. What happens if you remove the commented out lines all together? Can you post the entire code up so that I can re-create the error locally? What version of php are you running?

[dmacman1962]

Bubblenut,

The page I am having an issue with is online at:

http://www.ptideas.com/dev/printtech/pt2a.php

They are running 2.5.6 and mysql 3.23.55.

Here is the code for the entire webpage:

[

<html>
<head>
<title>Printing Technologies Inc. - Commercial Printing Services - Erie, Pa</title>
<meta name="description" content="Printing Technologies Companies Inc. - Erie, PA ">
<meta name="keywords" content="Rrinting Technologies Companies, ptideas, printers, erie, pa">
<meta name="revisit-after" content="60 Days">
<meta name="Classification" content="Commercial">
<meta name="robots" content="ALL">
<meta name="rating" content="General">
<meta name="Language" content="en">
<meta name="copyright" content="Printing Technologies Companies Inc.">
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<link rel="stylesheet" href="main.css" type="text/css">
<script language="JavaScript" src="js/popwin.js">
<!--
function MM_preloadImages() { //v3.0
var d=document; if(d.images){ if(!d.MM_p) d.MM_p=new Array();
var i,j=d.MM_p.length,a=MM_preloadImages.arguments; for(i=0; i<a.length; i++)
if (a.indexOf("#")!=0){ d.MM_p[j]=new Image; d.MM_p[j++].src=a;}}
}

function MM_swapImgRestore() { //v3.0
var i,x,a=document.MM_sr; for(i=0;a&&i<a.length&&(x=a)&&x.oSrc;i++) x.src=x.oSrc;
}

function MM_findObj(n, d) { //v4.01
var p,i,x; if(!d) d=document; if((p=n.indexOf("?"))>0&&parent.frames.length) {
d=parent.frames[n.substring(p+1)].document; n=n.substring(0,p);}
if(!(x=d[n])&&d.all) x=d.all[n]; for (i=0;!x&&i<d.forms.length;i++) x=d.forms[n];
for(i=0;!x&&d.layers&&i<d.layers.length;i++) x=MM_findObj(n,d.layers.document);
if(!x && d.getElementById) x=d.getElementById(n); return x;
}

function MM_swapImage() { //v3.0
var i,j=0,x,a=MM_swapImage.arguments; document.MM_sr=new Array; for(i=0;i<(a.length-2);i+=3)
if ((x=MM_findObj(a))!=null){document.MM_sr[j++]=x; if(!x.oSrc) x.oSrc=x.src; x.src=a[i+2];}
}
//-->
</script>
<script language="JavaScript" type="text/JavaScript">
<!--
function MM_preloadImages() { //v3.0
var d=document; if(d.images){ if(!d.MM_p) d.MM_p=new Array();
var i,j=d.MM_p.length,a=MM_preloadImages.arguments; for(i=0; i<a.length; i++)
if (a.indexOf("#")!=0){ d.MM_p[j]=new Image; d.MM_p[j++].src=a;}}
}

function MM_swapImgRestore() { //v3.0
var i,x,a=document.MM_sr; for(i=0;a&&i<a.length&&(x=a)&&x.oSrc;i++) x.src=x.oSrc;
}

function MM_findObj(n, d) { //v4.01
var p,i,x; if(!d) d=document; if((p=n.indexOf("?"))>0&&parent.frames.length) {
d=parent.frames[n.substring(p+1)].document; n=n.substring(0,p);}
if(!(x=d[n])&&d.all) x=d.all[n]; for (i=0;!x&&i<d.forms.length;i++) x=d.forms[n];
for(i=0;!x&&d.layers&&i<d.layers.length;i++) x=MM_findObj(n,d.layers[i].document);
if(!x && d.getElementById) x=d.getElementById(n); return x;
}

function MM_swapImage() { //v3.0
var i,j=0,x,a=MM_swapImage.arguments; document.MM_sr=new Array; for(i=0;i<(a.length-2);i+=3)
if ((x=MM_findObj(a[i]))!=null){document.MM_sr[j++]=x; if(!x.oSrc) x.oSrc=x.src; x.src=a[i+2];}
}
//-->
</script>
</head>
<body bgcolor="#FFFFFF" background="graphics/gb.gif" text="#666666" link="#003366" vlink="#003366" alink="#003366" leftmargin="0" topmargin="0" marginwidth="0" marginheight="0" onLoad="MM_preloadImages('graphics/nav/nav_pt_r1_c1_f2.gif','graphics/nav/nav_pt_r1_c2_f2.gif','graphics/nav/nav_pt_r1_c3_f2.gif','graphics/nav/nav_pt_r1_c4_f2.gif','graphics/nav/nav_pt_r1_c5_f2.gif')">
<table width="100%" border="0" cellspacing="0" cellpadding="0">
<tr>
<td><img src="graphics/tr.gif" width="100" height="9"></td>
</tr>
</table>
<table width="740" border="0" cellspacing="0" cellpadding="0">
<tr>
<td width="287" rowspan="4" align="left" valign="top"><img src="graphics/pt_logo.jpg" width="287" height="63"></td>
<td align="center" valign="top"><img src="graphics/tagline.gif" width="251" height="32"></td>
</tr>
<tr>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="415">
<!-- fwtable fwsrc="navbar_pt.png" fwbase="nav_pt.gif" fwstyle="Dreamweaver" fwdocid = "742308039" fwnested="0" -->
<tr>
<td><img name="nav_pt_r1_c1_f2" src="graphics/nav/nav_pt_r1_c1_f2.gif" width="82" height="23" border="0" alt="Printing Technologies Companies Home"></td>
<td><a href="pt_products.htm" target="self" onMouseOut="MM_swapImgRestore()" onMouseOver="MM_swapImage('nav_pt_r1_c2','','graphics/nav/nav_pt_r1_c2_f2.gif',1);"><img name="nav_pt_r1_c2" src="graphics/nav/nav_pt_r1_c2.gif" width="83" height="23" border="0" alt="Printing Technologies Products"></a></td>
<td><a href="pt_support.htm" target="self" onMouseOut="MM_swapImgRestore()" onMouseOver="MM_swapImage('nav_pt_r1_c3','','graphics/nav/nav_pt_r1_c3_f2.gif',1);"><img name="nav_pt_r1_c3" src="graphics/nav/nav_pt_r1_c3.gif" width="81" height="23" border="0" alt="Printing Technologies Support"></a></td>
<td><a href="http://www.printstorefront.com/printingtechnologies/index.jsp" target="blank" onMouseOut="MM_swapImgRestore()" onMouseOver="MM_swapImage('nav_pt_r1_c4','','graphics/nav/nav_pt_r1_c4_f2.gif',1);"><img name="nav_pt_r1_c4" src="graphics/nav/nav_pt_r1_c4.gif" width="83" height="23" border="0" alt="Printing Technologies Order"></a></td>
<td><a href="pt_contact.htm" target="self" onMouseOut="MM_swapImgRestore()" onMouseOver="MM_swapImage('nav_pt_r1_c5','','graphics/nav/nav_pt_r1_c5_f2.gif',1);"><img name="nav_pt_r1_c5" src="graphics/nav/nav_pt_r1_c5.gif" width="86" height="23" border="0" alt="Printing Technologies Contact Us"></a></td>
</tr>
</table>
</td>
</tr>
<tr>
<td><img src="graphics/tr.gif" width="1" height="5"></td>
</tr>
</table>
<table width="740" border="0" cellspacing="0" cellpadding="4">
<tr align="left" valign="top">
<td colspan="4"><img src="graphics/tr.gif" width="100" height="10"> </td>
</tr>
<tr align="left" valign="top">
<td width="20"><img src="graphics/tr.gif" width="20" height="10"></td>
<td>
<p><img src="graphics/ptopengraphic4.jpg" width="302" height="299"></p>
</td>
<td>
<h1>Welcome to Printing Technologies...</h1>
<p>Commercial printing services utilizing conventional and digital printing
resources. In a world of high tech, we have high tech support. </p>
<ul>
<?
$hostname_connpt = "xx";
$database_connpt = "xx";
$username_connpt = "xx";
$password_connpt = "xx";
$connpt = mysql_pconnect($hostname_connpt, $username_connpt, $password_connpt) or trigger_error(mysql_error(),E_USER_ERROR);
mysql_select_db($database_connpt, $connpt);
/$query_RSproducts = "SELECT FROM ptproducts";
$RSproducts = mysql_query($query_RSproducts, $connpt) or die(mysql_error());
$row_RSproducts = mysql_fetch_assoc($RSproducts);
$totalRows_RSproducts = mysql_num_rows($RSproducts);*/

	$sql = "SELECT * FROM ptproducts";
	$result = mysql_query($sql, $connpt) or die(mysql_error());

	if (mysql_num_rows($result) < 1) {
	print "There are no products to display.";
} else {

for ($i=0;$row = mysql_fetch_array($result, MYSQL_ASSOC);$i++) {
$Name = $row['Name'];
$ID = $row['ID'];
if($i<3) {
print "<li><a href=\"http://www.ptideas.com/dev/printtech/template.php?ID=$ID\">$Name</a></li>";
} else {//it's more than three
print†"<li><a href=\"http://www.ptideas.com/dev/printtech/template.php?ID=$ID\">$Name</a></li>";
}
}
}
?>
</ul>
</td>
<td align="center">
<p><a href="javascript😮penWin('message.htm', 375, 525, 0, 0)"><img src="graphics/message.jpg" width="149" height="138" border="0"></a></p>
<p><img src="graphics/tr.gif" width="10" height="150"></p>
<p><a href="http://www.adobe.com" target="_blank"><img src="graphics/adobelogo.gif" alt="Adobe Solutions Provider" width="87" height="34" border="0"></a></p>
</td>
</tr>
<tr align="left" valign="top">
<td>&nbsp;</td>
<td>&nbsp;</td>
<td>&nbsp;</td>
<td>&nbsp;</td>
</tr>
</table>
<table width="100%" border="0" cellspacing="2" cellpadding="4">
<tr>
<td bgcolor="#000033">
<table width="740" border="0" cellspacing="0" cellpadding="0">
<tr>
<td width="20"><img src="graphics/tr.gif" width="20" height="1"></td>
<td class="copy">&copy;Copyright 2003 Printing Technologies Companies.
All rights reserved</td>
<td><img src="graphics/800_number.jpg"></td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>

]

I can email you the file also, if that would help.

Note: I did have to replace these characters "†" in the section I copied and pasted from your post with spaces in the code you wrote.???
Thanks again,

Dmacman

[bubblenut]

I'm sorry but nothing I do can re-create the error. What version of php are you running? I'm pretty sure it's not 2.5.6

Could you mail me the file please and are you sure there is nothing you've changed in it other than the mysql login details?

Also, have you tried removing the commented out lines alltogether like I asked you in the last post?

[dmacman1962]

Bubblenut,

I deleted all the remarked lines and still the same thing.

As far as what version of PHP is running, this is hosted at our ISP velocity.net. They have hundreds of sites running php and we are just one of them.

I don't know why you are not getting the error I am, since it is a public website, not my internal machine hosting the site.

Any ideas anyone?

Thanks,

Dmacman

[bubblenut]

So far I've tested it on my box at home
Win2K : PHP5.0.0 & 4.3.8
Redhat 9.0 : PHP4.3.8

On my local box at work:
WinXPPro PHP4.3.5

On the Test Server at work:
Redhat 8.something : PHP4.3.4

On the Application server at work:
Redhat 8.something : PHP4.2.2

and not one of them complained about a syntax error. In the code you posted up there simply is not a syntax error. Try saving the file as a .txt, changing the login details and then uploading it as a post attachment. It may be that phpbb is removing some characters, like backslashes or something.

[dmacman1962]

Bubblenut,

Here is the file as .txt

Thanks,

Dmacman

[dmacman1962]

I don't understand why I would get this error off a commercial ISP box, but it runs perfect on the machines you tested it on?

Did anyone else ever run into this?

Thanks,
Dmacman