Cant insert value into table (mysql)

meepokman

Hello guys,

I'm quite new to mysql via php. Thus I need some advise here.

I am unable to insert any values into my table. I have done some research on the web, but none of the solutions work for me. I'm baffled.

<?php
include 'check.php';
echo'<br>';
$link = mysql_connect('localhost', 'ant', 'ant')
   or die("Could not connect : " . mysql_error());
echo '<font>Connected successfully</font><br>';
mysql_select_db('ant') or die("Could not select database");

#First Insert
#$login has been declared and is not empty
$query = "INSERT INTO user VALUES (".$login.")";
$result = mysql_query($query);
if ($result)
echo mysql_affected_rows()." stuff was inserted.";

#second insert
$query = "INSERT INTO user VALUES ('yc')";

#Query table
$query="SELECT * FROM user";
$result=mysql_query($query);
$num=mysql_numrows($result);

echo $num;
mysql_close($link);
echo '<font>Disconnected successfully</font><br>';
?>

well.... $num was suppose to return the number of entries in the table user. I was expecting 2 but 0 was returned instead.

Which basically means nothing was inserted.

Please help.

Thanks!

devinemke

you are not specifying any field names in your INSERT statements. try something like this:

$query = "INSERT INTO user SET field = '" . $login . "'";

where "field" is the name of the field that in which you want to insert $login.

mourisj

1st insert:

You try to insert a string value without quoting it! you should have a database-error (maybe it's overridden by the rest you do).
And it can only work if your table has one single column! Otherwise, see the previous post!

2nd insert:
You just define the query, but never do a mysql_query() with it.

Result:

One insert is wrong, the other is never executed! --> No rows are inserted.

Mysql and PHP are right, as is your final query which returns all your data (i.e. nothing)

JJ Mouris

meepokman

Originally posted by mourisj
1st insert:

You try to insert a string value without quoting it! you should have a database-error (maybe it's overridden by the rest you do).
And it can only work if your table has one single column! Otherwise, see the previous post!

I realized the silly mistake for the second insert.

And the 1st insert works as per stated in the previous post.

$query = "INSERT INTO user SET name = '" . $login . "'";

But as mentioned, shouldnt my original code work if there is only 1 column. This is because my table user has only 1 col (name) and yet the code is not working.

$query = "INSERT INTO user Values = '" . $login . "'";

Why is this so?

Thanks!

meepokman

Just to add on to my qn.

If I have many cols in my user table.

How am I gonna insert if I have to always set the field name??

$query = "INSERT INTO user SET name = '" . $login . "'";

Does that mean if I have 25 cols, I have to repeat the abv statement for 25 times?

I asked coz the abv statement seems to be the only way to insert data into my table

devinemke

Originally posted by meepokman
Does that mean if I have 25 cols, I have to repeat the abv statement for 25 times?

$query = "INSERT INTO table SET
field1 = '" . $val1 . "',
field2 = '" . $val2 . "',
field3 = '" . $val3 . "' ... etc ...

mourisj

Originally posted by mmepokman:

But as mentioned, shouldnt my original code work if there is only 1 column. This is because my table user has only 1 col (name) and yet the code is not working.

PHP:

$query = "INSERT INTO user Values = '" . $login . "'";

Why is this so?

In fact, this query should work with a single-column table! However, in your very first post, you had another syntax:

$query = "INSERT INTO user VALUES (".$login.")";

This one will work with numeric fiels, but not with character fields.

If in doubt, always quote your values; you won't be wrong with that.