checkbox

[NZ_Kiwi]

Hi,

I want to know, on my edit page if a field in my SQL table has a value of 1 it will tick my checkbox if it is zero it will leave it blank

[TheDefender]

You'd have to change it to match your specific details, but it would go something like this:

$fieldfromMySQLTable = 1;
$checkstatus = ($fieldfromMySQLTable == 1) ? " CHECKED" : "";
echo "<input type=\"checkbox\" name=\"checkbox\" value=\"".$test."\"".$checkstatus." />";

[NZ_Kiwi]

Originally posted by TheDefender
You'd have to change it to match your specific details, but it would go something like this:

$fieldfromMySQLTable = 1;
$checkstatus = ($fieldfromMySQLTable == 1) ? "CHECKED" : "";
echo "<input type=\"checkbox\" name=\"checkbox\" value=\"".$test."\"".$checkstatus." />";

[/B]

Ok, but i have a list of areas of my website. If you want to add something to a section you tick the box. now when editing i want it to list all options but if it's already ticked it will show it ticked otherwise show it blank.... will this still work?

[ksandom]

Here's some background reading on checkbox. The main bit of interest to you is that you need to put in CHECKED when declaring the check box if you want it selected.

So imagine you've run a query like

"select name, checked from atable"

and it returned the result resource to $sqlresult.
make some code like:

while ($row=mysql_fetch_row($sqlresult))
{
if ($row[1]==1) // this assumes an int, change appropriatley if needed
{ // 1 = checked
echo "<INPUT TYPE=CHECKBOX NAME='".$row[0]."' CHECKED>".$row[0]."<br>";
}
else
{ // 0 = not checked
echo "<INPUT TYPE=CHECKBOX NAME=".$row[0]." >".$row[0]."<br>";
}
}

I'm on lunch break, so I haven't had a chance to test this, but it should put you on track. 🙂

hth

[TheDefender]

Yeah, it's the same thing as the code I gave you...

// Loop through the results from the DB Query
while($row=mysql_fetch_array) {
  $checkstatus = ($row[1] == 1) ? " CHECKED" : ""; 
  echo "<input type=\"checkbox\" name=\"checkbox\" value=\"".$row[0]."\"".$checkstatus." />";
}

The difference is that I used the ternary to set the CHECKED if needed, and ksandom used an if/else. It's the same thing essentially, but my code is a bit more compact. Either way will work for you.

[NZ_Kiwi]

Originally posted by TheDefender
Yeah, it's the same thing as the code I gave you...

// Loop through the results from the DB Query
while($row=mysql_fetch_array) {
  $checkstatus = ($row[1] == 1) ? "CHECKED" : ""; 
  echo "<input type=\"checkbox\" name=\"checkbox\" value=\"".$row[0]."\"".$checkstatus." />";
}

The difference is that I used the ternary to set the CHECKED if needed, and ksandom used an if/else. It's the same thing essentially, but my code is a bit more compact. Either way will work for you. [/B]

I was thinking of

If $Section1 == 1
{
echo "<input type=\"checkbox\" name=\"checkbox\" value=\"".$row[0]."\"".$checkstatus." />";
else
normal checkbox
}

[TheDefender]

That's exactly what the code I gave you does...

This ternary basically says if $row[1] == 1, then set the value of $chekstatus to CHECKED, otherwise, set $checkstatus to "".

$checkstatus = ($row[1] == 1) ? " CHECKED" : ""; 

Then you just echo your checkbox:

echo "<input type=\"checkbox\" name=\"checkbox\" value=\"".$row[0]."\"".$checkstatus." />"; 

So, if the ternary resulted in $checkstatus to being set to CHECKED, the checkbox will be set. Check if out by setting $row[1] to 1 (hardset it) and then hardset it to something else. You'll see it works.

The ternary is just a condensed If/Else, because as you can see, you only have to echo the checkbox once. If you want a conventional If/Else, then it would look something like this:

If($row[1] == 1) {
  $checkstatus = " CHECKED";
} else {
  $checkstatus = "";
}
echo "<input type=\"checkbox\" name=\"checkbox\" value=\"".$row[0]."\"".$checkstatus." />"; 

The function is exactly the same.

[ksandom]

I just noticed a potential problem, so if you're still having trouble read on...

The original

If($row[1]Â_==Â_1)Â_{ 
Â_Â_$checkstatusÂ_=Â_"CHECKED"; 
}Â_elseÂ_{ 
Â_Â_$checkstatusÂ_=Â_""; 
} 
echoÂ_"<input type=\"checkbox\" name=\"checkbox\" value=\"".$row[0]."\"".$checkstatus." />";

There won't be any space in this between the " and the CHECKED.

A solution:

If($row[1] == 1) { 
  $checkstatus = " CHECKED"; 
} else { 
  $checkstatus = ""; 
} 
echo "<input type=\"checkbox\" name=\"checkbox\" value=\"".$row[0]."\"".$checkstatus." />";

It's pretty minor, but it may cause problems on some browsers.

[TheDefender]

Yes you are right. I apologize that I missed that.

For anyone who prefers to use the ternary, it would look more like this then:

$checkstatus = ($row[1] == 1) ? " CHECKED" : "";

[Bunkermaster]

Originally posted by TheDefender
You'd have to change it to match your specific details, but it would go something like this:

$fieldfromMySQLTable = 1;
$checkstatus = ($fieldfromMySQLTable == 1) ? "CHECKED" : "";
echo "<input type=\"checkbox\" name=\"checkbox\" value=\"".$test."\"".$checkstatus." />";

[/B]

Use of ternary operator is a no no for maintainability.

	// returns 1 if checkbox is on 0 if not
	function checkedOrNot( $value ){
		if( $value == 1 ){
			return " CHECKED";
		} else {
			return "";
		}
	}

Here is what I use. Just call the fuction in your HTML. Notice the space before the CHECKED (missing in quoted code which would result in an HTML parsing error and not being checked on some browsers)

[TheDefender]

Hey bunkermaster, can you expand on this statement for me please? I am curious to know what you mean by this...

"Use of ternary operator is a no no for maintainability."

I am not certain there really is any "maintainability" to this, unless I am just misunderstanding exactly what you mean... (which is the case I think)

[Bunkermaster]

OK, here it is.
There are rules established by some software QA leaders after learning the many errors and booboos made in software development. More than 50% of the development time of any software will be spent on maintaining its code. This demands a maintainability focus from day one on your development.

One of the very first rules is:
Do not use ternary operators

It is a known source of errors and misunderstanding (even when commented). The more you encapsulate the ternaries the worse it is.

Keep you code simple, factorize it when you are tempted to copy paste and the world will be yours.

for more info check McCabe, Rational, Compuware and Parasoft on the web. There are some interesting white papers about code complexity and maintainability.

And YES I am a QA monkey 😃

[TheDefender]

Thanks for your input bunkermaster... I appreciate you taking the time to explain your input...

[Bunkermaster]

lol the paranoid side of me tells me you disagree :rolleyes:

[TheDefender]

No, not at all. I am open to input, and given that you work in the QA side of things, I accept what you are saying. I have never really thought about it from your side of the coin.

Sure I see ternaries as a simplified thing, and I don't give out my own production code, so I am the only one who does anything with it. Also, I am very anal-retentive when it comes to thorough testing, so my maintenance is probably less than 50%, BUT I can definitely see your point.

Will I change how I do things? Not sure yet. Obviously, I will research this more, but you have given me a good bit of info to think about.

I am always open to constructive criticism, and never take it personally. I truly am thankful for you giving me your time like that.

[Bunkermaster]

then you should try to read the 'coding best practices' 🙂

http://www.google.com/search?q=coding+best+practices

[notice the 4th link is to PHP builder 😃]

Some of the stuff you will find is pretty uninteresting but you can find some really well written papers about specific aspects such as code complexity evaluation and coding hints (never copy paste always factorise is one of them) and common mistakes.
Sometimes it's an eye opener and it saves a lot of time. I also am a developer (I quit the QA side a few years ago to start having fun making my own bugs :glare: )

[NZ_Kiwi]

Originally posted by TheDefender
That's exactly what the code I gave you does...

This ternary basically says if $row[1] == 1, then set the value of $chekstatus to CHECKED, otherwise, set $checkstatus to "".

$checkstatus = ($row[1] == 1) ? " CHECKED" : ""; 

Then you just echo your checkbox:

echo "<input type=\"checkbox\" name=\"checkbox\" value=\"".$row[0]."\"".$checkstatus." />"; 

So, if the ternary resulted in $checkstatus to being set to CHECKED, the checkbox will be set. Check if out by setting $row[1] to 1 (hardset it) and then hardset it to something else. You'll see it works.

The ternary is just a condensed If/Else, because as you can see, you only have to echo the checkbox once. If you want a conventional If/Else, then it would look something like this:

If($row[1] == 1) {
  $checkstatus = " CHECKED";
} else {
  $checkstatus = "";
}
echo "<input type=\"checkbox\" name=\"checkbox\" value=\"".$row[0]."\"".$checkstatus." />"; 

The function is exactly the same. [/B]

Sorry I worked that out after but didn't have time to reply last night. The problem I'm facing is that all my check boxes are rows in my tables, say box1 box2 box3... how do i make these different in my script??

If($row[1] == 1) {
  $checkstatus = " CHECKED";
} else {
  $checkstatus = "";
}
echo "<input type=\"checkbox\" name=\"checkbox\" value=\"".$row[0]."\"".$checkstatus." />";