[Resolved] How can I improve this...

m_tCh

Hi,
This is the first searching script that I have written that works. Everytime I try to get more complicated, it doesn't work. Right now it just searches DESIGNER1 for the name typed in by the user. I want it to search through DESIGNER1, DESIGNER2,DESIGNER3, and DESIGNER4. How do I do that?
Thanks!

<%

$search=$_POST["search"];

$result = mysql_query("SELECT * FROM PROJECT_LIST WHERE DESIGNER1 LIKE '%$search%'");

while($r=mysql_fetch_array($result))
{
$xsel_record=$r["ID"];
$xproject_name=$r["PROJECT_NAME"];
$xcategory=$r["CATEGORY"];
$xcustomer=$r["CUSTOMER"];
$xrequest_date=$r["REQUST_DATE"];
$xresponse_date=$r["RESPONSE_DATE"];
$xresponder=$r["RESPONDER"];
$xscope=$r["SCOPE"];
$xsupport=$r["SUPPORT"];
$xrequestor=$r["REQUESTOR"];
$xdev=$r["REQ_DELIVERY_DATE"];
$xplanned_start=$r["PLANNED_START"];
$xactual_start=$r["ACTUAL_START"];
$xplanned_complete=$r["PLANNED_COMPLETE"];
$xactual_complete=$r["ACTUAL_COMPLETE"];
$xdesigner1=$r["DESIGNER1"];
$xdesigner2=$r["DESIGNER2"];
$xdesigner3=$r["DESIGNER3"];
$xdesigner4=$r["DESGINER4"];
$xstatus=$r["STATUS"];
$xest=$r["DEVEL_EST"];

	$bgcolor = switchBG($bgcolor);

%>
<tr valign="top" class="ro">
<td align="left" class="listdata style2 style12" <%=$bgcolor%>>Name:</td>
<td width="422" class="listdata" <%=$bgcolor%>><a href="whiteboard_showmodrecord.php?sel_record=<%=$xsel_record%>"><%=$xproject_name%></a></td>
<td width="44" class="listdata" <%=$bgcolor%>>Status:</td>
<td width="82" class="listdata" <%=$bgcolor%>><%=$xcategory%></td>
<td width="61" class="listdata" <%=$bgcolor%>>Customer:</td>
<td width="77" class="listdata" <%=$bgcolor%>><%=$xcustomer%></td>
<td width="43" class="listdata" <%=$bgcolor%>>Health:</td>
<td width="44" class="listdata" <%=$bgcolor%>><%=$xstatus%></td>
</tr>
<tr valign="top" class="ro">
<td align="left" class="listdata style2 style12" <%=$bgcolor%>>Dates:</td>
<td colspan="7" class="listdata" <%=$bgcolor%>><table width="763" border="0">
<tr class="bt">
<td width="25" bgcolor="#FF9900">Req:</td>
<td width="81"><%=$xrequest_date%></td>
<td width="32" bgcolor="#FF9900">Resp:</td>
<td width="73"><%=$xresponse_date%></td>
<td width="42" bgcolor="#FF9900">P.Start:</td>
<td width="88"> <%=$xactual_start%></td>
<td width="42" bgcolor="#FF9900">A.Start:</td>
<td width="86"> <%=$xplanned_complete%></td>
<td width="47" bgcolor="#FF9900">P.Comp:</td>
<td width="84"><%=$xactual_complete%></td>
<td width="39" bgcolor="#FF9900">A.Comp:</td>
<td width="74"> <%=$xactual_complete%></td>
</tr>
</table></td>
</tr>
<tr valign="top" class="ro">
<td align="left" class="listdata style2 style12" <%=$bgcolor%>> </td>
<td colspan="7" class="listdata" <%=$bgcolor%>><table width="760" border="0">
<tr class="bt">
<td width="92">Requested By: </td>
<td width="125"> <%=$xdev%></td>
<td width="69">Requestor:</td>
<td width="193"><%=$xrequestor%></td>
<td width="69">Responder:</td>
<td width="165"><%=$xresponder%></td>
<td width="10"> </td>
<td width="12"> </td>

              </tr>
            </table></td>
          </tr>
          <tr valign="top" class="ro">
            <td align="left" class="listdata style2 style12" <%=$bgcolor%>>&nbsp;</td>
            <td colspan="7" class="listdata" <%=$bgcolor%>><table width="760" border="0">
              <tr class="bt">
                <td width="84"><span class="listlabel"><b class="bt">Dev. Estimate:</b></span></td>
                <td width="83"><span class="style2 style12"><%=$xest%></span></td>
                <td width="65"><span class="listlabel"><b class="bt">Support ?:</b></span></td>
                <td width="24"><span class="style2 style12"><%=$xsupport%></span></td>

                <td width="100">Team Members: </td>
                <td width="92" bgcolor="#FF9900"><span class="style2 style12"><%=$xdesigner1%></span></td>
                <td width="92" bgcolor="#FF9900"><span class="style2 style12"><%=$xdesigner2%></span></td>
                <td width="91" bgcolor="#FF9900"><span class="style2 style12"><%=$xdesigner3%></span></td>
                <td width="91" bgcolor="#FF9900"><span class="style2 style12"><%=$xdesigner4%></span></td>
              </tr>
            </table></td>
          </tr>
          <tr valign="top" class="ro">
            <td width="36" align="left" class="listdata style2 style12" <%=$bgcolor%>><span class="listlabel"><b class="bt">Scope:</b></span></td>
            <td colspan="7" class="listdata" <%=$bgcolor%>><span class="style2 style12"><%=$xscope%></span></td>
          </tr>
          <%

}

Tracer

3 things....

First try to use <?PHP and ?> instead of the <% %> ....

Second... You don't have to re-assign all those vars... you can do this

while ($row=mysql_fetch_array($result))
{  //Begin While Loop
echo "<tr><td>$row[XXX]</td></tr>";
}  //End While Loop

Third... Comments Are your friends

m_tCh

ok cool thanks .. but how to i search those four categories instead of just the one I currently have it searching?

Tracer

simple....

$result = mysql_query("SELECT * FROM PROJECT_LIST WHERE DESIGNER1 LIKE '%$search%' OR DESIGNER2 LIKE '%$search%' ");


$result = mysql_query("SELECT * FROM PROJECT_LIST WHERE DESIGNER1 LIKE '%$search%' AND DESIGNER2 LIKE '%$search%' ");

Not sure which logic you were looking for

m_tCh

Thank you!