[Resolved] check box issue

timmybuck

hi guys,

just a little problem i have a form with a text field and a check box and one submit button. when the text field gets submitted the time and date are inserted in to the date column. however when the check box is checked a time and date should also be inserted in to the compdate column but it doesnt on the table that i display on the webpage however it does in the database. in the tabel that is displayed the date gets put in to the date column but it should go in to the compdate column.

i know thsi is happening becuase when submit is pressed the first insert is inot the date column and not the compdate.

but can anyone help me fix it

here is my code

</head>
<body>
<?php
require('dbconnect.php');

set_time_limit(0);

$jobId=$_GET['jobId'];

$sql = "select jobId, email, room, computers, description, date FROM requests_table

WHERE requests_table.jobId='$jobId'";

$result = mysql_query($sql);
//echo mysql_error() ;
echo "<table width=\"100%\">\n";

//echo "<table>\n";

echo " <tr>\n";

echo " <th align=\"left\"><b>JobID</b></th>\n";

echo " <th align=\"left\"><b>Email</b></th>\n";

echo " <th align=\"left\"><b>Room</b></th>\n";

echo " <th align=\"left\"><b>Computers</b></th>\n";

echo " <th align=\"left\" ><b>Description</b></th>\n";
echo " <th align=\"left\"><b>Date&time</b></th>\n";

echo " </tr>\n";

while ($row = mysql_fetch_array($result)) {

echo '<td>'.$row['jobId'].'</td>'; 
echo '<td >'.$row['email'].'</td>'; 
echo '<td>'.$row['room'].'</td>'; 
echo ' <td>'.$row['computers'].'</td>'."\n";   
echo ' <td>'.$row['description'].'</td>'."\n"; 
echo ' <td>'.$row['date'].'</td>'."\n"; 
echo  '</tr>'."\n";    
echo '</table>';
} 
echo '<hr>';

?>
<br>
<?php
$color[0] = "FCFCFC";

$color[1] = " 34ADE5 ";

$jobId=$GET['jobId'];
$action_taken=$GET['action_taken'];
$Tech_initals=$_GET['Tech_intials'];

if($_POST["Submit1"]) {

$action_taken = addslashes($POST['action_taken']);
$Tech_initals = addslashes($POST['Tech_initals']);

$result = mysql_query("INSERT INTO tech_table (jobId, Tech_initals, action_taken, date)
VALUES ('$jobId', '$Tech_initals', '$action_taken', NOW())") or die("Unable to insert record: " . mysql_error());

}
//$sql = "SELECT jobId, Tech_initals, action_taken, date FROM tech_table ";
$sql = "SELECT jobId, Tech_initals, action_taken, date FROM tech_table WHERE jobId='".$_GET['jobId']."'";
$result = mysql_query($sql);

echo "<H1><b>Job History</b></H1>";
echo "<table>\n";
echo " <tr>\n";

echo " <th><b>JobID</b></th>\n";

echo " <th><b>Tech Initals</b></th>\n";
echo " <th><b>Action taken</b></th>\n";

echo " <th><b>Date</b></th>\n";

echo " <th><b>Status of Job</b></th>\n";
echo " <th><b>Date of completion</b></th>\n";
echo " </tr>\n";

while ($row = mysql_fetch_array($result)) {

//print_r($result) ;
// echo mysql_error() ;
$a = ($a+1)%2;

echo '<tr bgcolor='.$color[$a] . ">\n";

echo '<td>'.$row['jobId'].'</td>';
echo ' <td>'.$row['Tech_initals'].'</td>'."\n";

echo ' <td>'.$row['action_taken'].'</td>'."\n";

echo ' <td>'.$row['date'].'</td>'."\n";
echo ' <td>'.$row['status_of_job'].'</td>'."\n";
echo ' <td>'.$row['compdate'].'</td>'."\n";
echo '</tr>'."\n";

//echo '</table>';
}

?>
</table>
<br>
<?php
echo '<hr>';
?>
<br>
<p>  </p>
<form name="details" method="post" action= "<? echo $_SERVER['PHP_SELF'] . "?jobId=" . $jobId; ?>">
<table width="791" height="160" border="0">
<tr>
<th width="61" scope="row">TechId</th>
<td width="245"><strong>Action taken </strong></td>
<td width="116"><strong>Status of job </strong></td>
<td width="120"> </td>
<td width="126"> </td>
<td width="97"> </td>
</tr>
<tr>
<th scope="row"><input name="Tech_initals" type="text" size="2" maxlength="2"></th>
<td><textarea name="action_taken" cols="30" rows="3"></textarea></td>
<td><input type="checkbox" name="comp" value="1"></td>
<td> </td>
<td> </td>
<td> </td>
</tr>

<?PHP

if(isset($GET['comp'])){
//if(isset($REQUEST['comp']?1:0😉) {
$comp=$_GET['comp'];

mysql_query("INSERT INTO tech_table (status_of_job, compdate)
VALUES ('$comp', NOW())") or die("Unable to insert record: " . mysql_error());
}

<tr>
  <th scope="row">&nbsp;</th>
  <td><input type="submit" name="Submit1" value="Submit"></td>
  <td>&nbsp;</td>
  <td>&nbsp;</td>
  <td>&nbsp;</td>
  <td>&nbsp;</td>
</tr>
<tr>
  <th scope="row">&nbsp;</th>
  <td>&nbsp;</td>
  <td>&nbsp;</td>
  <td>&nbsp;</td>
  <td>&nbsp;</td>
  <td>&nbsp;</td>
</tr>

</table>
</form>

zhabala

As you can see, the second INSERT stament is executed after the display on web page is already done so it can't be displayed (but you can move it to section before selecting data for display), but I think that it is not doing what you thought it will be.

probably it should look something like that:


if(isset($_GET['comp'])){ 
    $sql_statement = "INSERT INTO tech_table (jobId, Tech_initals, action_taken, date,status_of_job, compdate) 
VALUES ('$jobId', '$Tech_initals', '$action_taken', NOW(),'$comp', NOW())";
} else {
    $sql_statement = "INSERT INTO tech_table (jobId, Tech_initals, action_taken, date) 
VALUES ('$jobId', '$Tech_initals', '$action_taken', NOW())";
}

$result = mysql_query($sql_statement) || die ('INSERT FAILED');

$sql = "SELECT jobId, Tech_initals, action_taken, date, status_of_job, compdate FROM tech_table WHERE jobId='".$_GET['jobId']."'"; 
$result = mysql_query($sql);

Or you want something else and you should use UPDATE statements.

timmybuck

Hi zhabala,

Thanks a lot, it seems you have come up with a good idea. Do u think you could help me a little more and show me how your would inlcude it in my code. Im not sure how to without messing something.

thanks

zhabala

Now I found, that you really want to insert two records in the DB so the code should look exactly like this:

<html> 
<head> 


</head> 
<body> 
<?php 
require('dbconnect.php'); 

set_time_limit(0); 

$jobId=$_GET['jobId']; 



$sql = "select jobId, email, room, computers, description, date FROM requests_table 
WHERE requests_table.jobId='$jobId'"; 


$result = mysql_query($sql); 
//echo mysql_error() ; 
echo "<table width=\"100%\">\n"; 
//echo "<table>\n"; 
echo " <tr>\n"; 
echo " <th align=\"left\"><b>JobID</b></th>\n"; 
echo " <th align=\"left\"><b>Email</b></th>\n"; 
echo " <th align=\"left\"><b>Room</b></th>\n"; 
echo " <th align=\"left\"><b>Computers</b></th>\n"; 
echo " <th align=\"left\" ><b>Description</b></th>\n"; 
echo " <th align=\"left\"><b>Date&time</b></th>\n"; 
echo " </tr>\n"; 

while ($row = mysql_fetch_array($result)) { 

echo '<td>'.$row['jobId'].'</td>'; 
echo '<td >'.$row['email'].'</td>'; 
echo '<td>'.$row['room'].'</td>'; 
echo ' <td>'.$row['computers'].'</td>'."\n"; 
echo ' <td>'.$row['description'].'</td>'."\n"; 
echo ' <td>'.$row['date'].'</td>'."\n"; 
echo '</tr>'."\n"; 
echo '</table>'; 
} 
echo '<hr>'; 
?> 
<br> 
<?php 
$color[0] = "FCFCFC"; 
$color[1] = " 34ADE5 "; 

$jobId=$_GET['jobId']; 
$action_taken=$_GET['action_taken']; 
$Tech_initals=$_GET['Tech_intials']; 


if($_POST["Submit1"]) { 

$action_taken = addslashes($_POST['action_taken']); 
$Tech_initals = addslashes($_POST['Tech_initals']); 


$result = mysql_query("INSERT INTO tech_table (jobId, Tech_initals, action_taken, date) 
VALUES ('$jobId', '$Tech_initals', '$action_taken', NOW())") or die("Unable to insert record: " . mysql_error()); 


} 


if(isset($_POST['comp'])){ 
//if(isset($_REQUEST['comp']?1:0) { 
$comp=$_GET['comp']; 

mysql_query("INSERT INTO tech_table (status_of_job, compdate) 
VALUES ('$comp', NOW())") or die("Unable to insert record: " . mysql_error()); 
} 

//$sql = "SELECT jobId, Tech_initals, action_taken, date FROM tech_table "; 
$sql = "SELECT jobId, Tech_initals, action_taken, date, status_of_job, compdate FROM tech_table WHERE jobId='".$_GET['jobId']."'"; 
$result = mysql_query($sql); 



echo "<H1><b>Job History</b></H1>"; 
echo "<table>\n"; 
echo " <tr>\n"; 
echo " <th><b>JobID</b></th>\n"; 
echo " <th><b>Tech Initals</b></th>\n"; 
echo " <th><b>Action taken</b></th>\n"; 
echo " <th><b>Date</b></th>\n"; 
echo " <th><b>Status of Job</b></th>\n"; 
echo " <th><b>Date of completion</b></th>\n"; 
echo " </tr>\n"; 

while ($row = mysql_fetch_array($result)) { 
//print_r($result) ; 
// echo mysql_error() ; 
$a = ($a+1)%2; 
echo '<tr bgcolor='.$color[$a] . ">\n"; 
echo '<td>'.$row['jobId'].'</td>'; 
echo ' <td>'.$row['Tech_initals'].'</td>'."\n"; 
echo ' <td>'.$row['action_taken'].'</td>'."\n"; 
echo ' <td>'.$row['date'].'</td>'."\n"; 
echo ' <td>'.$row['status_of_job'].'</td>'."\n"; 
echo ' <td>'.$row['compdate'].'</td>'."\n"; 
echo '</tr>'."\n"; 
//echo '</table>'; 
} 

?> 
</table> 
<br> 
<?php 
echo '<hr>'; 
?> 
<br> 
<p>  </p> 
<form name="details" method="post" action= "<? echo $_SERVER['PHP_SELF'] . "?jobId=" . $jobId; ?>"> 
<table width="791" height="160" border="0"> 
<tr> 
<th width="61" scope="row">TechId</th> 
<td width="245"><strong>Action taken </strong></td> 
<td width="116"><strong>Status of job </strong></td> 
<td width="120"> </td> 
<td width="126"> </td> 
<td width="97"> </td> 
</tr> 
<tr> 
<th scope="row"><input name="Tech_initals" type="text" size="2" maxlength="2"></th> 
<td><textarea name="action_taken" cols="30" rows="3"></textarea></td> 
<td><input type="checkbox" name="comp" value="1"></td> 
<td> </td> 
<td> </td> 
<td> </td> 
</tr> 

<tr> 
<th scope="row"> </th> 
<td><input type="submit" name="Submit1" value="Submit"></td> 
<td> </td> 
<td> </td> 
<td> </td> 
<td> </td> 
</tr> 
<tr> 
<th scope="row"> </th> 
<td> </td> 
<td> </td> 
<td> </td> 
<td> </td> 
<td> </td> 
</tr> 
</table> 
</form>

timmybuck

ok Its still not quite working, the second date is being displayed in the correct filed in the database under compdate but its not showing up under the correct field on the table on the webpage. It seems as though only the first dates is appearing in the Date column.

this is the latest code, sorry for troubling u

</head>
<body>
<?php

require('dbconnect.php');

set_time_limit(0);

$jobId=$_GET['jobId'];

$sql = "select jobId, email, room, computers, description, date FROM requests_table

WHERE requests_table.jobId='$jobId'";

$result = mysql_query($sql);

//echo mysql_error() ;
echo "<table width=\"100%\">\n";

//echo "<table>\n";
echo " <tr>\n";

echo " <th align=\"left\"><b>JobID</b></th>\n";

echo " <th align=\"left\"><b>Email</b></th>\n";

echo " <th align=\"left\"><b>Room</b></th>\n";

echo " <th align=\"left\"><b>Computers</b></th>\n";

echo " <th align=\"left\" ><b>Description</b></th>\n";

echo " <th align=\"left\"><b>Date&time</b></th>\n";

echo " </tr>\n";

while ($row = mysql_fetch_array($result)) {

echo '<td>'.$row['jobId'].'</td>';

echo '<td >'.$row['email'].'</td>';

echo '<td>'.$row['room'].'</td>';

echo ' <td>'.$row['computers'].'</td>'."\n";

echo ' <td>'.$row['description'].'</td>'."\n";

echo ' <td>'.$row['date'].'</td>'."\n";

echo '</tr>'."\n";

echo '</table>';

}

echo '<hr>';

?>

<br>
<?php

$color[0] = "FCFCFC";

$color[1] = " 34ADE5 ";

$jobId=$GET['jobId'];

$action_taken=$GET['action_taken'];

$Tech_initals=$_GET['Tech_intials'];

if($_POST["Submit1"]) {

$action_taken = addslashes($POST['action_taken']);

$Tech_initals = addslashes($POST['Tech_initals']);

}

if(isset($POST['comp'])){

//if(isset($REQUEST['comp']?1:0) {
$comp=$_GET['comp'];

mysql_query("INSERT INTO tech_table (status_of_job, compdate)
VALUES ('$comp', NOW())") or die("Unable to insert record: " . mysql_error());

}

//$sql = "SELECT jobId, Tech_initals, action_taken, date FROM tech_table ";
$sql = "SELECT jobId, Tech_initals, action_taken, date, status_of_job, compdate FROM tech_table WHERE jobId='".$_GET['jobId']."'";

$result = mysql_query($sql);

echo "<H1><b>Job History</b></H1>";

echo "<table>\n";

echo " <tr>\n";

echo " <th><b>JobID</b></th>\n";

echo " <th><b>Tech Initals</b></th>\n";

echo " <th><b>Action taken</b></th>\n";

echo " <th><b>Date</b></th>\n";

echo " <th><b>Status of Job</b></th>\n";

echo " <th><b>Date of completion</b></th>\n";

echo " </tr>\n";

while ($row = mysql_fetch_array($result)) {

//print_r($result) ;
// echo mysql_error() ;
$a = ($a+1)%2;

echo '<tr bgcolor='.$color[$a] . ">\n";

echo '<td>'.$row['jobId'].'</td>';

echo ' <td>'.$row['Tech_initals'].'</td>'."\n";

echo ' <td>'.$row['action_taken'].'</td>'."\n";

echo ' <td>'.$row['date'].'</td>'."\n";

echo ' <td>'.$row['status_of_job'].'</td>'."\n";

echo ' <td>'.$row['compdate'].'</td>'."\n";

echo '</tr>'."\n";

//echo '</table>';
}

?>

</table>
<br>
<?php

echo '<hr>';

?>

<br>
<p> </p>
<form name="details" method="post" action= "<? echo $_SERVER['PHP_SELF'] . "?jobId=" . $jobId; ?>">
<table width="791" height="160" border="0">
<tr>
<th width="61" scope="row">TechId</th>
<td width="245"><strong>Action taken </strong></td>
<td width="116"><strong>Status of job </strong></td>
<td width="120"> </td>
<td width="126"> </td>
<td width="97"> </td>
</tr>
<tr>
<th scope="row"><input name="Tech_initals" type="text" size="2" maxlength="2"></th>
<td><textarea name="action_taken" cols="30" rows="3"></textarea></td>
<td><input type="checkbox" name="comp" value="1"></td>
<td> </td>
<td> </td>
<td> </td>
</tr>

zhabala

Now I can see, that in the second INSERT statement there is no jobid inserted, so you have to change the second INSERT stmt to this

INSERT INTO tech_table (jobId, Tech_initals, date, status_of_job, compdate) 
VALUES ('$jobId', '$Tech_initals',Now(), '$comp', NOW())

It is quite hard to help you when I can't test it now, I am doing that only by heart

timmybuck

ok i tried what you said, but didnt work.

here is the link

http://81.106.219.191/fmp/details.php?jobId=4

if u check the check box then press submit, the date should appear in the 'Date of completion' not the Date column.

The date should only appear in the date column when the 'action taken' text area has been submitted. This bit works.

thanks for your help

zhabala

So, how it should really be ? You have three fields on the form and now I am not sure how many record should be inserted after the form is submitted ?

Now I think that only one and then my former solution is the right one, here is the code:

<html> 
<head> 


</head> 
<body> 
<?php 
require('dbconnect.php'); 

set_time_limit(0); 

$jobId=$_GET['jobId']; 



$sql = "select jobId, email, room, computers, description, date FROM requests_table 
WHERE requests_table.jobId='$jobId'"; 


$result = mysql_query($sql); 
//echo mysql_error() ; 
echo "<table width=\"100%\">\n"; 
//echo "<table>\n"; 
echo " <tr>\n"; 
echo " <th align=\"left\"><b>JobID</b></th>\n"; 
echo " <th align=\"left\"><b>Email</b></th>\n"; 
echo " <th align=\"left\"><b>Room</b></th>\n"; 
echo " <th align=\"left\"><b>Computers</b></th>\n"; 
echo " <th align=\"left\" ><b>Description</b></th>\n"; 
echo " <th align=\"left\"><b>Date&time</b></th>\n"; 
echo " </tr>\n"; 

while ($row = mysql_fetch_array($result)) { 

echo '<td>'.$row['jobId'].'</td>'; 
echo '<td >'.$row['email'].'</td>'; 
echo '<td>'.$row['room'].'</td>'; 
echo ' <td>'.$row['computers'].'</td>'."\n"; 
echo ' <td>'.$row['description'].'</td>'."\n"; 
echo ' <td>'.$row['date'].'</td>'."\n"; 
echo '</tr>'."\n"; 
echo '</table>'; 
} 
echo '<hr>'; 
?> 
<br> 
<?php 
$color[0] = "FCFCFC"; 
$color[1] = " 34ADE5 "; 

$jobId=$_GET['jobId']; 
$action_taken=$_GET['action_taken']; 
$Tech_initals=$_GET['Tech_intials']; 


if($_POST["Submit1"]) { 

$action_taken = addslashes($_POST['action_taken']); 
$Tech_initals = addslashes($_POST['Tech_initals']); 


if(isset($_POST['comp'])){  

    $comp = $_POST['comp'];
    $sql_statement = "INSERT INTO tech_table (jobId, Tech_initals, action_taken, date,status_of_job, compdate) 
VALUES ('$jobId', '$Tech_initals', '$action_taken', NOW(),'$comp', NOW())"; 
} else { 
    $sql_statement = "INSERT INTO tech_table (jobId, Tech_initals, action_taken, date) 
VALUES ('$jobId', '$Tech_initals', '$action_taken', NOW())"; 
}

$result = mysql_query($sql_statement) or die("Unable to insert record: " . mysql_error()); 


} 


//$sql = "SELECT jobId, Tech_initals, action_taken, date FROM tech_table "; 
$sql = "SELECT jobId, Tech_initals, action_taken, date, status_of_job, compdate FROM tech_table WHERE jobId='".$_GET['jobId']."'"; 
$result = mysql_query($sql); 



echo "<H1><b>Job History</b></H1>"; 
echo "<table>\n"; 
echo " <tr>\n"; 
echo " <th><b>JobID</b></th>\n"; 
echo " <th><b>Tech Initals</b></th>\n"; 
echo " <th><b>Action taken</b></th>\n"; 
echo " <th><b>Date</b></th>\n"; 
echo " <th><b>Status of Job</b></th>\n"; 
echo " <th><b>Date of completion</b></th>\n"; 
echo " </tr>\n"; 

while ($row = mysql_fetch_array($result)) { 
//print_r($result) ; 
// echo mysql_error() ; 
$a = ($a+1)%2; 
echo '<tr bgcolor='.$color[$a] . ">\n"; 
echo '<td>'.$row['jobId'].'</td>'; 
echo ' <td>'.$row['Tech_initals'].'</td>'."\n"; 
echo ' <td>'.$row['action_taken'].'</td>'."\n"; 
echo ' <td>'.$row['date'].'</td>'."\n"; 
echo ' <td>'.$row['status_of_job'].'</td>'."\n"; 
echo ' <td>'.$row['compdate'].'</td>'."\n"; 
echo '</tr>'."\n"; 
//echo '</table>'; 
} 

?> 
</table> 
<br> 
<?php 
echo '<hr>'; 
?> 
<br> 
<p> </p> 
<form name="details" method="post" action= "<? echo $_SERVER['PHP_SELF'] . "?jobId=" . $jobId; ?>"> 
<table width="791" height="160" border="0"> 
<tr> 
<th width="61" scope="row">TechId</th> 
<td width="245"><strong>Action taken </strong></td> 
<td width="116"><strong>Status of job </strong></td> 
<td width="120"> </td> 
<td width="126"> </td> 
<td width="97"> </td> 
</tr> 
<tr> 
<th scope="row"><input name="Tech_initals" type="text" size="2" maxlength="2"></th> 
<td><textarea name="action_taken" cols="30" rows="3"></textarea></td> 
<td><input type="checkbox" name="comp" value="1"></td> 
<td> </td> 
<td> </td> 
<td> </td> 
</tr> 

<tr> 
<th scope="row"> </th> 
<td><input type="submit" name="Submit1" value="Submit"></td> 
<td> </td> 
<td> </td> 
<td> </td> 
<td> </td> 
</tr> 
<tr> 
<th scope="row"> </th> 
<td> </td> 
<td> </td> 
<td> </td> 
<td> </td> 
<td> </td> 
</tr> 
</table> 
</form>

timmybuck

yay,

Thank you very much, it works now, i can see the date the date of completion box, but the date also appears in the other date column, its not a major problem, but am not sure myself what would be good.lol

Take a look

http://81.106.219.191/fmp/details.php?jobId=4

also i wonder if status of job could say 'complete' instead of '1' im not sure myself either, whats your opinion

thanks

zhabala

Frankly speaking it is hard to say, because you are inserting current time into that date fields and it probably might not be the date where the job was finished or when the action was taken.

So in case I would be the author of the script and DB structure I would use one column which would contain the information about current time like you have it. This columnt would mean the date and time when the record was stored into DB. And other column (for example action_date) where the user can post any date, and it would mean really the date and maybe the time, when the action was actually take or when the job was completed.

Zdenek

zhabala

And for that 'complete' status you can change this row

echo ' <td>'.$row['status_of_job'].'</td>'."\n";

to this:

echo ' <td>'.($row['status_of_job'] == 1 ? 'Complete' : '' ).'</td>'."\n";

timmybuck

thanks for your valuable feedback, it always helps when i hear what other people have to say becuase sometimes u can miss things.

Juts a little background for what im doing, im developing a help desksystem, so users report faults, then the technicans fix the faults but there manager wants to see how long they take, thats why i have dates and times. when they complete the job or when they have taken action they submit the form. Hopefully it will give a rough idea of times and dates so they can create reports.

My next step is once a job is complete that it dissapears from this page http://81.106.219.191/fmp/tech.php but still remains in the database. only jobs that are not complete should be on here.

what do u think

any advice on code, you seem to very good at understanding my problem.

zhabala

There should be some switch where the user who displays that page can decide whether he wants to see all issues ( complete and incomplete ) or only complete. And then there is only small part in where clause for the select statement, where you have to play with that.

Because when the manager will want to see how some issue was solved then there have to be the possibility, how to do that. So it will lead probably to some search mechanism, to be able to find issue from one user or from one e-mail or issues which were solved more after than 5 or 24 hours or something like that.

I understand the problem with times, and as I already said I would use two columns, one for current date and time .... it would mean that in that particular time the record was added to DB. And second for so called user time or action time and it would be the time when the action was actually taken.

But ... You should know or your boss should know, what you are expecting from that application.

Bye Z.

timmybuck

ok thanks

by the way i have implemented the date anbd time stamp for thwne the job gets submitted by the user. I agree about the search feature and switching between views for complete and incomplete jobs.

the search feature is something i have been thinking about
it could serve as a knowledgebase

thanks again

timmybuck

ok thanks

by the way i have implemented the date anbd time stamp for thwne the job gets submitted by the user. I agree about the search feature and switching between views for complete and incomplete jobs.

the search feature is something i have been thinking about
it could serve as a knowledgebase

thanks again

timmybuck

anyone know of any good full text search tutorials