Input Field Question

iceman2g

I have a input feild thats populated with a info from db when query is run. In order for it to do this though I need to set the value to that of the query. Doing this doesn't allow me to edit the info though.

What i mean is I can enter whatever info I want in the input field but because it has a value it doesn't update when I run the update query.

Here is code I have.

echo"<table><tr><td bgcolor=\"#6699CC\"><input type=\"textbox\" name=\"option\" value='$option' size=\"50\"></td></tr>
	</table>";

Now when I run the update query it updates the text box with $option. What can i do about this.

planetsim

Can you show us all the code?

iceman2g

Sure thing it's messy though.

echo "<br><table align=\"center\" width=\"85%\" bgcolor=\"#6699CC\" style=border-color:#FF0000 border=\"1\" cellspacing=\"0\" cellpadding=\"0\"><tr>"; 

    echo "<td border=\"0\" style=border-color:#FF0000 valign=\"top\" align=\"center\">"; 

echo "<FORM ENCTYPE=\"multipart/form-data\" ACTION=\"edit_poll2.php\" METHOD=\"POST\">";         

echo"<table align=center valign=\"top\" align=\"center\" border=\"0\"  width=\"100%\" style=border-color:#FF0000 cellspacing=\"0\" cellpadding=\"0\"> 
            <tr><td bgcolor=\"#6699CC\"><b>Poll Question:</b><br><hr color=\"#C00000\"></td></tr></table>"; 
//querying poll question             

$sql_select = mysql_query("SELECT poll_question FROM ".$prefix."store_polls WHERE poll_id='$id'"); 
while ($result = mysql_fetch_array($sql_select)) 
            { 

    $poll_question = $result['poll_question']; 
//see here it where the problem is, once i get it working here i'll make changes to other areas with same problem     

echo"<table> 
<tr><td bgcolor=\"$colour_1\" size=\"50\"><input type=\"textbox\" name=\"question\" value=\"$poll_question\" size=\"50\"></td></tr> 
    </table>"; 
            }
        echo "</td>";   

		echo"<td border=\"0\" style=border-color:#FF0000 valign=\"top\" align=\"center\">";  

echo"<INPUT class=\"submit\" TYPE=\"submit\" NAME=\"submit\" VALUE=\"$la_edit_poll\">";                     

    echo "</td>"; 
echo"<form>"; 
echo"</tr></table>"; 

if ($submit)
if ($question){ 
$return = mysql_query("UPDATE ".$prefix."store_polls SET poll_question='$question' WHERE poll_id='$id'"); 
               }

iceman2g

Anyone this is all that stands in way of me completein this code.

tsinka

Hi,

move the code that checks the data submitted somewhere above the SELECT query so that the update takes place before the select is executed (and use $_POST['variable'] instead of $variable).

<?PHP
// some code
if (isset($_POST['submit']))  {
  if (isset($_POST['question'])) {  

    $return = mysql_query("UPDATE ".$prefix."store_polls SET poll_question='".$_POST['question']."' WHERE poll_id='$id'");  

  }
}
// some other code including the SELECT query

Thomas

iceman2g

Thank you that really helped.

Edit:nevermind thank you.

iceman2g

Ok i've trying to get this to work for my poll_option_text table. Unfortunately it only works to a certain degree.

//query poll options applicable to poll id
$sql_select = mysql_query("SELECT * FROM ".$prefix."store_poll_options WHERE poll_id='$id'");
while ($result = mysql_fetch_array($sql_select))
			{

	$poll_option = $result['poll_option_text'];

echo"<table><tr><td bgcolor=\"#6699CC\"><input type=\"textbox\" name=\"option\" value='$poll_option' size=\"50\"></td></tr>
	 </table>";
			}

What I did with the above query is get all the poll_option_text associated with a given poll. I echo the poll_option_text in the form of a textbox, so that it may be edited to change the poll_option_text.

$sql_select = mysql_query("SELECT * FROM ".$prefix."store_poll_options WHERE poll_id='$id'");
while ($result = mysql_fetch_array($sql_select))
			{
			$option_id = $result['poll_option_id'];

if (isset($_POST['option'])){		  

	$return1 = mysql_query("UPDATE ".$prefix."store_poll_options SET poll_option_text='".$_POST['option']."' WHERE poll_id='$id' AND poll_option_id='$option_id'");
	}
}

Now with this above query I attempt to update the poll_option_text. By using (poll_option_id='$option_id') i'm trying to update the poll_option_text associated with that poll_option_id. Unfortunately it only updates the last row of that particular poll_id, so even if I made a change to the other poll_option_text it doesn't update.

Here's a pic showing what I mean. The circiled area is the only poll_option_text that updates when it's edited.

tsinka

Ok,

try this code:

//query poll options applicable to poll id 
$sql_select = mysql_query("SELECT * FROM ".$prefix."store_poll_options WHERE poll_id='$id'"); 
while ($result = mysql_fetch_array($sql_select)) { 

    $poll_option = $result['poll_option_text']; 
    $option_id = $result['poll_option_id'];

echo <<<EOHTML
<table>
  <tr>
    <td bgcolor="#6699CC">
      <input type="textbox" name="option[$option_id]" value='$poll_option' size="50">
    </td>
  </tr> 
</table>
EOHTML;
}

and

$sql_select = mysql_query("SELECT * FROM ".$prefix."store_poll_options WHERE poll_id='$id'"); 
while ($result = mysql_fetch_array($sql_select)) { 
            $option_id = $result['poll_option_id']; 

if (isset($_POST['option'][$option_id])){           

    $return1 = mysql_query("UPDATE ".$prefix."store_poll_options SET poll_option_text='".$_POST['option'][$option_id]."' WHERE poll_id='$id' AND poll_option_id='$option_id'"); 
    } 
}

In short: Change the textbox input names so that the values are submitted in an array named option with the poll_option_id as array indexes.

Make sure that the line echo <<< EOHTML ends with EOHTML wíthout any trailing whitespaces at the end of the line.

Thomas

iceman2g

Make sure that the line echo <<< EOHTML ends with EOHTML wíthout any trailing whitespaces at the end of the line.

elaborate?

iceman2g

I did without the EOTHML part as i don't know that does.

instead I used this.

//querying poll options			
$sql_select = mysql_query("SELECT * FROM ".$prefix."store_poll_options WHERE poll_id='$id'");
while ($result = mysql_fetch_array($sql_select))
			{

	$poll_option = $result['poll_option_text'];
	$option = $result['poll_option_id'];			
echo"<table><tr><td bgcolor=\"#6699CC\"><input type=\"textbox\" name=\"option[$option]\" value='$poll_option' size=\"50\"></td></tr>
	 </table>";
			}

It got it working as it's suppose to, but it isn't displaying the whole poll_option_text it cuts it short.

tsinka

Hi,

I chose to use heredoc syntax so I didn't need to e.g. escape double quotes.

Since the identifier (EOHTML in this case) must only contain alphanumeric characters or underscores you must make sure that there are no whitespaces after EOHTML since php takes everything after <<< up to the next linebreak as identifier.

Second, there mustn't be any whitespaces after the closing identifier (EOHTML; in this case) for the same reason.

Thomas

iceman2g

Ok well I tryed using the code I used to fix the other problem. But doesn't seem to be having the desired affect.

$sql_select = mysql_query("SELECT * FROM ".$prefix."store_polls ");
while ($result = mysql_fetch_array($sql_select))
		{
		$status = $result['status'];
		$option = $result['poll_id'];
if ($status == 1)
		{ 
$status = "<table><tr><td><img src=\"/images/active.jpg\"></td><td>&nbsp&nbspActive</td></tr></table>"; 
		}
else 
		{ 
$status = "<table><tr><td><img src=\"/images/inactive.jpg\"></td><td>&nbsp&nbspInactive</td></tr></table>"; 
		}						 
		echo"<table border=\"0\" width=\"100%\" style=border-color:#FF0000 cellspacing=\"0\" cellpadding=\"0\">
		<tr><td bgcolor=\"#6699CC\" border=\"0\" height=\"40\" width=\"70%\">$status</td>
			<td bgcolor=\"#6699CC\" border=\"0\" height=\"40\" width=\"30%\">
			<table><tr><td bgcolor=\"#6699CC\"><td><input type=\"radio\" name=\"delete[$option]\" value='1'>no</td>

The above code is being used to get poll_id for each input field.

if (isset($_GET['submit']))  {
	if (isset($_GET['delete'])){            		  

	$return1 = mysql_query("DELETE FROM ".$prefix."store_polls WHERE poll_id='".$_GET['delete']."' ");
	}
}

This is the code at the top of page, that i'm trying to use to delete row from table.

tsinka

Hi,

did you use method="GET" or method="POST" in your form ?

Use $GET or $POST depending on the method.

Change the while loop in the first code to (I shortened it a little bit:

$cnt = 0;
while ($result = mysql_fetch_array($sql_select)) 
{ 
....
....
<table><tr><td bgcolor=\"#6699CC\"><td><input type=\"radio\" name=\"delete[$cnt]\" value='$option'>no</td>
....
  $cnt++;
}

Code:

if (isset($_GET['submit']))  { 
    if (isset($_GET['delete'])){                       

    $return1 = mysql_query("DELETE FROM ".$prefix."store_polls WHERE poll_id IN ('".implode("','",$_GET['delete'])."')"); 
    } 
}

Thomas

tsinka

I'd suggest to use HEREDOC syntax if you have a lot of HTML code to print or to break the php blocks apart an to use

<?=$variable ?> in the HTML code outside the PHP blocks.

Thomas

iceman2g

I'm using GET until i know code works then i'll switch it to POST.

iceman2g

Ok your good at this. Tryed that code and it worked. Got questions now though. Like what's all this about.

IN ('".implode("','",$_GET['delete'])."')");

Same with this why did setting the name to delete[$cnt] work and not delete[$option]

Also did the value of the poll matter at all?

Edit: the I tryed delte[$option] and it still worked as it was suppose to.

tsinka

Hi,

I chose to change the names to make things easier. With the new names you'll get the following array:

delete[0] = poll_id1
delete[1] = poll_id2
.....

The old one:

delete[pollid1] = 1
delete[pollid2] = 1

Ok, after thinking a second time about the code it doesn't matter which way you do it.

The main problem with your code was that you just used the array itself in the query, not the values of the array.

Besides that, you can either loop through the array and execute an update query on each key/value or use IN which is faster (just one query).

The code using the old radio button names would have been:

$delKeys = array_keys($_GET['delete']);

......IN('".implode("','",$delKeys)."')";

So the main difference is that you need one more line of code to get the poll ids if you use the old names.

Thomas

iceman2g

Ok IN part I understand now.

But

 '".implode("','",

What is implode. Never seen it used before.

Also is this totally needed.

"','"

Edit: Tryed it without the

"','"

and it still worked. So what was that bit of code for. Also what exactly is the purpose of

From what i've read it's for a continuation.

tsinka

Hi,

read the manual about implode. It takes the elements of an array and returns a string containing the elements with the glue (',' in this case) in between them.

So the array of the poll ids ($_GET['delete']) will become e.g.

id1','id2','id3','id4

and the IN part of the query:

IN('id1','id2','id3','id4')

In this case you can use just , instead of ',' because the poll ids are numeric values

IN(id1,id2,id3,id4)

But I always prefer to put single quotes around all values in a SQL query, even the numeric ones.

Thomas

tsinka

. is used for string concatenation.

$glue = "-";
$anarray = array("2004","10","15");
$strSomething = "A date: ".implode($glue,$anarray)." something";

Thomas