Update query, WHERE clause

corruption

I'm trying to write a fairly long update query.

I can't get it to update the info because of the syntax error in the WHERE clause.

$sql = "UPDATE brothers SET fname = '$fname', lname = '$lname', aim = '$aim', major = '$major', major2 = '$major2', minor = '$minor', minor2 = '$minor2',
minor3 = '$minor4', email = '$email', number = '$number', pledgeclass = '$pledgeclass', password = '$password', phone = '$phone', address = '$address',
city = '$city', state = '$state', zip = '$zip', birthdate = '$birthdate', bigbrother = '$bigbrother', littlebro = '$littlebro', little2 = '$little2',
little3 = '$little3', little4 = '$little4', status = '$status' WHERE brother_id = "$_SESSION['brother_id'];

drawmack

What is the error & did you try echoing out the query and taking a look at it after it's been parsed by the php interpreter?

corruption

yes, and the error looks like this

Parse error: parse error, unexpected T_VARIABLE in d:\inetpub2\organizations\dsp\includes\newinformation.php on line 70

line 70 of course is the one with the WHERE claus on it.

kawaiiaries

izzit the error occur at the -->

WHERE brother_id = "$_SESSION['brother_id'];

so try to change to -->

WHERE brother_id = '$_SESSION['brother_id']';

corruption

with that statement end i get this error.

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in d:\inetpub2\organizations\dsp\includes\newinformation.php on line 70

the statement reads like this:

$sql = "UPDATE brothers SET fname = '$fname', lname = '$lname', aim = '$aim', major = '$major', major2 = '$major2',  minor = '$minor', minor2 = '$minor2',
minor3 = '$minor4', email = '$email', number = '$number',  pledgeclass = '$pledgeclass', password = '$password', phone = '$phone', address = '$address',
city = '$city', state = '$state', zip = '$zip', birthdate = '$birthdate', bigbrother = '$bigbrother', littlebro = '$littlebro', little2 = '$little2',
little3 = '$little3', little4 = '$little4', status = '$status' WHERE brother_id = '$_SESSION['brother_id']';

in this case the statement never really ends. You have to have the double quotes somewhere.

so i tried this

 WHERE brother_id = '$_SESSION['brother_id']'";

that gives me the same error. I'm not sure what to do about it. Please help me get the syntax straightened out. Or point me to somewhere that may help.

Roger_Ramjet

Echo the query BEFORE you execute mysql_query, then you will see what you are actually sending. My guess is that you are not getting a brother_id.

corruption

i know i'm not getting the brother_id. If i echo brother_id earlier in the script, before the update clause, then it echoes the correct id. I don't know why it doesn't work when I do the where clause.

Roger_Ramjet

If you can echo it elsewhere then try

$bro_id = $_SESSION['brother_id'];
$sql = "UPDATE brothers SET ..... WHERE brother_id = $bro_id";

By the way, is brother_id an integer (autoincrement) or a string?
If it is an int then you do not need the ' ' in your sql, if it is a string then you do need ' ' around $bro_id. Get this wrong and your sql will not work. Setting $bro_id will allow you to test the brother id value is valid before you build your sql and submit it to the db.