Parse error in error handler

Funky_Monk

Hi. I've created a page called error_reporting and including it in each page to trap errors. When I ran a page with the include file I got the error:

Parse error: parse error, unexpected '[', expecting ',' or ';' in /(path to file)/error_reporting.php on line 5

My code is here:

<?php
//create your error handler function
function handler($error_type, $error_message, $error_file, $error_line)
{
global $SERVER['HTTP_HOST'], $SERVER['HTTP_USER_AGENT'], $SERVER['REMOTE_ADDR'], $SERVER['REQUEST_URI'];

 switch($error_type)
 {
      //fatal error
      case E_ERROR:
           $to = "Administrator <webmaster@daycentreconnections.org";

           $subject = "Custom Error Handling";

           $body = "<html>";
           $body .= "<head>";
           $body .= "<title></title>";
           $body .= "</head>";
           $body .= "<body>";
           $body .= "<h1>Fatal Error</h1>";
           $body .= "Error received was a <b>" . $error_type . "</b> error.<br>";
           $body .= "The page that generated the error was: <b>" . $error_file . "</b>";
           $body .= " and was generated on line: <b>" . $error_line . "</b><br>";
           $body .= "The generated error message was:" . $error_message;
           $body .= "</body>";
           $body .= "</html>";

           $headers = "MIME-Version: 1.0\r\n";
           $headers .= "Content-type: text/html; charset=iso-8859-1\r\n";

           $headers .= "From: Apache Error <host@yourdomain.com>\r\n";
           $headers .= "Cc: [email]webmaster@daycentreconnections.org[/email]\r\n";

           mail($to, $subject, $message, $headers);
           die(); //kill the script
           break;
      //warnings
      case E_WARNING:

           $to = "Administrator <webmaster@daycentreconnections.org>";

           $subject = "Custom Error Handling";

           $body = "<html>";
           $body .= "<head>";
           $body .= "<title></title>";
           $body .= "</head>";
           $body .= "<body>";
           $body .= "<h1>Warning</h1>";
           $body .= "Error received was a <b>" . $error_type . "</b>
                 error.<br>";
           $body .= "The page that generated the error was: <b>" .
                $error_file . "</b>";
           $body .= " and was generated on line: <b>" . $error_line .
                "</b><br>";
           $body .= "The generated error message was:" . $error_message;
           $body .= "</body>";
           $body .= "</html>";

           $headers = "MIME-Version: 1.0\r\n";
           $headers .= "Content-type: text/html; charset=iso-8859-1\r\n";

           $headers .= "From: Apache Error <webmaster@daycentreconnections.org>\r\n";
           $headers .= "Cc: [email]webmaster@daycentreconnections.org[/email]\r\n";

           mail($to, $subject, $message, $headers);
           break;
           //script will continue

      //notices
      case E_NOTICE:
           //don't show notice errors
           break;
 }

}
/
set error handling to 0
we will handle all error reporting
only notifying admin on warnings and fatal errors
don't bother with notices as they are trivial errors
really only meant for debugging
/
error_reporting(0);

//set the error handler to be used
set_error_handler("handler");

/
Create the rest of your page here.
We will not be displaying any errors
We will be e-mailing the admin an error message
Keep in mind that fatal errors will still halt the
execution, but they will still notify the admin
/
?>

I can't see what the problem is. Surely the [ is needed in the code?

drawmack

on line 4 you're globalizing an autoglobal, and on top of that you're attempting to globaliz specific keys. I'm pretty sure you would just gloabalize the entire array, whcih shouldn't need to be globalized anyway. Comment out line 4 and see what happens.

Funky_Monk

Thanx for your quick reply. If I do that I get:

Parse error: parse error, unexpected T_CASE, expecting '{' in /(path to file) /error_reporting.php on line 10

Any other thoughts?

Weedpacket

Originally posted by Funky Monk

Parse error: parse error, unexpected T_CASE, expecting '{' in /(path to file) /error_reporting.php on line 10

Any other thoughts?

Taking the code your originally posted, and removing the offending global line, I saved it into a file test.php and checked its syntax:

[b]php -l test.php[/b]
No syntax errors detected in test.php

Funky_Monk

Hello Weedpacket. Glad you got it to work. Could you possible post the code from your test.php file so I can compare it to mine. I still can't get it to work. I'd appreciate it if you could.

tsinka

Hi Funky Monk,

can you post exactly the code you have so far (copy'n'paste, maybe as attachment). The switch code in the script in your first post looks ok.

Thomas

Funky_Monk

This is the code now:

<?php
//create your error handler function
function handler($error_type, $error_message, $error_file, $error_line)
{

 switch($error_type)
 {
      //fatal error
      case E_ERROR:
           $to = "Administrator <webmaster@daycentreconnections.org";

           $subject = "Custom Error Handling";

           $body = "<html>";
           $body .= "<head>";
           $body .= "<title></title>";
           $body .= "</head>";
           $body .= "<body>";
           $body .= "<h1>Fatal Error</h1>";
           $body .= "Error received was a <b>" . $error_type . "</b> error.<br>";
           $body .= "The page that generated the error was: <b>" . $error_file . "</b>";
           $body .= " and was generated on line: <b>" . $error_line . "</b><br>";
           $body .= "The generated error message was:" . $error_message;
           $body .= "</body>";
           $body .= "</html>";

           $headers = "MIME-Version: 1.0\r\n";
           $headers .= "Content-type: text/html; charset=iso-8859-1\r\n";

           $headers .= "From: Apache Error <host@yourdomain.com>\r\n";
           $headers .= "Cc: [email]webmaster@daycentreconnections.org[/email]\r\n";

           mail($to, $subject, $message, $headers);
           die(); //kill the script
           break;
      //warnings
      case E_WARNING:

           $to = "Administrator <webmaster@daycentreconnections.org>";

           $subject = "Custom Error Handling";

           $body = "<html>";
           $body .= "<head>";
           $body .= "<title></title>";
           $body .= "</head>";
           $body .= "<body>";
           $body .= "<h1>Warning</h1>";
           $body .= "Error received was a <b>" . $error_type . "</b>
                 error.<br>";
           $body .= "The page that generated the error was: <b>" .
                $error_file . "</b>";
           $body .= " and was generated on line: <b>" . $error_line .
                "</b><br>";
           $body .= "The generated error message was:" . $error_message;
           $body .= "</body>";
           $body .= "</html>";

           $headers = "MIME-Version: 1.0\r\n";
           $headers .= "Content-type: text/html; charset=iso-8859-1\r\n";

           $headers .= "From: Apache Error <webmaster@daycentreconnections.org>\r\n";
           $headers .= "Cc: [email]webmaster@daycentreconnections.org[/email]\r\n";

           mail($to, $subject, $message, $headers);
           break;
           //script will continue

      //notices
      case E_NOTICE:
           //don't show notice errors
           break;
 }

//set the error handler to be used
set_error_handler("handler");

tsinka

Hi,

please post the file as attachment. I checked the code with php and there is no syntax error. The file itself might contain something we can't see when you post using copy'n'paste.

Thomas

Funky_Monk

Thanx. Please see the attachement. I had to save it as a .txt file to attach it, but it should be .php extension.

tsinka

Hi,

still no error if I check the syntax with php. Try to remove the comments inside the switch block and/or change

switch($error_type)
{

switch ($error_type) {

But that shouldn't be a problem ... just to make sure.

Thomas

drawmack

what version of php are you all running?

tsinka

Hi drawmack,

PHP 4.3.2/4.3.6/4.3.8 (all on SuSE Linux)

Thomas

Weedpacket

PHP4.3.0, PHP5.0.0RC1 (oh, that reminds me...)