Placing an images if there is nothing in the database..

[popcop]

hi folks...

im pulling news stories from the database to my site.. the news story include an image... but i was wondering.. how can i make it so that if there was no image in the database for that story it would automatically use an image that says...'no image'

Ive done something so far but it doesnt seem to be working.... i currently have the image i want to use if there is no image connected to the story in the database with the id of 1

but the page seems to be still trying to get the image that that is missing

Im using this code at the top of the page...

$data['id'] = '$noimage';

im using this code to pull the image :

table width='305' height='96' border='0' cellpadding='0' cellspacing='0'>
<tr>
<td width='100' height='100' rowspan='5' ><img src='image.php?id={$data['id']}' width='100' height='100'></td>
<td width='5' height='100' rowspan='5'><img src='' width='5' height='15' alt=''></td>
<td width='5' height='19' bgcolor='007887'><img src='' width='5' height='15' alt=''></td>
<td width='34' height='19' bgcolor='007887'><img src='images/date.gif' width='34' height='9'></td>
<td width='156' height='19' valign='middle' bgcolor='007887' class='date'>{$data['date_txt']}</td>
<td width='5' height='19' bgcolor='007887'><img src='' width='5' height='15' alt=''></td>
</tr>

im using this code at the below that..

If (!isset($noimage)){
$noimage = '1';
};

(these are just snippets of the appropriate code)

please help

[drawmack]

just set a default value on that column in your database that points to the no image image. Then when one is not uploaded it will automatically point to no image.

[popcop]

so dont use any of that code ???

[drawmack]

You would not have to decided wether to show the specified image or a different one, you would just always show the specified image, which would be the no image image if the user did not upload one.

[popcop]

when i try and add a default i get this...

Error

SQL-query :

ALTER TABLE news CHANGE photo photo LONGBLOB DEFAULT 'images/noimage.gif' NOT NULL

MySQL said:

#1101 - BLOB column 'photo' can't have a default value

[drawmack]

oh you're storing the images directly in the database. In that case. Set up your insert form so that if not picture is uploaded it puts the no image image into the blob field.

[popcop]

can u explain to me how to do this

[drawmack]

you're already storing the uploaded image in the database. Just use the same code, but if they didn't upload a picture have it read in your no image file.

[popcop]

now all of them are showing the 'no image' image..

heres the code, can u see where i have went wrong ???

$date_txt = $GET['date_txt'];
$header = $GET['header'];
$description = $GET['description'];
$data = $GET['data'];
$type = $_GET['type'];
$data['id'] = "$noimage";
If (!isset($noimage)){
$noimage = "1";
};

$link = mysql_connect ($host, $user, $password);
mysql_select_db("popcop_db");

$q = "SELECT id, thedate, header, description, date_txt, photo, type FROM $tablename ORDER BY thedate DESC LIMIT 4";
$r = mysql_query($q);

echo mysql_error();

$row = 0;

while($data = mysql_fetch_array($r)) {

if ($row == 0) { //first row

echo "<table width='305' height='96' border='0' cellpadding='0' cellspacing='0'>

<tr>
<td width='100' height='100' rowspan='5'><img src='image.php?id=$noimage' width='100' height='100'></td>
<td width='5' height='100' rowspan='5'><img src='' width='5' height='15' alt=''></td>
<td width='5' height='19' bgcolor='007887'><img src='' width='5' height='15' alt=''></td>
<td width='34' height='19' bgcolor='007887'><img src='images/date.gif' width='34' height='9'></td>
<td width='156' height='19' valign='middle' bgcolor='007887' class='date'>{$data['date_txt']}</td>
<td width='5' height='19' bgcolor='007887'><img src='' width='5' height='15' alt=''></td>
</tr>
<tr>
<td height='19' bgcolor='03D7F0'>&nbsp;</td>
<td height='19' colspan='2' valign='middle' bgcolor='03D7F0' class='header'>{$data['header']}</td>
<td width='5' height='19' bgcolor='03D7F0'>&nbsp;</td>
</tr>
<tr>
<td height='3' rowspan='3' bgcolor='#FFFFFF'>&nbsp;</td>
<td height='1' colspan='2' bgcolor='#FFFFFF'><img name='' src='' width='156' height='3' alt=''></td>
<td width='5' height='3' rowspan='3' bgcolor='#FFFFFF'>&nbsp;</td>
</tr>
<tr>
<td height='56' colspan='2' valign='top' bgcolor='#FFFFFF'><a href='#' onClick='open_read(\"read.php?id={$data['id']}\");return false;'>{$data['description']}</a></td>
</tr>
<tr>
<td height='3' colspan='2' bgcolor='#FFFFFF'><img name='' src='' width='156' height='3' alt=''></td>
</tr>";

$row++;

} else { //rows 2 thru x

echo "<table width='234' height='5' border='0' cellpadding='0' cellspacing='0'>
<tr valign='middle'>
<td width='95' colspan='3'><img name='' src='' width='32' height='5' alt=''></td>
</tr></table>

<table width='305' height='96' border='0' cellpadding='0' cellspacing='0'>
<tr>
<td width='100' height='100' rowspan='5'><img src='image.php?id=$noimage' width='100' height='100'></td>
<td width='5' height='100' rowspan='5'><img src='' width='5' height='15' alt=''></td>
<td width='5' height='19' bgcolor='007887'><img src='' width='5' height='15' alt=''></td>
<td width='34' height='19' bgcolor='007887'><img src='images/date.gif' width='34' height='9'></td>
<td width='156' height='19' valign='middle' bgcolor='007887' class='date'>{$data['date_txt']}</td>
<td width='5' height='19' bgcolor='007887'><img src='' width='5' height='15' alt=''></td>
</tr>
<tr>
<td height='19' bgcolor='03D7F0'>&nbsp;</td>
<td height='19' colspan='2' valign='middle' bgcolor='03D7F0' class='header'>{$data['header']}</td>
<td width='5' height='19' bgcolor='03D7F0'>&nbsp;</td>
</tr>
<tr>
<td height='3' rowspan='3' bgcolor='#FFFFFF'>&nbsp;</td>
<td height='1' colspan='2' bgcolor='#FFFFFF'><img name='' src='' width='156' height='3' alt=''></td>
<td width='5' height='3' rowspan='3' bgcolor='#FFFFFF'>&nbsp;</td>
</tr>
<tr>
<td height='56' colspan='2' valign='top' bgcolor='#FFFFFF'><a href='#' onClick='open_read(\"read.php?id={$data['id']}\");return false;'>{$data['description']}</a></td>
</tr>
<tr>
<td height='3' colspan='2' bgcolor='#FFFFFF'><img name='' src='' width='156' height='3' alt=''></td>
</tr>";

} //end else

} //end while

If (!isset($noimage)){
$noimage = "1";
};

?>[/COLOR]

[drawmack]

alright go back to the code the way it was before, when it was working, but without no image.

Now, tell me what's in the photo field?

[Weedpacket]

Originally posted by popcop
heres the code, can u see where i have went wrong ???

Just as a suggestion, try using &#91;php] instead of &#91;COLOR=RED]. Then you'd have

$date_txt = $_GET['date_txt'];
$header = $_GET['header'];
$description = $_GET['description'];
$data = $_GET['data'];
$type = $_GET['type'];
$data['id'] = "$noimage";
If (!isset($noimage)){ 
$noimage = "1"; 
}; 

$link = mysql_connect ($host, $user, $password);
mysql_select_db("popcop_db"); 

$q = "SELECT id, thedate, header, description, date_txt, photo, type FROM $tablename ORDER BY thedate DESC LIMIT 4";
$r = mysql_query($q);

echo mysql_error();

$row = 0;

while($data = mysql_fetch_array($r)) {

if ($row == 0) { //first row

echo "<table width='305' height='96' border='0' cellpadding='0' cellspacing='0'>
  <tr> 
    <td width='100' height='100' rowspan='5'><img src='image.php?id=$noimage' width='100' height='100'></td>
    <td width='5' height='100' rowspan='5'><img src='' width='5' height='15' alt=''></td>
    <td width='5' height='19' bgcolor='007887'><img src='' width='5' height='15' alt=''></td>
    <td width='34' height='19' bgcolor='007887'><img src='images/date.gif' width='34' height='9'></td>
    <td width='156' height='19' valign='middle' bgcolor='007887' class='date'>{$data['date_txt']}</td>
    <td width='5' height='19' bgcolor='007887'><img src='' width='5' height='15' alt=''></td>
  </tr>
  <tr> 
    <td height='19' bgcolor='03D7F0'>&nbsp;</td>
    <td height='19' colspan='2' valign='middle' bgcolor='03D7F0' class='header'>{$data['header']}</td>
    <td width='5' height='19' bgcolor='03D7F0'>&nbsp;</td>
  </tr>
  <tr> 
    <td height='3' rowspan='3' bgcolor='#FFFFFF'>&nbsp;</td>
    <td height='1' colspan='2' bgcolor='#FFFFFF'><img name='' src='' width='156' height='3' alt=''></td>
    <td width='5' height='3' rowspan='3' bgcolor='#FFFFFF'>&nbsp;</td>
  </tr>
  <tr>
    <td height='56' colspan='2' valign='top' bgcolor='#FFFFFF'><a href='#' onClick='open_read(\"read.php?id={$data['id']}\");return false;'>{$data['description']}</a></td>
  </tr>
  <tr>
    <td height='3' colspan='2' bgcolor='#FFFFFF'><img name='' src='' width='156' height='3' alt=''></td>
  </tr>";


$row++;

} else { //rows 2 thru x

echo "<table width='234' height='5' border='0' cellpadding='0' cellspacing='0'>
  <tr valign='middle'> 
    <td width='95' colspan='3'><img name='' src='' width='32' height='5' alt=''></td>
  </tr></table>

  <table width='305' height='96' border='0' cellpadding='0' cellspacing='0'>
  <tr> 
    <td width='100' height='100' rowspan='5'><img src='image.php?id=$noimage' width='100' height='100'></td>
    <td width='5' height='100' rowspan='5'><img src='' width='5' height='15' alt=''></td>
    <td width='5' height='19' bgcolor='007887'><img src='' width='5' height='15' alt=''></td>
    <td width='34' height='19' bgcolor='007887'><img src='images/date.gif' width='34' height='9'></td>
    <td width='156' height='19' valign='middle' bgcolor='007887' class='date'>{$data['date_txt']}</td>
    <td width='5' height='19' bgcolor='007887'><img src='' width='5' height='15' alt=''></td>
  </tr>
  <tr> 
    <td height='19' bgcolor='03D7F0'>&nbsp;</td>
    <td height='19' colspan='2' valign='middle' bgcolor='03D7F0' class='header'>{$data['header']}</td>
    <td width='5' height='19' bgcolor='03D7F0'>&nbsp;</td>
  </tr>
  <tr> 
    <td height='3' rowspan='3' bgcolor='#FFFFFF'>&nbsp;</td>
    <td height='1' colspan='2' bgcolor='#FFFFFF'><img name='' src='' width='156' height='3' alt=''></td>
    <td width='5' height='3' rowspan='3' bgcolor='#FFFFFF'>&nbsp;</td>
  </tr>
  <tr>
    <td height='56' colspan='2' valign='top' bgcolor='#FFFFFF'><a href='#' onClick='open_read(\"read.php?id={$data['id']}\");return false;'>{$data['description']}</a></td>
  </tr>
  <tr>
    <td height='3' colspan='2' bgcolor='#FFFFFF'><img name='' src='' width='156' height='3' alt=''></td>
  </tr>";

} //end else

} //end while

If (!isset($noimage)){ 
$noimage = "1"; 
}; 

?>

Which makes it a lot easier to read (and comment on - those huge echo statements are pretty unnecessary - you don't need PHP for all that).

You set a bunch of variables at the start ($date_text, $header, and so on), but you never use them; you also set a variable $data to contain the value of $_GET['data'], and then a moment later you have $data['id'] = "$noimage", which also looks odd, I'm guessing from your echo statements you wanted those to be $data['date_text'], $data['header'], $data['data'] and so on? Also, there's little point in testing to see if $noimage is set and giving it a default value if it's not after you've already used it (and there's no point testing it again after the end of the while loop). Where is $noimage supposed to get it's value from, anyway? As far as I can see, it will never be set, and so will always have a default value of 1.

[popcop]

basically what im trying to achieve is...

if there is no image been sent to the database from the the form then it will select 'id 1' where there is an image which reads 'no image'

this is getting so annoying now, i cant seem to get it to work

[Weedpacket]

Originally posted by popcop
basically what im trying to achieve is...

if there is no image been sent to the database from the the form then it will select 'id 1' where there is an image which reads 'no image'

So I gathered ... I did see some problems with your code, which is why I pointed them out: you set variables you never use, and you use variables you never set.

I do see you setting $noimage to 1, and then later on using <img src="image.php?id=$noimage"> - presumably that's why it's showing image ID 1 every time. Perhaps you got

$data['id'] = "$noimage"; 

backwards? I mean, I'm not entirely sure where the id number is supposed to be coming from - assuming it's a GET form field named "id" then that line and the following four should be replaced with something like

if(isset($_GET['id']))
    $noimage = $_GET['id'];
else
    $noimage = 1;

And I think I've just realised that $noimage is short for "number of image", and doesn't mean "no image".

[popcop]

so do i put this

if(isset($_GET['id'])) 
    $noimage = $_GET['id']; 
else 
    $noimage = 1;

at top where i declared the variables ?

if you look at the bottom on my code i have

If (!isset($noimage)){  

$noimage = "1";  

};

Also.... are u saying that i cant use $noimage

[Weedpacket]

Originally posted by popcop
so do i put this

if(isset($_GET['id'])) 
    $noimage = $_GET['id']; 
else 
    $noimage = 1;

at top where i declared the variables ?[/b]

I believe that loosely sums up what I said.

if you look at the bottom on my code i have

If (!isset($noimage)){  

$noimage = "1";  

};

[/b]

Yes, I noticed that and commented that I couldn't understand why.

Also.... are u saying that i cant use $noimage

No, you're free to use any syntactically valid variable name you like - I just realised that I was misreading it. That suggests that a more descriptive name might be better, but if it works for you....