[Resolved] Submitting Data

Iquil

I'm creating a cd database and having trouble with the submitance of data.

can anyone see whats wrong with this?

<?php

include "connect.php";

function s_band() {
	global $Artist, $Year, $Album, $Genre;
	global $dbName, $table;

$l_id = Connect($dbName);

$query = "INSERT INTO $table VALUES(NULL, '$Artist', '$Album', '$Year', '$Genre')";

$result = mysql_query($query);
if(!$result) error_msg(sql_error());
else echo "<link rel=\"stylesheet\" href=\"common/main.css\" type=\"text/css\"><body>Info Submitted<br><br><a href=\"index.php\">home</a>";
}

s_band();
?>

Sxooter

I feel like a blind man trying to find out what's wrong with a video projector here.

Maybe, just maybe you could show us your error messages, if any? Clues help, the more the better.

Iquil

sorry unfortunatly there is no given error. Just my personal error.

which is in the connect.php file

<?php
$dbHost = "localhost";
$dbUname = "root";
$dbPass = "root";
$dbName = "cds";

$table = "iquil";

$MYSQL_ERRNO = "";
$MYSQL_ERROR = "";

function Connect() {
	global $dbHost, $dbUname, $dbPass, $dbName;
	global $MYSQL_ERRNO, $MYSQL_ERROR;

$link_id = mysql_connect($dbHost, $dbUname, $dbPass);
if(!$link_id) {
	$MYSQL_ERRNO = 0;
	$MYSQL_ERROR = "The connection has failed";
	return 0;
}
elseif(empty($dbName) && !mysql_select_db($dbName)) {
	$MYSQL_ERRNO = mysql_errno;
	$MYSQL_ERROR = mysql_error;
	return 0;
}
else return $link_id;
}

function sql_error() {
	global $MYSQL_ERRNO, $MYSQL_ERROR;

if(empty($MYSQL_error)) {
	$MYSQL_ERRNO = mysql_errno;
	$MYSQL_ERROR = mysql_error;
}
return "<br>$MYSQL_ERRNO<br>$MYSQL_ERROR<br><br>";
}

// this is the personal error message
function error_msg() {
	echo "<link rel=\"stylesheet\" href=\"common/main.css\" type=\"text/css\"><body>something went wrong!!<br><br><a href=\"index.php\">home</a>";
}

?>

i don't know why it's not giving an error.

Sxooter

There are two possible errors (or more) in the connect.inc aren't there? Please just post what the machine spits out at you without making me guess.

Iquil

sorry about this.

something went wrong!!

home
Submit Another

That is what i get

This is the page sorce of the above

<link rel="stylesheet" href="common/main.css" type="text/css"><body>something went wrong!!<br><br><a href="index.php">home</a><br><a href="s_tmp.php">Submit Another</a>

that is everything i think

Sxooter

OK, you're calling error_msg with a value, but error_msg() isn't declared to accept arguments.

Have it print out the error message it gets when it is called.

Iquil

ok i have now got it to out put the error and this is it

1046
No Database Selected

something went wrong!!

home
Submit Another

but the thing i don't get is that i have selected the database 😕

haven't i??

Sxooter

Try putitng your select_db inside your default else part, i.e. add {} and stick it in there before returning link ID. I think it's getting eaten in the second elseif.

Iquil

Thank you for your help Sxooter

i entered this into the script

	$db_selected = mysql_select_db($dbName);
	if (!$db_selected) {
		die (mysql_error());

if(!$dbName) error_msg(sql_error());
}

Which seems to have done the trick 🙂

Sxooter

Yeah, php has optimizations for ANDed ifs:

if (1==0 AND blah()){

}

will result in blah never being called, because 1 will never equal 0, so with that test failed, php will shortcut the blah() function.