functions

[Dutch_MaFia-boy]

Here is my functions page (temp4.php):

<?php

function larger($x,$y)
{
 if (!isset($x)||!isset($y))
// In the above line we are saying that "if x is not set or if y is not set"
   {
     echo 'This function requires two numbers';
     return;
   }
   if ($x>=$y)
     echo $x;
   else
     echo $y;
   echo '<br />';
   }
<?

Here is a seperate page with the function I want to call from the above page:

<?php
include("temp4.php");

$a = 1;
$b = 2.5;
$c = 1.9

echo larger($a, $b);
echo larger($c, $a);
echo larger($d, $a);


?>

Its not working!

Please someone have a look at it.

Thanks.

Adrian

[LordShryku]

Well, first I see you're doing two echos on top of each other. One from the function, then one calling the function. It's usually better to return from a function instead of directly echoing from it. Try something like this instead.

function larger($x, $y) {
   if(isset($x) && isset($y)) {
      return ($x >= $y) ? $x : $y;
   }
   return false;
}


$a = 1;
$b = 2.5;

echo (($test = larger($a, $b)) !== false) ? $test : 'This function requires two numbers';

[Dutch_MaFia-boy]

LordShryku:

I appreciate you trying to suggest a more economical way of doing my script, but since I am learning php, I want to know what is going on - so can you or somebody else just tweak the script I posted to make it work without overhauling it....

Thanks.

Adrian

[Dutch_MaFia-boy]

forgot to say:

I want to be able to refer to a function on a separate page - as you can see from my script - I want to have a "functions" page (temp4.php) where I can call the functions without having to put the code on the page I call it from.

Thanks.

[thorpe]

a few things, maybe you overlooked it but your closing php delimter is backwords. the other thing, and what LordShryku was saying is, that you are calling the function with an echo function when you allready have an echo inside the function.

two things you could do;

rework the function to return the results instead of echo them from inside the function. eg:

<?php 
  function larger($x,$y) 
  { 
    if (!isset($x)||!isset($y)) { 
      return 'this function requires two numbers'; 
    } else { 
      if ($x>=$y) { 
        return $x; 
      } else { 
        return $y;  

      }
    }
  }
?>

and call it using;

<?php 
  include("temp4.php"); 
  $a = 1; 
  $b = 2.5; 
  $c = 1.9 
  echo larger($a, $b); 
  echo larger($c, $a); 
  echo larger($d, $a); 
?>

or dont call it using the echo, eg:

<?php 
  include("temp4.php"); 
  $a = 1; 
  $b = 2.5; 
  $c = 1.9 
  larger($a, $b); 
  larger($c, $a); 
  larger($d, $a); 
?>