Deleting info from database

[Iquil]

Hello, i have set up a page so that it allows ppl to add and delete info from a database. My problem is that when information is added to it, it is quickly removed from it.

The page is set to refresh every 5 seconds. But that shouldn't activeate the code should it?? It's probably to do with the way i have written the code.

	if(!$cdData[0]) $cdlist = "There are currently no albums listed in the database.";
	else {
		$cdQuery = "SELECT artist, album, genre, id FROM ".$table." ORDER BY artist, album DESC";
		$cdResult = mysql_query($cdQuery, $dbLink)
    	or die(mysql_error());

	if(!$cdResult) error(sql_error());

	$cdlist = "<b>".$table."</b><br><table class=\"td\"><tr><td>Artist</td><td>Album</td><td>Genre</td></tr>";
	while($cdData = mysql_fetch_array($cdResult)) {
		$ID = $cdData['id'];
		$cdlist .= "<tr><td class=\"td\">$cdData[artist]</td><td class=\"td\">$cdData[album]</td><td class=\"td\">$cdData[genre]</td><td class=\"td\"><a href=\"$PHP_SELF?query\">Delete</a></td></tr>";
	}
	$cdlist .= "</table>";
}
$query = mysql_query("DELETE FROM cd WHERE id = $ID");
include "template.php";
}

any help on this would be appreciated

Thanks in advance

Iquil

[Roger_Ramjet]

Your delete query is outside of your if-else structure, so it gets executed every time the script is run. Unless there is something else before the if that you have not posted here, which would explain the extra }.

[Iquil]

I don't think there is something outside of it... the last '}' was just the end of the function sorry... here is the entire page

<?php
include "connect.php";

function cdlist() {
	global $dbName, $table;

$del = "del";

$dbLink = Connect();

$db_selected = mysql_select_db($dbName, $dbLink);
if (!$db_selected) {
	die (mysql_error());

if(!$dbName) error_msg(sql_error());
}

$cdQuery = "SELECT count(*) FROM ".$table;
$cdResult = mysql_query($cdQuery, $dbLink)
or die(mysql_error());

if(!$cdResult) error(sql_error());

$cdData = mysql_fetch_row($cdResult);

if(!$cdData[0]) $cdlist = "There are currently no albums listed in the database.";
else {
	$cdQuery = "SELECT artist, album, genre, id FROM ".$table." ORDER BY artist, album DESC";
	$cdResult = mysql_query($cdQuery, $dbLink)
	or die(mysql_error());

	if(!$cdResult) error(sql_error());

	$cdlist = "<b>".$table."</b><br><table class=\"td\"><tr><td>Artist</td><td>Album</td><td>Genre</td><td><a href=\"$PHP_SELF?\">Delete</a></td></tr>";
	while($cdData = mysql_fetch_array($cdResult)) {
		$ID = $cdData['id'];
		$cdlist .= "<tr><td class=\"td\">$cdData[artist]</td><td class=\"td\">$cdData[album]</td><td class=\"td\">$cdData[genre]</td><td class=\"td\"><a href=\"$PHP_SELF?query\">Delete</a></td></tr>";
	}
	$query = mysql_query("DELETE FROM cd WHERE id = $ID");
	$cdlist .= "</table>";
}
include "template.php";
}

cdlist();

?>

i have put the query inside the ifelse statment but it continue's to delete all entries when it refreshes

[Roger_Ramjet]

So it inside the else. It still gets executed right after the while finishes. Your else clause:

runs the select query
displays the results
runs the delete query

I thought that your problem was that you did not want the delete to run right away, which it always will with your current code.

[Iquil]

yes i don't want it to run right away. i'm confused about what you said

Your delete query is outside of your if-else structure, so it gets executed every time the script is run. Unless there is something else before the if that you have not posted here, which would explain the extra }.

I thought you ment put it inside the ifelse statment. I've tried to put it into a different function and using variables but i kept getting this error

There is an error in your SQL syntax near " at line 1

which really didn't help me at all. so i don't know what to do 🙁

[Roger_Ramjet]

The error means what it says, could be no end quotes or something like that.

As to your delete query, I meant that it is not contained within any condition, like an if, so it gets executed every time the else clause gets run, which was the problem you complained of.

Best thing you can do is step back and rethink the process. What exactly are you trying to do? Is there a simpler way of doing i? THERE ALWAYS IS.

[Iquil]

ah i see. thanks for your help Roger Ramjet 🙂