[Resolved] gd sets image to greyscale- meant to be colour

[helz]

I have a script that creates a bargraph, now it all works great until setting the colours to be used, even when a colour is chosen it sets it to greyscale.
here is some of the code:

extract($_GET);
//-----------------------------------------------
$txtcnt = $width;//keep original percentage before changing width for image
$maxwidthmultiplier = 2;//multiplication to increase width by: 50 becomes 100, 17 becomes 34
//while ($width < 100) {//increase width
	$width = $width * $maxwidthmultiplier;//increase width by $maxwidth
//}
//create image...
$image = imagecreate($maxwidth,$height);
//allocate colours...
	$barcolour = imagecolorallocate($image,$decbarcolour[0],$decbarcolour[1],$decbarcolour[2]);
$bordercolour = imagecolorallocate($image,$decbordercolour[0],$decbordercolour[1],$decbordercolour[2]);
$textcolour   = imagecolorallocate($image,$dectextcolour[0],$dectextcolour[1],$dectextcolour[2]);
$remaincolour = imagecolorallocate($image,$decremaincolour[0],$decremaincolour[1],$decremaincolour[2]);
//draw borders...
//use rectangle instead (can be used for shadows :)
imagefilledrectangle($image,0,0,$width,$height,$bordercolour);
//create remaining percentage bar
imagefilledrectangle($image,0,0,$maxwidth,$height,$remaincolour);
	//draw rectangle
imagefilledrectangle($image,1,1,($width - 2),($height - 2),$barcolour);
//output text
imagestring($image,4,($maxwidth/2.8),($height/5),$txtcnt.'%',$textcolour);

//output image
header("Content-type: image/png"); 
imagepng($image);
imagedestroy($image);

[Mordecai]

Try using a truecolor image:
$image = imagecreatetruecolor($maxwidth,$height);

[helz]

same result
i even tried a static test for the colour:

$barcolour = imagecolorallocate($image,0,0,255);

but it showed up as black.

i tried outputting as a jpeg image aswell but to still no avail

[Weedpacket]

Hm... works for me (at least with literal colours). You checked your dec*colour[] arrays?

[helz]

thats what i meant before in my last post:

i even tried a static test for the colour:

    $barcolour = imagecolorallocate($image,0,0,255);//blue colour

but it showed up as black

i will check the decimal colour array again to make sure...

[helz]

correction
i think your right, on my test computer, using php5 i used str_split to split up a hex colour:
0000FF into three seperate values of an array:
$color[0] = 00;
$color[1] = 00;
$color[2] = FF;
and then convert to decimal, except the php4 version of str_split obviously doesnt work...
here is the copy of it:

function str_split($str, $len=1) {
   if ($len < 1)
      return false;
      $str_ary = array();
      $input_len = strlen($str);
      // don't use substr unless you have to
      if($len == 1)
         for($cursor = 0; $cursor < $input_len; $cursor++)
            $str_ary[] = $str{$cursor};
      else
         for ($cursor = 0; $cursor < $input_len; $cursor += $len)
         $str_ary[] = substr($str, $offset, $len);
   return $str_ary;
}

[helz]

used a different str_split off the comments at the bottom, works now, thanks again!

[Weedpacket]

Hmm... looking at that str_split function..... y'know, assuming that everything going in is going to be hex digits only, it could be shortened a fair bit, because you're assuming that (e.g.) '|' won't be in the string.....

function hex_str_split($hexstring, $width)
{  return explode('|',chunk_split($hexstring, $width, '|'));
}

[helz]

i did attempt at a eregi check to make sure characters that where being entered where:
[0-9] and [a-f]
but was unsuccessful since ive never done it before

plus i wanted the hex number that was to be entered to be a complete string:

0000FF or F356F0
and not:
00,22,43 or some other delimiter