populating a list from MYSQL

[Gladiator2043]

I am using the following code to populate a list box.

the table I am using is in the form of
car_id, car_make

I want the listbox to both have the label based on car_make AND ALSO THE VALUE.

All this code is doing is put the label(car_make) and then the value (car_id) in the list box

what am I doing wrong ?

@mysql_connect('localhost', 'carbuys_webuser', 'webuser') ? mysql_select_db('carbuys_carbiz') : die(mysql_error());
$query="SELECT * FROM car_makes ORDER BY car_makes_id";


 $result = mysql_query($query) or die ("Error in query: $query. " .mysql_error());

?>
<td width="283"><select name="make" id="make">

<?
while ($line = mysql_fetch_array($result)) 
   { 
foreach ($line as $value) 
       { 

   print "<OPTION value='$value'"; 
   } 
print ">$value</OPTION>"; 
   } 


mysql_close();
?>


  </select></td>
[\PHP]

[tuf-web_co_uk]

why are you using a while loop and a foreach loop?

<?
while ($line = mysql_fetch_array($result)) {
	print '<OPTION value=\"".$line['car_id']."\">".$line['car_make']."</OPTION>'; 
}
?>

second of all, where are you declaring the variable $value (in the below instance)??

print ">$value</OPTION>";

if you use the above code, that should fix your problem, which i'm guessing is that somethings werent displayed.

REMEMBER - tell us what the problem is!

[Edit]Make Sure You Remove The Password And Username From Your Mysql Connection Function When Posting Here (For Security Purposes)[/Edit]