[Resolved] Row counting not working

[Herk]

Please point out my, most likely, retarded error.

  function News() {
    $result = @mysql_query("SELECT COUNT(*) FROM news");
    $count = mysql_fetch_row($result);
    $this->news_total = $count[0];
    for($i=1;$i<=$this->news_total;$i++){
      $result = @mysql_query("SELECT * FROM news WHERE newsnum =\"".$i."\"");
      $this->news_data[$i] = mysql_fetch_array($result);
    }
  }

The error is:

Warning: mysql_fetch_row(): supplied argument is not a valid MySQL result resource in /home/virtual/site3/fst/var/www/html/resources/integral.php on line 568

Where have I gone wrong?

BTW, line 568 is

$count = mysql_fetch_row($result);

.

Herk

[LordShryku]

Where's your mysql_connect?

Also, just out of curiosity, why do the count at all? Seems like an un-needed sql statement being executed.

[Herk]

The connection is above in the code.

And I am counting to acquire the number of entries. If this is not necessary, please let me know how else to determine the number of news entries in the database.

To be more specific: at this point, I should have a $this->news_data[$i]['title'], $this->news_data[$i]['body'], and so on for each news entry.

Thank you kindly for your help.

Herk

[hasin]

Most probably this is due to ur connection has problem. I mean u forgot to use mysql_connect() function. If I am wrong then please supply the resource id of ur database to the mysql_query() as 2nd parameter. Thi smay work

I mean

mysql_connect("your host,","user","pwd");
$link = mysql_select_db("your db");
$result = mysql_query($query,$link);
//here is ur code

another way to do this by mysql_num_rows() function.

that may be

$result = mysql_query("select * from news",$link);
echo mysql_num_rows($result);

Thanks
--Hasin

[Herk]

Thank your for your reply. The database is connected, and I've tried num_rows as well. It yields the same error.

The connection above is:

$dbconnection = mysql_connect($dbserver, $dbusername, $dbpassword)
  or die("Could not connect : " . mysql_error());
mysql_select_db($dbname)
  or die("Could not select database");

[LordShryku]

You have to have the connection inside of the function's scope. Pass a reference to it as a parameter.

Also, it doesn't seem like you're doing anything with the count, except cause yourself to do many queries instead of one. You could instead do something like this

function News(&$conn) {
    $result          = mysql_query("SELECT * FROM news");
    $this->news_data = array();
    while($row = mysql_fetch_array($result)) {
       $this->news_data[] = $row;
    }
    return $this->news_data;
}

[Herk]

I think you've given me a bit to work with. Thank you kindly. It is nighty night time. I'll try it out tomorrow. Thanks.

BTW, I regularly use sql statements in functions without recalling the connection.

like:

//connection
function blah() {
// whatever code with sql queries
}
$var = blah;
//disconnection

So if I'm already connected, and not disconnected until after the function is called, why would it not already be in the functions scope?

Bah, trying to learn OOP is such a headache.

Herk

[Herk]

Holy crap. >.<

I'm a dummy. I had instantiated the object well after the dbconnection had closed.

Evidently that has to be done while the connection is still open. hehe Oops. 🙂

I think I can press on now. Wish me luck. Thank you all for your help.

Herk