Help with directory PHP script...

RyanJones

Hi, all

Wondering if anyone can fix this script, I've tried everythign I know and its still messed up 🙁

Demo: http://chatzone.viperhosting.net/Temporary/Test1.php

Code:

<?php
/*#############################
Code by RyanJ (Ryan Jones).
Header can not be removed.
Code: Display folder contents.
############################*/
$Directory = "../"; # Start Directory.
if ($Handle = @opendir($Directory)){ # Does the directory exist?
 $Folders = array(); # Define Folders array for future use.
 $Files = array();   # Define Files array for future use.
 $FileSize = array();
 while (false !== ($File = readdir($Handle))){ # Lets loop through the files and folders.
   if (($File != ".") && ($File != "..")){ # We dont want the . and .. folders so, remove them.
     if (is_dir($Directory . $File)){ # Is it a directory?
       $Folders[] = $File; # Yes, put it in the Folders array we created earlier.
     }
		 else{
       $Files[] = $File; # No, put it in the Files array then...
			 $FileSize[] = (filesize($Directory . $File) / 1000);
     } 
   }
 }
 closedir($Handle);  # No longer need the directoy so, close it.
 if (count($Folders) > 0){  # Check length of Folders array....
   echo "Folders:<ul>\n"; #  Start the Folders output.
     foreach ($Folders as $Folder) # Loop through each entry in the Folders array.
       echo "<li>Folder: [$Folder]\n"; # Print the results.
       echo "</ul>\n"; # End of Folders section.
     }
     if (count($Files) > 0){ # Check length of Files array....
       echo "Files:<ul>\n"; # Start the Files output.
       foreach ($Files as $File){ # Loop through each entry in the Files array.
			   foreach ($FileSize as $SizeM){
           $File = explode('.', $File); # Ok, lets split the full name into an array....
            $FileM = $File[0]; # Ok, we want the first secion for the file name.
            if (count($File) > 1){ # Check length of File...
              $Extension = "." . $File[1]; # Ok, we not want the extension which is the second part of the string.
						  if ($Extension != ".htaccess"){ # Is the file a .htaccess file?
                echo "<li>$FileM$Extension:<ul><li>File Name: [$FileM]</li><li>Extension: [$Extension]</li><li>Size: [$SizeM Kilo-bytes]</li></ul></li>\n"; # No, Ok print the results...
              }
						  else{
							  echo "<li>.httaccess:<ul><li>File Name: [.httaccess]</li><li>Extension: [None]</li><li>Size: [$SizeM Kilo-bytes]</li></ul></li>\n"; # Yes, .htaccess needs special treatment.
						  }
					  }
					  else{
              echo "<li>$FileM$Extension:<ul><li>File Name: [$FileM]</li><li>Extension: [$Extension]</li><li>Size: [$SizeM Kilo-bytes]</li></ul></li>\n"; # More output.
            }
          }
				}
        echo "</ul>\n"; # End of Files output.
      }
    }
    else{ 
      echo "<p>Directory $Directory doesn't exist!</p>"; # Diretory not found!
    }
?>

Thanks for the help,

RyanJ

tsinka

What exactly do you want to do ?

RyanJones

Well, the problem is it shows Array.extension and there are thr wrong number of files showing.

Have you got any ideas?

Yegg

Well I'ts because you are wrong ina your array loops. U have two arrays, one whith file names, another with file sizes, and make loops like this

foreach(filenames){
foreach(filesizes){
......
}
}

on each filename iteration you have count(filesizes) iteretions, this code will work fine for your solution

    foreach ($Files as $idx => $File){ # Loop through each entry in the Files array. 
            $SizeM=$FileSize[$idx];
	       	$File = explode('.', $File); # Ok, lets split the full name into an array.... 
            $FileM = $File[0]; # Ok, we want the first secion for the file name. 
            if (count($File) > 1){ # Check length of File... 
              $Extension = "." . $File[1]; # Ok, we not want the extension which is the second part of the string. 
                          if ($Extension != ".htaccess"){ # Is the file a .htaccess file? 
                echo "<li>$FileM$Extension:<ul><li>File Name: [$FileM]</li><li>Extension: [$Extension]</li><li>Size: [$SizeM Kilo-bytes]</li></ul></li>\n"; # No, Ok print the results... 
              } 
                          else{ 
                              echo "<li>.httaccess:<ul><li>File Name: [.httaccess]</li><li>Extension: [None]</li><li>Size: [$SizeM Kilo-bytes]</li></ul></li>\n"; # Yes, .htaccess needs special treatment. 
                          } 
                      } 
                      else{ 
              echo "<li>$FileM$Extension:<ul><li>File Name: [$FileM]</li><li>Extension: [$Extension]</li><li>Size: [$SizeM Kilo-bytes]</li></ul></li>\n"; # More output. 
            } 

            }

but any way, you have the bad coding style, better to make one 2 level array:

$Files[0]['FileName']
$Files[0]['FileSize']
$Files[0]['FileType']
$Files[1]['FileName']
$Files[1]['FileSize']
$Files[1]['FileType']

and also, what I found, not all extensions are going after first point, e.g. file with name like

supa-year-1912.12.12.doc

will have supa-year-1912 name only and doc as extension - a middle part of file will lost. you have to find anothe one solution.

drawmack

Originally posted by RyanJones
Wondering if anyone can fix this script, I've tried everythign I know and its still messed up 🙁

Yes I can fix it and you can see what it's supposed to look like at http://www.enderswebdev.com/test/lister.php

Here's an article you might find interesting

RyanJones

Thanks for the help, with the article and a long time thinking I solved it 🙂

Thanks for the help,

RyanJ

(Link: http://www.chatzone.viperhosting.net/Temporary/Test4.php)