[Resolved] dir reading stops at first file

[Kudose]

Could someone please fill me in on why this script stops after one file? I have 214 in the dir and it just works with one and then stops.

$open = opendir($onsite_dir);
while (($check = readdir($open))!= false){ 
if ($check != "." && $check != "..") { 
$handle = fopen($onsite_dir.$check, "r");
$read = $php_start;
if (!function_exists('file_get_contents')) {
$read .= fread($handle, 800000);
} else {
$read .= file_get_contents($onsite_url.$check);
}
$read = str_replace("<script", "<?php /* <script", $read); 
$read = str_replace("</script>", "</script> */ ?>", $read);
$read .= $php_end;
if(!chmod($onsite_dir.$check, 0755)){ echo "Cannot change permission on file."; exit;}
if(!$open = fopen($onsite_dir.$check, "w")) { echo "Error :: Cannot open file: ".$check; exit;}		
if (!fwrite($open, $read)) { echo "Cannot write to file: ".$handle."<br>"; exit;}
echo $check." Success.";	
} 
}

Thanks!

note: the $read = str_replace's aren't the problem.

[tsinka]

Hi,

the problem might be that you use $onsite_url in the file_get_contents line instead of $onsite_dir. And you might need to add a slash between the directory and the filename.

Something like this:

<?PHP
$open = opendir($onsite_dir); 
while (($check = readdir($open)) != false){ 
  if ($check != "." && $check != "..") { 
    $thefile = "$onsite_dir/$check";
    $read = "";
    $msg = "";
    if (!function_exists('file_get_contents')) { 
      $handle = fopen($thefile, "r");
      if ($handle) { 
        $read = fread($handle, filesize($thefile)); 
        fclose($handle);
      } else {
        $msg = "Error: Cannot read $thefile.";
      }
    } else { 
      $read = file_get_contents($thefile); 
    } 

if (strlen($read)) {
  $read    = $php_start.$read; 
  $read = str_replace("<script", "<?php /* <script", $read); 
  $read = str_replace("</script>", "</script> */ ?>", $read); 
  $read .= $php_end; 
  if(!chmod($thefile, 0755)){ 
    $msg = "Error: Cannot change permissions of file $thefile.";
  } else {
    if($open = fopen($thefile, "w")) {
      if (!fwrite($open, $read)) { 
        $msg = "Error: Cannot write to file $handle.";
      } else {
        $msg = "Success: Successfully modified $thefile.";
      }
      fclose($open);
    } else {        
      echo "Error: Cannot open file $thefile for writing.";
    }
  }
} else {
  $msg = "Error: file $thefile is empty.";
}
echo "$msg<br>\n";
  }
} 
?>

Don't forget to use fclose() ...

Thomas

[tsinka]

Ooops,

just noticed another error ... you use $open as resource handle twice (opendir and fopen to write). Change one of them. This could be the main reason for that problem. Use closedir after the while loop to release the opendir resource.

Thomas

[Kudose]

Changed

if(!$open = fopen($onsite_dir.$check, "w")) { echo "Error :: Cannot open file: ".$check; exit;}         

if (!fwrite($open, $read)) { echo "Cannot write to file: ".$handle."<br>"; exit;} 

to

if(!$write = fopen($onsite_dir.$check, "w")) { echo "Error :: Cannot open file: ".$check; exit;}		
		if (!fwrite($write, $read)) { echo "Cannot write to file: ".$handle."<br>"; exit;}

Now everything is kosher.

Thanks tsinka. I dont think you realize how much you just helped me.

Got a Pay-Pal account?