Calculating Shipping costs question

[chL]

Hi, I'm working on getting my first e-commerce website up.

I'm using 1&1's developper eShop if that can help you.

Okay, here's what I'm trying to do: I took their example script of using the country that the order is shipped to and weight to calculate the shipping costs, but I want to change the country to reflect the province so that I can charge depending on the canadian province. Here's the example that they give:

if (get_orderinfo_shipping_field("country"))
$country= get_orderinfo_shipping_field("country");
else
$country= get_orderinfo_field("country");

$gesgewicht=0;
foreach ($basket_items as $i) {
//Weight calculate here.
$overall_weight+= item_get_field('Gewicht', $i) * item_get_field('count', $i);
}

if ($country="DE" && $overall_weight > 100) $shipping_fee= 50;
elseif ($country="DE" && $overall_weight > 50 ) $shipping_fee= 20;
elseif ($country="AT" && $overall_weight > 100) $shipping_fee= 80;
elseif ($country="AT" && $overall_weight > 50 ) $shipping_fee= 40;

Here is what I'm trying to do now:

if (get_orderinfo_shipping_field("state"))
$state= get_orderinfo_shipping_field("state");
else
$state= get_orderinfo_field("state");

$gesgewicht=0;
foreach ($basket_items as $i) {
//Weight calculate here.
$overall_weight+= item_get_field('Gewicht', $i) * item_get_field('count', $i);
}

if ($state="ON" && $overall_weight < 10) $shipping_fee= 15.05;
elseif ($state="ON" && $overall_weight >= 10 && $overall_weight < 20) $shipping_fee= 19.90;
elseif ($state="ON" && $overall_weight >= 20 && $overall_weight < 30) $shipping_fee= 25.60;
elseif ($state="ON" && $overall_weight >= 30 && $overall_weight < 40) $shipping_fee= 30.50;
elseif ($state="ON" && $overall_weight >= 40 && $overall_weight < 50) $shipping_fee= 34.10;
elseif ($state="ON" && $overall_weight >= 50 && $overall_weight < 60) $shipping_fee= 38.45;
elseif ($state="ON" && $overall_weight >= 60 && $overall_weight < 70) $shipping_fee= 42.80;
elseif ($state="ON" && $overall_weight >= 70 && $overall_weight < 80) $shipping_fee= 47.95;
elseif ($state="ON" && $overall_weight >= 80 && $overall_weight < 90) $shipping_fee= 52.85;
elseif ($state="ON" && $overall_weight >= 90 && $overall_weight < 100) $shipping_fee= 56.50;
elseif ($state="ON" && $overall_weight >= 100 && $overall_weight < 110) $shipping_fee= 61.15;
elseif ($state="ON" && $overall_weight >= 110 && $overall_weight < 120) $shipping_fee= 66.65;
elseif ($state="ON" && $overall_weight >= 120 && $overall_weight < 130) $shipping_fee= 71.15;
elseif ($state="ON" && $overall_weight >= 130) $shipping_fee= 0.55 * $overall_weight;

elseif ($state="QC" && $overall_weight < 10) $shipping_fee= 15.15;
elseif ($state="QC" && $overall_weight >= 10 && $overall_weight < 20) $shipping_fee= 19.90;
elseif ($state="QC" && $overall_weight >= 20 && $overall_weight < 30) $shipping_fee= 25.60;
elseif ($state="QC" && $overall_weight >= 30 && $overall_weight < 40) $shipping_fee= 30.50;
elseif ($state="QC" && $overall_weight >= 40 && $overall_weight < 50) $shipping_fee= 34.10;
elseif ($state="QC" && $overall_weight >= 50 && $overall_weight < 60) $shipping_fee= 38.45;
elseif ($state="QC" && $overall_weight >= 60 && $overall_weight < 70) $shipping_fee= 42.80;
elseif ($state="QC" && $overall_weight >= 70 && $overall_weight < 80) $shipping_fee= 47.95;
elseif ($state="QC" && $overall_weight >= 80 && $overall_weight < 90) $shipping_fee= 52.85;
elseif ($state="QC" && $overall_weight >= 90 && $overall_weight < 100) $shipping_fee= 56.50;
elseif ($state="QC" && $overall_weight >= 100 && $overall_weight < 110) $shipping_fee= 61.15;
elseif ($state="QC" && $overall_weight >= 110 && $overall_weight < 120) $shipping_fee= 66.65;
elseif ($state="QC" && $overall_weight >= 120 && $overall_weight < 130) $shipping_fee= 71.15;
elseif ($state="QC" && $overall_weight >= 130) $shipping_fee= 0.55 * $overall_weight;

As you can see, I've only done the fees for Quebec and Ontario but that should be enough to test it. Now, when I login and order from a Quebec address and have an order of weight: 7lbs, I get 15.05$ shipping fee. If I change numbers around and add weight or w/e, I ALWAYS get the FIRST number in there.

WHY?

Can some1 help me?

Also, I know that a switch statement would probably make this more efficient but I'm kinda rusty in PHP and don't know much in the first place. Would changing this from if statements to switch statements take long? Thanks!

THANKS A LOT!

BTW, if you are willing to help me and want to AIM or MSN me, feel free to! my s/n is: Jim14Qc and my MSN is [e-mail]

[tsinka]

Hi,

replace
$state="??"
by
$state=="??"

in all lines. You're assigning a value with just one =. So the code will use "ON" data each time.

Besides that you can do something like that:

$fees["ON"] = array(19.90,25.60,30.50,.....);
$fees["QC"] = array(19.90,25.60,30.50,.....);
$feeIdx = floor($overall_weight/10);

$shipping_fee = ($feeIdx<count($fees[$state])) ? $fees[$state][$feeIdx] : 0.55 * $overall_weight;

// if you don't want to use the ternary operator (?) above
$shipping_fee = 0.55 * $overall_weight;
if ($feeIdx<count($fees[$state])) {
  $shipping_fee = $fees[$state][$feeIdx];
}

Thomas

[chL]

Alright, I worked on this some (the == thing really solved a lot of mysteries. I can't believe I made that mistake!)

Here's what I have now:

if (get_orderinfo_shipping_field("state")) 
   $state= get_orderinfo_shipping_field("state");
 else 
   $state= get_orderinfo_field("state");

 $gesgewicht=0; 
 foreach ($basket_items as $i) { 
   //Weight calculated here. 
   $overall_weight+= item_get_field('weight', $i) * item_get_field('count', $i);
 }

$fees["ON"] = array(15.15,19.90,25.60,30.50,34.10,38.45,42.80,47.95,52.85,56.50,61.15,66.65,71.15); 
$fees["QC"] = array(15.15,19.90,25.60,30.50,34.10,38.45,42.80,47.95,52.85,56.50,61.15,66.65,71.15); 
$fees["BC"] = array(22.55,31.35,37.70,42.75,46.95,52.05,57.10,62.55,68.45,72.60,78.05,83.05,88.05);
$fees["AB"] = array(22.55,31.35,37.70,42.75,46.95,52.05,57.10,62.55,68.45,72.60,78.05,83.05,88.05);
$fees["SK"] = array(22.55,31.35,37.70,42.75,46.95,52.05,57.10,62.55,68.45,72.60,78.05,83.05,88.05);
$fees["MB"] = array(22.55,31.35,37.70,42.75,46.95,52.05,57.10,62.55,68.45,72.60,78.05,83.05,88.05);
$fees["PE"] = array(22.60,34.45,41.40,44.40,49.95,57.30,62.00,66.85,70.45,75.45,81.65,87.65,93.65);
$fees["NB"] = array(22.60,34.45,41.40,44.40,49.95,57.30,62.00,66.85,70.45,75.45,81.65,87.65,93.65);
$fees["NL"] = array(22.60,34.45,41.40,44.40,49.95,57.30,62.00,66.85,70.45,75.45,81.65,87.65,93.65);
$fees["NS"] = array(22.60,34.45,41.40,44.40,49.95,57.30,62.00,66.85,70.45,75.45,81.65,87.65,93.65);

$feeIdx = floor($overall_weight/10);

if ($state=="ON" || $state=="QC") {
$shipping_fee = 0.55 * $overall_weight; 
}

elseif ($state=="BC" || $state=="AB" || $state=="SK" || $state=="MB") {
$shipping_fee = 0.67 * $overall_weight;
}

elseif ($state=="PE" || $state=="NB" || $state=="NL" || $state=="NS") {
$shipping_fee = 0.73 * $overall_weight; 
}

if ($feeIdx<count($fees[$state])) { 
  $shipping_fee = $fees[$state][$feeIdx]; 
}

$shipping_fee = $shipping_fee + 2;

That works pretty good so far, so I'm going to use that (and modify it) for all my shipping methods

Thanks a lot!

[tsinka]

Hi,

what about this instead of the if/else part:

$factors = array("ON"=>0.55,"QC"=>0.55,"BC"=>0.67,.....);
$shipping_fee = 0.55 * $overall_weight;

if (array_key_exists($state,$factors)) {
  $shipping_fee = $factors[$state] * $overall_weight;
}

Thomas

[chL]

This makes the code even easier, but I don't get why you assign $shipping_fee to .55 * overall_weight ?

[pnoeric]

he sets up the default shipping fee of 0.55 * $overall_weight, then if there's something in $factors[] that should 'override' that default, it does.

(really nice refactoring, tsinka!)

E

[chL]

Alright thanks a LOT for this help!