strange image upload problem

[isar21]

hi everybody,
I need help on a little problem which drives me almost mad.
I have created a more or less simple little script to upload images on a server and store name and path of the image in a mysql database.
1.question
it works perfect with safari but with any other browser no way, why ???
there is now error message, just the image and its file name are not stored ( mozilla on mac, ie6 on windows )

here comes the code:

// pick a file extension
if (eregi('îmage/p?jpeg(;.*)?$',
	$_FILES['uploadedfile']['type']) )
	$extension = '.jpg';
	else $extension = '.gif';

// the complete path/filename
if ($_FILES['uploadedfile']['name'] == "")
{
 $filename = "images/1x1.gif";
}else{
 $filename = "images/" . time() . $_FILES['uploadedfile']['name'];
}


// Copy the file 
if (is_uploaded_file($_FILES['uploadedfile']['tmp_name']) and 
	copy($_FILES['uploadedfile']['tmp_name'], $filename)) {
	echo("<p>File stored successfully as $filename.</p>");
}else{
	//echo("<p>Could not save as $filename.</p>");
	}

the form looks like that:

<form action="<?=$PHP_SELF?>" method="post" enctype="multipart/formdata">
	 Headline:<br>
	  	<input name="newshead" type="text" value="" size="45" maxlength="45"wrap>
		</input>
		<br><br>Text:<br>
		<textarea name="newstext" rows="15" cols="45" wrap>
		</textarea>
		<br><br>URL: <br>
	  	<input name="URL"  type="text" value=" " size="45" maxlength="45"wrap>
		</input>
		<br><br>
		<br>Bild auswaehlen (maximal 420x300 pixel):
		<input type="hidden" name="MAX_FILE_SIZE" value="100000">
		<br><br>
		<input type="file" name="uploadedfile" />
		<br><br>

2. question (you might call me silly for this one)
   I didn't manage to store the images in any other folder than "images",
   something like $filename = "level1/level2/images/" . time() . $_FILES['uploadedfile']['name']; just didn't work.
   looks like the image folder has to be in the same folder as the script itsself !?
   did I forget about any simple html rule or is there any other reason?

// the complete path/filename
if ($_FILES['uploadedfile']['name'] == "")
{
 $filename = "images/1x1.gif";
}else{
 $filename = "images/" . time() . $_FILES['uploadedfile']['name'];
}

thanks a lot for your help
stephan

[tsinka]

Hi,

the enctype might be the problem, change
enctype="multipart/formdata"
to
enctype="multipart/form-data"

Which error do you get if you try to use another directory to store the images ?

Hint: Use [ PHP] [ /PHP] (without spaces) with PHP code. This will display the code highlighted.

Thomas

[Installer]

nm

[tsinka]

nm ?

[isar21]

enctype="multipart/form-data"

did the trick!
thanks a lot!

but there is still the problem with the folders.
if I change the folder location:

// the complete path/filename
if ($_FILES['uploadedfile']['name'] == "")
{
 $filename = "images/1x1.gif";
}else{
 $filename = "2003/images/news/" . time() . $_FILES['uploadedfile']['name'];
}

no image is uploaded to the folder "news"
and
the file name in the mysql tabel is wrong.
for the example shown above the stored filename looks like that:
src=/2003/rauf/2003/images/news/1093117538imm012.jpg

/2003/rauf/" . time() . used to be the old path and name before I changed it to "2003/images/news/" . time() .

weird !!
any clues?

thanks a lot
stephan

[tsinka]

Hi,

use move_uploaded_file instead of copy and try to use absolute paths instead of relative paths.

Post the code that inserts the data into the table (including the code that deals with the image paths).

Thomas

[isar21]

ok, here comes the whole code:

<?php

// pick a file extension
if (eregi('îmage/p?jpeg(;.*)?$',
	$_FILES['uploadedfile']['type']) )
	$extension = '.jpg';
	else $extension = '.gif';

// the complete path/filename
if ($_FILES['uploadedfile']['name'] == "")
{
 $filename = "images/1x1.gif";
}else{
 $filename = "images/" . time() . $_FILES['uploadedfile']['name'];
}


// Copy the file 
if (is_uploaded_file($_FILES['uploadedfile']['tmp_name']) and 
	copy($_FILES['uploadedfile']['tmp_name'], $filename)) {
	echo("<p>File stored successfully as $filename.</p>");
}else{
	echo("<p>Could not save as $filename.</p>");
	}
	echo($_FILES['userfile']['error']);


if ($submit): // Eine neue nachricht wurde in das Formular eingetragen

  if ($aid == "") {
    echo("<p>du m&uuml;sset f&uuml;r diesee nachricht " .
         "einen Autor ausw&auml;hlen. Klicke auf 'Zur&uuml;ck' " .
         "und probiere es nochmal.</p>");
    exit();
  }

 // datenbank auswaehlen
 $dbcnx = mysql_connect("db******", "*****", "*******");
  if (!$dbcnx) {
    echo( "<p>Zur Zeit keine Verbindung  " .
          "zum Datenbankserver m&ouml;glich.</p>" );
    exit();
  }

// news datenbank auswaehlen
  if (! mysql_select_db("db*******") ) {
    echo( "<p>Auswahl der NEWS-Datenbank  " .
          "zur Zeit nicht m&ouml;glich.</p>" );
    exit();
  }

  $sql = "INSERT INTO news SET
  		  newshead='$newshead',
          newstext='$newstext',
		  URL='$URL',
		  image='$filename',
          newsdate=CURDATE(),
          AID='$aid'";
  if (@mysql_query($sql)) {
    //echo("<p>New message added</p>");
  } else {
    echo("<p>error while adding: " .
         mysql_error() . "</p>");
  }

  $jid = mysql_insert_id();

  if ($cats == "") $cats = array();

  foreach ($cats as $catID) {
    $sql = "INSERT IGNORE INTO newslookup
            SET NID=$jid, CID=$catID";
    $ok = @mysql_query($sql);
    if ($ok) {
      $numCats = $numCats + 1;
    } else {
      echo("<p>Fehler beim Einf&uuml;gen der Nachricht in die Kategorie $catID: " .
           mysql_error() . "</p>");
    }
  }
?>

so, this example works.
I have thought about just to change this part:

// the complete path/filename
if ($_FILES['uploadedfile']['name'] == "")
{
 $filename = "images/1x1.gif";
}else{
 $filename = "images/" . time() . $_FILES['uploadedfile']['name'];
}

into this:

// the complete path/filename
if ($_FILES['uploadedfile']['name'] == "")
{
 $filename = "images/1x1.gif";
}else{
 $filename = "images/news/" . time() . $_FILES['uploadedfile']['name'];
}

but if I do so ( or change to any other path, including absolut paths) the image is not saved and I got an error message, like:
Could not save as /2003/images/news/1093204433imm012.jpg.
means the name in the table is saved properly (what I wrote in my previously posted message about strange path names was wrong, my fault), but not the image itself to the specified folder.

thanks a lot (und gruesse nach karlsruhe and its ISPs)
stephan

[tsinka]

Did you check the permissions of the target directory. In most cases the web server runs under a different user than yours. The directories you create will have your user id as owner.

Try to change the permissions to 777.

Alternatively, use move_uploaded_file and specify just the target directory (without the filename).

Thomas