Image Upload issue

[slimjim]

Having a problem, I can't see what it is.
What happens is this...
I go to the upload page i automatically get the die statement. I also dont know if i have this code correct.
Anyone want to help me out and look at this code for me please !!
I thnk the problem is with the query or if statement or maybe the way i have it arranged ,k i don't know. Been at this all day and can't figure it out.

<?

require_once "../conf/common.php";
memberchecklogin();
dbconnect();

if(isset($_POST['submit'])){


$banpath = "../banners";  

copy($our_file, "$banpath/$our_file_name") or die("Couldn't Upload the file!");  

$query2="INSERT INTO banners (memberid, categoryid, sizeid, name, url, weighting, filetype, approved) values ('$membername','$categoryg','$pc_id','$name','$url','$weight','$our_file_type','Y')";

mysql_query($query2) or die( "ERROR: " . mysql_error() . "\n");	
} else {

die("Something went wrong hmmmmm........");
}
	if($action=="logout"){
		memberchecklogout();
	}

?>
<form method="post" action="<? $PHP_SELF; ?>" enctype="multipart/form-data">
  <table border="0" width="75%" cellspacing="0">
    <tr> 
      <td width="14%">&nbsp;</td>
      <td width="31%" colspan="2"><b><font size="2">Complete the following details 
        about the banner:-</font></b><font size="2"> </font></td>
    </tr>
    <tr> 
      <td width="14%" height="10">&nbsp;</td>
      <td width="31%" height="10"><font size="2">Name: </font></td>
      <td width="55%" height="10"><font size="2"> 
        <input type="text" name="name" size="30" maxlength="50"></font></td>
    </tr>
    <tr> 
      <td width="14%" height="6">&nbsp;</td>
      <td width="31%" height="6"><font size="2">URL To Go To: </font></td>
      <td width="55%" height="6"><font size="2"> 
        <input type="text" name="url" size="30" maxlength="255" value="http://">
        </font></td>
    </tr>
    <tr> 
      <td width="14%" height="10">&nbsp;</td>
      <td width="31%" height="10"><font size="2">Category:</font></td>
      <td width="55%" height="10"> 
        <? 

$sql="SELECT id, name FROM categories ORDER by id ASC"; 
$result=mysql_query($sql); 

$options=""; 

while ($row=mysql_fetch_array($result)) { 

//$id=$row["id"]; 
$name=$row["name"]; 
$options.="<OPTION VALUE=\"$name\">".$name; 
} 
?> 
<SELECT NAME=categoryg> 
<OPTION VALUE=0>Choose 
<?=$options?> 
</SELECT> 
      </td>
    </tr>
    <tr> 
      <td width="14%" height="10">&nbsp;</td>
      <td width="31%" height="10"><font size="2">Dimensions:</font></td>
      <td width="55%" height="10"> 
        <? 

$sql="SELECT id, width, height FROM sizes ORDER by id ASC"; 
$result=mysql_query($sql); 

$options=""; 

while ($row=mysql_fetch_array($result)) { 

$pc_id=$row["id"]; 
$pc_width=$row["width"];
$pc_height=$row["height"];
$bothwh = "$pc_width x $pc_height"; 
$options.="<OPTION VALUE=\"$pc_id\">".$bothwh; 
} 
?> 
<SELECT NAME=sized> 
<OPTION VALUE=0>Choose 
<?=$options?> 
</SELECT> 
      </td>
    </tr>
    <tr> 
      <td width="14%" height="6">&nbsp;</td>
      <td width="31%" height="6"><font size="2">Display Weighting</font></td>
      <td width="55%" height="6"><font size="2"> 
        <select name="weight">
	    <option value="1">1 (Least Shows)</option>
	    <option value="2">2</option>
	    <option value="3" selected>3</option>
	    <option value="4">4</option>
	    <option value="5">5 (Most Shows)</option>
	  </select>
        </font>
	</td>
    </tr>
    <tr> 
      <td width="14%" height="10">&nbsp;</td>
      <td width="31%" height="10">&nbsp;</td>
      <td width="55%" height="10">&nbsp;</td>
    </tr>
    <tr> 
      <td width="14%" height="10">&nbsp;</td>
      <td width="31%" height="10" colspan="2"><b><font size="2">Now locate the 
        image on your computer:-</font></b><font size="2"> </font></td>
    </tr>
    <tr> 
      <td width="14%" height="10">&nbsp;</td>
      <td width="31%" height="10" colspan="2"> 
        <input type="file" name="our_file" size="30"></p>
      </td>
    </tr>
    <tr> 
      <td width="14%" height="10">&nbsp;</td>
      <td width="31%" height="10" colspan="2"><font size="2"><i><b>Note:</b> Banners 
        must be in JPEG or GIF format and less than 40 KB in 
        size.</i></font></td>
    </tr>
    <tr> 
      <td width="14%" height="10">&nbsp;</td>
      <td width="31%" height="10" colspan="2">&nbsp;</td>
    </tr>
    <tr> 
      <td width="14%" height="10">&nbsp;</td>
      <td width="31%" height="10" colspan="2">
        <input type="submit" name="submit" value="Add Banner">
      </td>
    </tr>
  </table>
</form>

[scoppc]

Well, after I quick look, I guess the problem lies here..

if(isset($_POST['submit'])){ 


$banpath = "../banners";   

copy($our_file, "$banpath/$our_file_name") or die("Couldn't Upload the file!");   

$query2="INSERT INTO banners (memberid, categoryid, sizeid, name, url, weighting, filetype, approved) values  ('$membername','$categoryg','$pc_id','$name','$url
','$weight','$our_file_type','Y')"; 

mysql_query($query2) or die( "ERROR: " . mysql_error() . "\n");     
} else { 

die("Something went wrong hmmmmm........"); 
} 

Surely, when the page first loads, the variable $_POST['submit'] hasnt set yet. So, it will always gives u die("Something went wrong hmmmmm........");.

[slimjim]

Not sure what else to do so that it isn't the first thing that loads ..

[slimjim]

OK i just redirected the posting to another page so that it gets called right.
but now have another issue.
I am trying to get the image type put in the database, such as if the image is a gif image, i want gif put in the colum.
But it is putting in the word image instead of the ext called gif

can anyone tell me whats up ?

[scoppc]

you could examine the type it gives by doing this:

$file=$_FILES['our_file'];
print $file['type'];

a JPEG file will give u image/pjpeg or image/jpeg, and image/gif for GIF file. So, it isnt just JPG or GIF.

U might need IF statement to determine which ext to be stored based on the image type. HTH.