[Resolved] [Resolved] [Resolved] [Resolved] function and html

[slimjim]

Ok I am calling this function below. But I am trying to print the results into html and I cant get it to work. Below is the code. If anyone can help that would be great.

function getSetting($name)
{
	$sql="select * from settings where name='$val'";

$res=mysql_query($sql);
while($obj=mysql_fetch_object($res))
{	
	return $obj->settingvalue;
}
}

Now i know the function works cause I have used it when inserting into db.
Problem is now i need it to grab a color code that will be inserted in html bgcolor.
Example : #FF0000 is what is in settings

Below is what i am trying to get which holds the color code of #FF0000

getSetting(headbarcolor)
I dont think i am doing something right in the html , as you can see i tired it 2 different ways ...
Here is html

<?PHP

require_once "../conf/common.php";
memberchecklogin();
dbconnect();
?>
<table border="0" cellpadding="0" cellspacing="0" width="100%"><tr>      

    <td width="100%" height="13" bgcolor="<? getSetting("headbarcolor") ?>"><font color="getSetting("headbartextcolor")">Purchase
      Credits</font></td>
    </tr></table>

[yelvington]

You said

function getSetting($name)
{
$sql="select * from settings where name='$val'";

but perhaps you meant to say

where name = '$name'

Incidentally, you should retrieve only the column you're going to use:

select settingvalue from settings where name='$name'

[slimjim]

Well say i change it too :

function getSetting($name)
{
	$sql="select content from settings where name='$name'";

$res=mysql_query($sql);
while($obj=mysql_fetch_object($res))
{	
	return $obj->settingvalue;
}
}

How would i call the name headbarcolor and get the content of that name. Which would be #FF0000 ?

[slimjim]

Thought it might help if i show you table and inserts:

CREATE TABLE `settings` (
  `name` varchar(40) NOT NULL default '',
  `content` varchar(255) NOT NULL default '',
  PRIMARY KEY  (`name`)
) TYPE=MyISAM;
INSERT INTO `settings` (`name`, `content`) VALUES ('headbarcolor','#FF0000');
INSERT INTO `settings` (`name`, `content`) VALUES ('headbartextcolor','#FFFFFF');

I changed the function to read this and it still doesn't work:

function getSetting($name)
{
	$sql="select content from settings where name='$name'";

$res=mysql_query($sql);
while($obj=mysql_fetch_object($res))
{	
	return $obj->settingvalue;
}
}

And html I have tried a few different ways :

<table border="0" cellpadding="0" cellspacing="0" width="100%"><tr>      

    <td width="100%" height="13" bgcolor="<? getSetting("headbarcolor")?>"><font color="getSetting("headbartextcolor")">Purchase
      Credits</font></td>
    </tr></table>

[tsinka]

Hi,

try the following code:

<?PHP
function getSetting($name) 
{ 
    // default value
    $retVal = "#ff0000";

$sql="select content from settings where name='$name'"; 

$res=mysql_query($sql) or die("SQL error: ".mysql_error()); 

if ($row = mysql_fetch_array($res)) {
  $retVal = $row['content'];
}

return $retVal;
}
?>

If you don't want to have a default value but rather an error if no value could be fetched then change the function to return e.g. false and check the return value prior to using it in the HTML code.
I added the die for debugging purposes. You might want to change it so that the script doesn't die but rather set a error variable or somethink like that.

html:

<table border="0" cellpadding="0" cellspacing="0" width="100%">
  <tr>       

    <td width="100%" height="13" bgcolor="<?=getSetting("headbarcolor")?>">
      <font color="<?=getSetting("headbartextcolor")?>">Purchase Credits</font>
    </td> 
  </tr>
</table> 

Thomas

[tsinka]

Hi,

one other question:

Is there a reason to store that kind of configuration data in the database. I think it would be more performant to do that with configuration files rather than a MySQL table.

Thomas

[slimjim]

Well what I am trying to do is make it so that I can edit those and other settings thru a admin script, rather then thru a config file.
I suppose I could make it easier on mysql if i put it all in a conf text file.

[tsinka]

What about this:

You have that admin scripts that let the users change colors and stuff like that. Each time they change something you generate a text file containing a variable for each available value. Then use that file in the scripts that display the HTML code. This way you can avoid e.g. 50 sql queries a script.

btw...did the code work I posted ?

Thomas

[slimjim]

Yes that worked.

See for now I am really not working on that issue, going to save some of that cutom work for later, But what I am trying to get done is all of the querys for everything and get those worked out. Then I wil figure out the custom features and emails etc and stuff.

Thanks for your help I am sure to need more soon 🙂