Paging Class

[Nate]

I'm sure there are quite a few of these already but I figured i'd post one I just did today... It's pretty cool, feel free to use it if you want! Critiques are very welcome though.

Example: http://www.adeptisoft.com/dev/classes/paging.class.php

<?php

/*

   EXAMPLE:

   include($_SERVER["DOCUMENT_ROOT"] . "/classes/paging.class.php");
   $paging = new PagedResults();
   $paging->TotalResults = 500; //This is how many results to page through.
                                //mysql_num_rows($query) would just fine!
   print_p($paging->InfoArray());

*/

class PagedResults {

   /* These are defaults */
   var $TotalResults;
   var $CurrentPage = 1;
   var $PageVarName = "page";
   var $ResultsPerPage = 20;
   var $LinksPerPage = 10;

   function InfoArray() {
      $this->TotalPages = $this->getTotalPages();
      $this->CurrentPage = $this->getCurrentPage();
      $this->ResultArray = array(
                           "PREV_PAGE" => $this->getPrevPage(),
                           "NEXT_PAGE" => $this->getNextPage(),
                           "CURRENT_PAGE" => $this->CurrentPage,
                           "TOTAL_PAGES" => $this->TotalPages,
                           "TOTAL_RESULTS" => $this->TotalResults,
                           "PAGE_NUMBERS" => $this->getNumbers(),
                           "MYSQL_LIMIT1" => $this->getStartOffset(),
                           "MYSQL_LIMIT2" => $this->ResultsPerPage,
                           "START_OFFSET" => $this->getStartOffset(),
                           "END_OFFSET" => $this->getEndOffset(),
                           "RESULTS_PER_PAGE" => $this->ResultsPerPage,
                           );
      return $this->ResultArray;
   }

   /* Start information functions */
   function getTotalPages() {
      /* Make sure we don't devide by zero */
      if($this->TotalResults != 0 && $this->ResultsPerPage != 0) {
         $result = ceil($this->TotalResults / $this->ResultsPerPage);
      }
      /* If 0, make it 1 page */
      if(isset($result) && $result == 0) {
         return 1;
      } else {
         return $result;
      }
   }

   function getStartOffset() {
      $offset = $this->ResultsPerPage * ($this->CurrentPage - 1);
      if($offset != 0) { $offset++; }
      return $offset;
   }

   function getEndOffset() {
      if($this->getStartOffset() > ($this->TotalResults - $this->ResultsPerPage)) {
         $offset = $this->TotalResults;
      } elseif($this->getStartOffset() != 0) {
         $offset = $this->getStartOffset() + $this->ResultsPerPage - 1;
      } else {
         $offset = $this->ResultsPerPage;
      }
      return $offset;
   }

   function getCurrentPage() {
      if(isset($_GET[$this->PageVarName])) {
         return $_GET[$this->PageVarName];
      } else {
         return $this->CurrentPage;
      }
   }

   function getPrevPage() {
      if($this->CurrentPage > 1) {
         return $this->CurrentPage - 1;
      } else {
         return false;
      }
   }

   function getNextPage() {
      if($this->CurrentPage < $this->TotalPages) {
         return $this->CurrentPage + 1;
      } else {
         return false;
      }
   }

   function getStartNumber() {
      $links_per_page_half = $this->LinksPerPage / 2;
      /* See if curpage is less than half links per page */
      if($this->CurrentPage <= $links_per_page_half || $this->TotalPages <= $this->LinksPerPage) {
         return 1;
      /* See if curpage is greater than TotalPages minus Half links per page */
      } elseif($this->CurrentPage >= ($this->TotalPages - $links_per_page_half)) {
         return $this->TotalPages - $this->LinksPerPage + 1;
      } else {
         return $this->CurrentPage - $links_per_page_half;
      }
   }

   function getEndNumber() {
      if($this->TotalPages < $this->LinksPerPage) {
         return $this->TotalPages;
      } else {
         return $this->getStartNumber() + $this->LinksPerPage - 1;
      }
   }

   function getNumbers() {
      for($i=$this->getStartNumber(); $i<=$this->getEndNumber(); $i++) {
         $numbers[] = $i;
      }
      return $numbers;
   }

}

?>

Example of how to use it...

<?php

   /* Instantiate the paging class! */
   $Paging = new PagedResults();

   /* This is required in order for the whole thing to work! */
   $Paging->TotalResults = 13283;

   /* If you want to change options, do so like this INSTEAD of changing them directly in the class! */
   $Paging->ResultsPerPage = 50;
   $Paging->LinksPerPage = 20;
   $Paging->PageVarName = "page";

   /* Get our array of valuable paging information! */
   $InfoArray = $Paging->InfoArray();

   /* Print that crap out */
   print("<pre>"); print_r($InfoArray); print("</pre>");

   /* Everything below here are just examples! */

   /* Print our some info like "Displaying page 1 of 49" */
   echo "Displaying page " . $InfoArray["CURRENT_PAGE"] . " of " . $InfoArray["TOTAL_PAGES"] . "<BR>";
   echo "Displaying results " . $InfoArray["START_OFFSET"] . " - " . $InfoArray["END_OFFSET"] . " of " . $InfoArray["TOTAL_RESULTS"] . "<BR>";

   /* Print our first link */
   if($InfoArray["CURRENT_PAGE"]!= 1) {
      echo "<a href='?page=1'>&lt;&lt;</a> ";
   } else {
      echo "&lt;&lt; ";
   }

   /* Print out our prev link */
   if($InfoArray["PREV_PAGE"]) {
      echo "<a href='?page=" . $InfoArray["PREV_PAGE"] . "'>Previous</a> | ";
   } else {
      echo "Previous | ";
   }

   /* Example of how to print our number links! */
   for($i=0; $i<count($InfoArray["PAGE_NUMBERS"]); $i++) {
      if($InfoArray["CURRENT_PAGE"] == $InfoArray["PAGE_NUMBERS"][$i]) {
         echo $InfoArray["PAGE_NUMBERS"][$i] . " | ";
      } else {
         echo "<a href='?page=" . $InfoArray["PAGE_NUMBERS"][$i] . "'>" . $InfoArray["PAGE_NUMBERS"][$i] . "</a> | ";
      }
   }

   /* Print out our next link */
   if($InfoArray["NEXT_PAGE"]) {
      echo " <a href='?page=" . $InfoArray["NEXT_PAGE"] . "'>Next</a>";
   } else {
      echo " Next";
   }

   /* Print our last link */
   if($InfoArray["CURRENT_PAGE"]!= $InfoArray["TOTAL_PAGES"]) {
      echo " <a href='?page=" . $InfoArray["TOTAL_PAGES"] . "'>>></a>";
   } else {
      echo " &gt;&gt;";
   }

?>

[bretticus]

Why didn't I come here the other day when a n00bie asked about paging and I showed him one of my old script kiddie examples.

Who needs to write code anymore when you guys give it away in Code Critique ;-)

[beandip]

I'd really like to try and get this class working in my database, but I'm unsure of how to actually tie it in?

[bretticus]

The class above (on a quick scan) is a generic pagination class with lots of features. If you want data tools incorporated with pagination, I have scaled down my datatools class with just the properties and methods needed for pagination. This is BETA code so use at your own risk. It has worked fine for me so far:

<?php
class Datatools
{
	var $db_type; 
    var $db_server; 
    var $db_name; 
    var $db_user; 
    var $db_pass; 
    var $db_persistent; 
    var $db_handle;
	var $current_page;
	var $records_per_page;
    var $db_errors = array();

function Datatools() //Constructor
{
	//Default Settings
	$this->db_type = 1;
    $this->db_server = '';
    $this->db_name = ''; //change when calling
    $this->db_user = '';
    $this->db_pass = '';

	//Check for arguments
	$my_args = func_get_args();
	//If any arguments are sent, all must be sent.
	if (count($my_args))
	{
		list($this->db_type,$this->db_server,$this->db_name,$this->db_user,$this->db_pass) = $my_args;
	}
	//Call Connect
	if (!empty($this->db_name))
		$this->db_connect();
	$this->records_per_page = 10;
}

/**
* @return void
* @desc Connect to database. This is called in the constructor.
*/
function db_connect() {

    switch($this->db_type)
	{ 
        case 1: // mySQL
			$this->db_handle = @mysql_connect($this->db_server, $this->db_user, $this->db_pass);
			if (!$this->db_handle)
			{ 
				$this->db_errors[] = $this->priv_get_error("Could not connect to database server!",$this->db_handle);
				return;
			}
			if (!@mysql_select_db($this->db_name, $this->db_handle))
			{ 
				$this->db_errors[] = $this->priv_get_error("Could not connect to database: {$this->db_name}!", $this->db_handle);
				return;
			}
			break;
		default:
			$this->db_errors[] = "Error: class property value 'db_type' not implemented!";
			return;
    } 
}

/**
 * Returns database row as an array within an array. (Just like ASP ADO GetRows)
 *
 * @param string $my_query
 * @return array
 */
function get_rows($my_query)
{		
	$my_rows = array();
	if ($my_result = @mysql_query($my_query, $this->db_handle))		{
		while($my_cols = @mysql_fetch_row($my_result))			{
			$my_rows[] = $my_cols;
		}
	} 		
	return $my_rows;
}

/**
 * Return rows for a given page view only.
 *
 * @param string $my_query	
 * @param int $current_page
 * @return array
 */
function get_paginated_rows($my_query, $current_page = 1)
{
	$current_page = (!empty($current_page) && is_numeric($current_page)) ? intval($current_page) : 1;
	if (strpos($my_query, "LIMIT") === false) {			
		$limit_start = ($current_page * $this->records_per_page) - $this->records_per_page;
		$my_query .= " LIMIT $limit_start, {$this->records_per_page}";
	}
	//echo $my_query;
	return $this->get_rows($my_query);
}

/**
 * Return a page count according to query submitted.
 *
 * @param string $my_query
 * @param string $field
 * @return int
 */
function get_page_count($my_query, $field = "*")
{
	$parts = spliti("FROM", $my_query);
	$query = "SELECT COUNT(";
	$query .= (strstr($parts[0], "DISTINCT") && $field != "*") ? "DISTINCT " : "";
	$query .= "$field) FROM " . $parts[1];			
	$total = $this->get_single_column($query);
	return ceil($total/$this->records_per_page);
}	

/**
 * Use this function for a quick one-column result.
 *
 * @param string $my_query
 * @return string
 */
function get_single_column($my_query)
{	
	if ($my_result = @mysql_query($my_query, $this->db_handle))	{
		return @mysql_result($my_result, 0);
	} else {
		return false;
	}
}
}

//Example...

$data = new Datatools();
$sql = "SELECT * FROM table";
$data->records_per_page = 20;
$records = $data->get_paginated_rows($sql, $_GET['page']);
foreach ($records as $record) {
	echo $record[0];
	echo $record[1];
	// ...
}
$page_count = $data->get_page_count($sql);
for ($i=0;$i<=$page_count;$i++) {
	echo "<a href='{$_SERVER['PHP_SELF']}?page=$i'>Page $1</a>";	
}
?>

I would use a combination of both scripts. I like the idea that Nate's class is generic (although at a fast glance how to implement it was not glowing.)

[Nate]

Yeah after going over it again i can see how there can be some confusion.

see if this makes any sense..

include("paging.class.php");
//init the class
$paging = new PagedResults();

//tell it how many results to page through
$sql = "SELECT COUNT(*) AS Total FROM table";
$query = mysql_query($sql);
$data = mysql_fetch_array($query);
$paging->TotalResults = $data["Total"];

//now you need to run the query again but this time with limit1 and limit2
$InfoArray = $paging->InfoArray();
$sql = "SELECT * FROM table LIMIT ".$InfoArray["MYSQL_LIMIT1"].", ".$InfoArray["MYSQL_LIMIT2"];
$query = mysql_query($sql);
while($data = mysql_fetch_array($query)) {
   //heres where you get to print our your data from your query
   echo $data["some_field"] . "<br>";
}

/*
   Print our next/prev links and 1,2,3 etc...

   I have examples of all this code in my original post but you can do it yourself too if you see the structure of $InfoArray). print_r() is your friend. Do print("<pre>"); print_r($InfoArray); print("</pre>");
*/

/* Print out our prev link */
if($InfoArray["PREV_PAGE"]) {
   echo "<a href='?page=" . $InfoArray["PREV_PAGE"] . "'>Previous</a>";
} else {
   echo "Previous";
} 

echo " | ";

/* Print out our next link */ 
if($InfoArray["NEXT_PAGE"]) {
   echo " <a href='?page=" . $InfoArray["NEXT_PAGE"] . "'>Next</a>";
} else {
   echo "Next";
} 

[beandip]

Okay, thank you very much for clarifying Nate and for the other comments.

I've made some progress, but unfortunately when I execute the scripte I get this error:

PHP Parse error: parse error, unexpected '{' in /pathtofile/pages.class.php on line 2

The file "pages.class.php" is copied and pasted right off this page:

<?php
class PagedResults { 

   /* These are defaults */ 
   var $TotalResults; 
   var $CurrentPage = 1; 
   var $PageVarName = "page"; 
   var $ResultsPerPage = 20; 
   var $LinksPerPage = 10; 

   function InfoArray() { 
      $this->TotalPages = $this->getTotalPages(); 
      $this->CurrentPage = $this->getCurrentPage(); 
      $this->ResultArray = array( 
                           "PREV_PAGE" => $this->getPrevPage(), 
                           "NEXT_PAGE" => $this->getNextPage(), 
                           "CURRENT_PAGE" => $this->CurrentPage, 
                           "TOTAL_PAGES" => $this->TotalPages, 
                           "TOTAL_RESULTS" => $this->TotalResults, 
                           "PAGE_NUMBERS" => $this->getNumbers(), 
                           "MYSQL_LIMIT1" => $this->getStartOffset(), 
                           "MYSQL_LIMIT2" => $this->ResultsPerPage, 
                           "START_OFFSET" => $this->getStartOffset(), 
                           "END_OFFSET" => $this->getEndOffset(), 
                           "RESULTS_PER_PAGE" => $this->ResultsPerPage, 
                           ); 
      return $this->ResultArray; 
   } 

   /* Start information functions */ 
   function getTotalPages() { 
      /* Make sure we don't devide by zero */ 
      if($this->TotalResults != 0 && $this->ResultsPerPage != 0) { 
         $result = ceil($this->TotalResults / $this->ResultsPerPage); 
      } 
      /* If 0, make it 1 page */ 
      if($result == 0) { 
         return 1; 
      } else { 
         return $result; 
      } 
   } 

   function getStartOffset() { 
      $offset = $this->ResultsPerPage * ($this->CurrentPage - 1); 
      if($offset != 0) { $offset++; } 
      return $offset; 
   } 

   function getEndOffset() { 
      if($this->getStartOffset() > ($this->TotalResults - $this->ResultsPerPage)) { 
         $offset = $this->TotalResults; 
      } elseif($this->getStartOffset() != 0) { 
         $offset = $this->getStartOffset() + $this->ResultsPerPage - 1; 
      } else { 
         $offset = $this->ResultsPerPage; 
      } 
      return $offset; 
   } 

   function getCurrentPage() { 
      $page = $_GET[$this->PageVarName]; 
      if(!$page) { return $this->CurrentPage; } else { return $page; } 
   } 

   function getPrevPage() { 
      if($this->CurrentPage > 1) { 
         return $this->CurrentPage - 1; 
      } else { 
         return false; 
      } 
   } 

   function getNextPage() { 
      if($this->CurrentPage < $this->TotalPages) { 
         return $this->CurrentPage + 1; 
      } else { 
         return false; 
      } 
   } 

   function getStartNumber() { 
      $links_per_page_half = $this->LinksPerPage / 2; 
      /* See if curpage is less than half links per page */ 
      if($this->CurrentPage <= $links_per_page_half || $this->TotalPages <= $this->LinksPerPage) { 
         return 1; 
      /* See if curpage is greater than TotalPages minus Half links per page */ 
      } elseif($this->CurrentPage >= ($this->TotalPages - $links_per_page_half)) { 
         return $this->TotalPages - $this->LinksPerPage + 1; 
      } else { 
         return $this->CurrentPage - $links_per_page_half; 
      } 
   } 

   function getEndNumber() { 
      if($this->TotalPages < $this->LinksPerPage) { 
         return $this->TotalPages; 
      } else { 
         return $this->getStartNumber() + $this->LinksPerPage - 1; 
      } 
   } 

   function getNumbers() { 
      for($i=$this->getStartNumber(); $i<=$this->getEndNumber(); $i++) { 
         $numbers[] = $i; 
      } 
      return $numbers; 
   } 

} 

?>

Thanks for any clues... I really appreciate your help. I'm basically just learning PHP and I've done pretty well up until the point of implenting this paging class. :-)

[Nate]

That's really odd. You are sure your pages.class.php has only that code and nothing else? What version of php are you running? I just copied that exact code in a test file myself and got no parse errors...

[beandip]

Originally posted by Nate
That's really odd. You are sure your pages.class.php has only that code and nothing else? What version of php are you running? I just copied that exact code in a test file myself and got no parse errors...

I have no idea what caused the original parse issue... perhaps a stray invisible character from the text editor I was using... who knows. Anyway that particular error has gone away. I'm running PHP version 4.3.10 by the way.

Okay, so I'm going to enclose the page that I have pieced together... It is a basic e-mail database lookup. I have a mysql database that has an Accounts table with a dozen or so fields. I have a search.php page that searches on two fields... lastname and username. It passes those two fields to a page called "searchresults.php" It is that page that I am posting.

The search works... in that I get 50 results returned. But neither the previous nor next links at the bottom do anything and I get 3 errors in my log. They are:

PHP Notice: Undefined variable: result in /pages.class.php on line 38
Undefined index: page in /pages.class.php on line 63

Okay so here is my searchresults.php page.

<?
 include("conf.php");
 	mysql_connect('localhost',$username,$password);
 	@mysql_select_db($database) or die( "Unable to select database");


include ("pages.class.php");

/* Instantiate the paging class! */
$paging = new PagedResults();

/*tell it how many results to page through */ 
$sql1 = "SELECT COUNT(*) AS 'Total' FROM Accounts"; 
$query = mysql_query($sql1); 

$data = mysql_numrows($query); 
$paging->TotalResults = $data["Total"];

$InfoArray = $paging->InfoArray(); 

/* The following two variables are being fed from a search page */
$username_query=$_POST['username_form'];
$lastname_query=$_POST['lastname_form'];

$sql2 = "select * from Accounts where UserName like '$username_query%' AND Last like '$lastname_query%' order by Last LIMIT ".$InfoArray["MYSQL_LIMIT1"].", ".$InfoArray["MYSQL_LIMIT2"];
$query2 = mysql_query($sql2);

$num=mysql_numrows($query2);

mysql_close();


?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/2000/REC-xhtml1-20000126/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
	<meta http-equiv="content-type" content="text/html; charset=iso-8859-1" />
	<title>Email - Search Results</title>
	<link href="style2.css" rel="stylesheet" type="text/css" media="all" />
</head>
<body>
<center>


<? echo "$num"; ?> records found <br> <!--this is left over from a previous attempt to show total # of records found-->
<? echo "$sql2"; ?>  <!--just printing out the query so I can see what variables it is using -->

<div class="content">

<table border="0" cellspacing="1" cellpadding="2" width="100%">
	<tr bgcolor="#000000"> 
		<td class="headertext" align="left">Last</td>
		<td class="headertext" align="left">First</td>
		<td class="headertext" align="left">Username</td>
		<td class="headertext" align="left">Location</td>
		<td class="headertext" align="left">E-mail</td>
		<td class="headertext" align="left">Edit</td>
	</tr>


<?


while($data = mysql_fetch_array($query2)) {

?>

<tr bgcolor="#DCDCDC"> 
<td align="left"><? echo $data["Last"] ?></td>
<td align="left"><? echo $data["First"] ?></td>
<td align="left"><? echo $data["Username"] ?></td>
<td align="left"><? echo $data["Location"] ?></td>
<td align="left"></td>
<td align="left"></td>
</tr>

<?

} 

echo "</table>";

/* Print out our prev link */ 
if($InfoArray["PREV_PAGE"]) { 
   echo "<a href='?page=" . $InfoArray["PREV_PAGE"] . "'>Previous</a>"; 
} else { 
   echo "Previous"; 
}  

echo " | "; 

/* Print out our next link */  

if($InfoArray["NEXT_PAGE"]) { 
   echo " <a href='?page=" . $InfoArray["NEXT_PAGE"] . "'>Next</a>"; 
} else { 
   echo "Next"; 
}
?>

</div>
</center>
</body>
</html>

and here is my pages.class.php file:

<?php

class PagedResults { 

   /* These are defaults */ 
   var $TotalResults; 
   var $CurrentPage = 1; 
   var $PageVarName = "page"; 
   var $ResultsPerPage = 50; 
   var $LinksPerPage = 10; 

   function InfoArray() { 
      $this->TotalPages = $this->getTotalPages(); 
      $this->CurrentPage = $this->getCurrentPage(); 
      $this->ResultArray = array( 
                           "PREV_PAGE" => $this->getPrevPage(), 
                           "NEXT_PAGE" => $this->getNextPage(), 
                           "CURRENT_PAGE" => $this->CurrentPage, 
                           "TOTAL_PAGES" => $this->TotalPages, 
                           "TOTAL_RESULTS" => $this->TotalResults, 
                           "PAGE_NUMBERS" => $this->getNumbers(), 
                           "MYSQL_LIMIT1" => $this->getStartOffset(), 
                           "MYSQL_LIMIT2" => $this->ResultsPerPage, 
                           "START_OFFSET" => $this->getStartOffset(), 
                           "END_OFFSET" => $this->getEndOffset(), 
                           "RESULTS_PER_PAGE" => $this->ResultsPerPage, 
                           ); 
      return $this->ResultArray; 
   } 

   /* Start information functions */ 
   function getTotalPages() { 
      /* Make sure we don't devide by zero */ 
      if($this->TotalResults != 0 && $this->ResultsPerPage != 0) { 
         $result = ceil($this->TotalResults / $this->ResultsPerPage); 
      } 
      /* If 0, make it 1 page */ 
      if($result == 0) { 
         return 1; 
      } else { 
         return $result; 
      } 
   } 

   function getStartOffset() { 
      $offset = $this->ResultsPerPage * ($this->CurrentPage - 1); 
      if($offset != 0) { $offset++; } 
      return $offset; 
   } 

   function getEndOffset() { 
      if($this->getStartOffset() > ($this->TotalResults - $this->ResultsPerPage)) { 
         $offset = $this->TotalResults; 
      } elseif($this->getStartOffset() != 0) { 
         $offset = $this->getStartOffset() + $this->ResultsPerPage - 1; 
      } else { 
         $offset = $this->ResultsPerPage; 
      } 
      return $offset; 
   } 

   function getCurrentPage() { 
      $page = $_GET[$this->PageVarName]; 
      if(!$page) { return $this->CurrentPage; } else { return $page; } 
   } 

   function getPrevPage() { 
      if($this->CurrentPage > 1) { 
         return $this->CurrentPage - 1; 
      } else { 
         return false; 
      } 
   } 

   function getNextPage() { 
      if($this->CurrentPage < $this->TotalPages) { 
         return $this->CurrentPage + 1; 
      } else { 
         return false; 
      } 
   } 

   function getStartNumber() { 
      $links_per_page_half = $this->LinksPerPage / 2; 
      /* See if curpage is less than half links per page */ 
      if($this->CurrentPage <= $links_per_page_half || $this->TotalPages <= $this->LinksPerPage) { 
         return 1; 
      /* See if curpage is greater than TotalPages minus Half links per page */ 
      } elseif($this->CurrentPage >= ($this->TotalPages - $links_per_page_half)) { 
         return $this->TotalPages - $this->LinksPerPage + 1; 
      } else { 
         return $this->CurrentPage - $links_per_page_half; 
      } 
   } 

   function getEndNumber() { 
      if($this->TotalPages < $this->LinksPerPage) { 
         return $this->TotalPages; 
      } else { 
         return $this->getStartNumber() + $this->LinksPerPage - 1; 
      } 
   } 

   function getNumbers() { 
      for($i=$this->getStartNumber(); $i<=$this->getEndNumber(); $i++) { 
         $numbers[] = $i; 
      } 
      return $numbers; 
   } 

}

?>

[Nate]

When you click next/prev your $_POST['username_form'] is gone.

My suggestion would be make them a $_GET['username_form'], but be sure to pass it along with the next/prev links.

<?php

if($InfoArray["PREV_PAGE"]) {  

   echo "<a href='?page=" . $InfoArray["PREV_PAGE"] . "&username_form=".$_GET["username_form"]."'>Previous</a>";  

} else {  

   echo "Previous";  

}   

?>

Same goes for last name

[beandip]

Nate,

Ahh the few times I've been close enough to get the Next button to actually "link" I've noticed that I've lost my variables for username and lastname... that helpdes a lot.

I don't know if you were able to make my code work for you, but the reason I submitted that last entry with all my code etc. is because when I run the script I get those two PHP errors in my logs:

PHP Notice: Undefined variable: result in /pages.class.php on line 38

and

Undefined index: page in /pages.class.php on line 63

as always... thanks!

[Nate]

Copy over the code in my original post again, that should fix those 2 errors. I can understand if you just want to keep your error logs clean, but don't expect this to fix your script if its broke, as those were just notices and shouldnt really change anything. 🙂

[beandip]

Originally posted by Nate
Copy over the code in my original post again, that should fix those 2 errors. I can understand if you just want to keep your error logs clean, but don't expect this to fix your script if its broke, as those were just notices and shouldnt really change anything. 🙂

Nate, I'm staying at this and with your tips and suggestions, I've managed to not only solve many of the bugs that have plagued me, but I've even tweaked the code a bit to work in some things such as alternating row colors. I switched to _GET and now am able to pass the proper variables from page to page. Nice.

However I have a few remaining issues.

1) When my search returns only 1 hit, the word Previous is NOT linked correctly, but the word Previous is linking. When I click it I get zero results which I would expect. However I thought the code was setup to not link the word "next" unless there were additional pages.

2) I used the piece of code you provided to put the following information above the results:

Displaying results 0 - 20 of 813

This works great when I search for a large amount of records... however when I return one result or five results, could it say "Displaying results 1 of 813" ? or 5 of 813? (813 is the total amount of records in my database.)

I'm including here the current searchresults.php file. The class file is unchanged and exactly what you have in your (updated) original post.

<?php
 include("conf.php");
 	mysql_connect('localhost',$username,$password);
 	@mysql_select_db($database) or die( "Unable to select database");


include ("pages.class.php");

/* Instantiate the paging class! */
$paging = new PagedResults();

/*tell it how many results to page through */ 
$sql1 = "SELECT COUNT(*) as Total FROM Accounts"; 
$query = mysql_query($sql1); 
$data = mysql_fetch_array($query); 
$paging->TotalResults = $data['Total'];

$InfoArray = $paging->InfoArray(); 

/* The following two variables are being fed from a search page */
$username_query=$_GET['username_form'];
$lastname_query=$_GET['lastname_form'];

$sql2 = "select * from Accounts where UserName like '$username_query%' AND Last like '$lastname_query%' order by Last LIMIT ".$InfoArray["MYSQL_LIMIT1"].", ".$InfoArray["MYSQL_LIMIT2"];
$query2 = mysql_query($sql2);

$num=mysql_numrows($query2);

mysql_close();



?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/2000/REC-xhtml1-20000126/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
	<meta http-equiv="content-type" content="text/html; charset=iso-8859-1" />
	<title>Email - Search Results</title>
	<link href="style2.css" rel="stylesheet" type="text/css" media="all" />
</head>
<body>
<center>


<div class="content">

<?php echo "Displaying results " . $InfoArray["START_OFFSET"] . " - " . $InfoArray["END_OFFSET"] . " of " . $InfoArray["TOTAL_RESULTS"] . "<BR>"; ?>


<table border="0" cellspacing="1" cellpadding="2" width="100%">
	<tr bgcolor="#000000"> 
		<td class="headertext" align="left">Last</td>
		<td class="headertext" align="left">First</td>
		<td class="headertext" align="left">Username</td>
		<td class="headertext" align="left">Location</td>
		<td class="headertext" align="left">E-mail</td>
		<td class="headertext" align="left">Edit</td>
	</tr>


<?php
	$i=0;	
	while($data = mysql_fetch_array($query2)) { 
		while ($i < $num) {
			$aid= mysql_result($query2,$i,"aid");
			$First=mysql_result($query2,$i,"First");
			$Last=mysql_result($query2,$i,"Last");
			$UserName=mysql_result($query2,$i,"UserName");
			$Location=mysql_result($query2,$i,"Location");
			$Domain=mysql_result($query2,$i,"Domain");

		//the following three lines are used to alternate the color of rows.
		$color1 = "#DCDCDC"; 
		$color2 = "#FFFFFF"; 
		$row_color = ($i % 2) ? $color1 : $color2;
?>

<tr bgcolor="<?php echo "$row_color"; ?>"> 
<td align="left"><?php echo "$Last"; ?></td>
<td align="left"><?php echo "$First"; ?></td>
<td align="left"><?php echo "$UserName"; ?></td>
<td align="left"><?php echo "$Location"; ?></td>
<td align="left"><a href="mailto:<?php echo "$UserName$Domain"; ?>">E-mail</a></td>
<td align="left"><a href="update.php?aid=<?php echo "$aid"; ?>">Edit</a></td>
</tr>

<?php

		++$i;
	} 
}
echo "</table>";

/* Print out our prev link */ 
if($InfoArray["PREV_PAGE"]) { 
	echo "<a href='?page=" . $InfoArray["PREV_PAGE"] . "&username_form=".$username_query. "&lastname_form=".$lastname_query."'>Previous</a>"; 
} else { 
	echo "Previous"; 
}  

echo " | "; 

/* Print out our next link */  
if($InfoArray["NEXT_PAGE"]) { 
	echo " <a href='?page=" . $InfoArray["NEXT_PAGE"] . "&username_form=".$username_query. "&lastname_form=".$lastname_query."'>Next</a>"; 
} else { 
	echo "Next"; 
}
?>

</div>
</center>
</body>
</html>

[Nate]

1) i tested it with only 1 result on my test page and it didnt link the next or previous links on mine. sounds like there may be a few bugs left... i would check the print_r($InfoArray) again and make sure PREV_PAGE and NEXT_PAGE are both empty.

2) If i understand correctly, you just want to do this?

<?php echo "Found " . $num . " of " . $InfoArray["TOTAL_RESULTS"] . " results<BR>"; ?>

[beandip]

Originally posted by Nate
1) i tested it with only 1 result on my test page and it didnt link the next or previous links on mine. sounds like there may be a few bugs left... i would check the print_r($InfoArray) again and make sure PREV_PAGE and NEXT_PAGE are both empty.

I figured there was a bug left, I'm just trying to track it down. I inserted the following piece of code into my searchresults page and then I did a search that turned up 20 results. Here is what was printed off:

Array
(
    [PREV_PAGE] => 
    [NEXT_PAGE] => 2
    [CURRENT_PAGE] => 1
    [TOTAL_PAGES] => 17
    [TOTAL_RESULTS] => 813
    [PAGE_NUMBERS] => Array
        (
            [0] => 1
            [1] => 2
            [2] => 3
            [3] => 4
            [4] => 5
            [5] => 6
            [6] => 7
            [7] => 8
            [8] => 9
            [9] => 10
        )

[MYSQL_LIMIT1] => 0
[MYSQL_LIMIT2] => 50
[START_OFFSET] => 0
[END_OFFSET] => 50
[RESULTS_PER_PAGE] => 50
)

So I guess I am curious about the InfoArray. Should the variable TotalResults end up with the number of total records in the database? or should it get the number of records found for each specific query? In other words, as it is coded now, it is finding 813 records, and I'm returning 50 results per page, so it is calculating a total of 17 pages necessary. However the query I performed only turned up 20 results. That should have resulted in 1 page, right? or am I missing something in the way it should work?

2) If i understand correctly, you just want to do this?

<?php echo "Found " . $num . " of " . $InfoArray["TOTAL_RESULTS"] . " results<BR>"; ?> [/B]

Oh geesh... that was pretty obvious. Thank you so much for pointing that out, it was exactly what I wanted.

[Nate]

I see the problem, and based on your last post, i think you may have almost figured it out too... (I should have noticed this before!)

Your first query where you tell it how many total results there are:

    /*tell it how many results to page through */  

    $sql1 = "SELECT COUNT(*) as Total FROM Accounts";  

    $query = mysql_query($sql1);  

    $data = mysql_fetch_array($query);  

    $paging->TotalResults = $data['Total'];

You should change that to only return results you want to page through, not your entire table. So essentially it is exactly the same query as:

$sql2 = "select * from Accounts where UserName like '$username_query%' AND Last like '$lastname_query%' order by Last LIMIT ".$InfoArray["MYSQL_LIMIT1"].", ".$InfoArray["MYSQL_LIMIT2"]; 

but without the LIMIT...

Then when you print out the InfoArray you would see the TOTAL_RESULTS variable become 20 and both NEXT_PAGE and PREV_PAGE would be blank.

[bretticus]

but without the LIMIT...

Didn't really read a whole lot of the above posts, I just get the email notifications for posts I have posted to....BUT, you should have either referenced my class or just used it instead 😃

[beandip]

Nate,

Thanks for your great assistance throughout this project of mine. You can not believe how much about PHP I've learned just by integrating your paging class into my code.

Hey, I'd like to give you credit in my paging.class.php file... Should I just put credit to Nate at PHPbuilder.com? or do you have some additional info? Feel free to send me a private message if you'd like.

Bretticus... I appreciated your input and additional code, but in order to really learn what I was doing I needed to stay with one piece of code and work through it. Now that I have, I can probably go back through and your code will make a lot more sense to me.

Thanks again!

[bretticus]

I understand completely, do not want to offend nor am I trouncing on Nate's code (I was the original complementor afterall.) I, in a very simplistic way, anticipated the "LIMIT" issue and it's addressed within my class where (again) Nate's is more generic (he did nothing wrong.) Glad you learned alot. That's the coolest part.

[beandip]

Hmmm... to clean this up I think I'd like to make more one change. When a search result turns up zero responses, I'd like to display a response to the user indicating something like "No results found, please refine your search."

I'm guessing this would need to be some kind of IF THEN ELSE statement...

Perhaps along the lines of:

If the query returns results
Then display the search results table...
Else display "no results found."

Since $num is returning the number of rows found in query $sql1, would the If statement somehow indicate:

IF $num > 0
Then (insert search results table code)
Else echo "No results found"

Just taking stabs at this.

[Nate]

yep you got it. basic if/else logic based on $num. if $num is 0, display "no results", else display "found $num results!"

no credit needed by the way, but thanks.