A type of page include using iframes and if/then - security?

[frenziedsilence]

Hello! this is my first post here. I'm in much need of opinions and help here...

I have a fansite for a band, and large image sections. I wrote a little php function to go with my iFrame layout, where you click on a link, and depending on that link, it will bring up the corresponding image gallery in the iframe.

a code example:

<iframe name="photos" 
<? if (!$page) { ?>src="jtpics1a.html"<? }
  elseif ($page == "one") { ?>src="jtpics1a.html"<? }
  elseif ($page == "two") { ?>src="jtpics2a.html"<? }
  elseif ($page == "three") { ?>src="jtpics3a.html"<? }
  elseif ($page == "four") { ?>src="jtpics4a.html"<? }
  elseif ($page == "five") { ?>src="jtpics5a.html"<? } 
  elseif ($page == "six") { ?>src="jtpics6a.html"<? }
  elseif ($page == "seven") { ?>src="jtpics7a.html"<? }
  else { ?>src="404.shtml"<? } ?>frameborder="0" width="466" height="342" marginheight="4" marginwidth="4"></iframe></td>
   <td width="252" height="395" align="right" valign="top"> 
     <div align="right"> 
       <p><img src="images/jtphotosbg.jpg" width="252" height="342"><br>
         page: <? if (!$page) { ?>
    one. <? } elseif ($page == "one") { ?>
    one.  <? } else { ?>
    <a href="jtpics.php?page=one">one</a>. <? }
    if ($page == "two") { ?>
    two. <? } else { ?>
           <a href="jtpics.php?page=two">two</a>. <? } 
    if ($page == "three") { ?>
    three. <? } else { ?>
    <a href="jtpics.php?page=three">three</a>. <? }
  if ($page == "four") { ?>
  four. <? } else { ?>
  <a href="jtpics.php?page=four">four</a>. <? }
  if ($page == "five") { ?>
  five. <? } else { ?>
           <a href="jtpics.php?page=five">five</a>. <? } 
  if ($page == "six") { ?>
  six. <? } else { ?>
  <a href="jtpics.php?page=six">six</a>. <? } 
  if ($page == "seven") { ?>
  seven. <? } else { ?>
  <a href="jtpics.php?page=seven">seven</a>.<? } ?>

now. would this allow any kind of interruption in the pages? i specified that if there is no page or anything but what i put in the code, it should go to page 1 or 404.....

the reason i ask is that someone keeps hacking in and uploading files to my site, and my host really seems to think this is the problem, and is getting quite snippety with me about it. :/

any help much appreciated... thanks 🙂

[designguy79]

Your code is extremely difficult to read!

I would suggest learning how to use the "switch" statement:

http://us4.php.net/manual/en/control-structures.switch.php

Also, it will help clean up your code if you wait until all the PHP is done before "switching" back to HTML.

For example, instead of:

Hello <img src="<? ... code here... ?>" width="<? ... more code here... ?>" height="<? ...and again here... ?>">

This is much better:

<?

... run all the code here...

$img_src = "one.jpg";
$img_height = 200;
$img_width = 300;

echo "<img src=\"$img_src\" height=\"$img_height\" width=\"$img_width\">

?>

Does that make sense?

[frenziedsilence]

oh, thanks for looking at that! yeah... it is really bad coding. lol
the first time i'd ever tried writing something myself.
this code is on some image galleries i have on a fan site, and the pictures are growing. i'm thinking of just using a gallery script anyway. it's too much to do by hand anymore! :queasy:

thanks again for the suggestions - i'll definitely check out that 'switch' function. 🙂