simplified loop

dreams4000

I'm trying to make this as simple as I can for folks to understand in hopes that someone will see something that I am not. I am trying to loop through a value via php so that a mysql call can see the value. The mysql call does work for connecting to the database. My problem is the value that is being seen in the variable is only the last value being pulled, not cycling through each. $tccategoryDetail->tccategory_id[$c] below will echo as 367 where 3 is one value 6 is another and 7 is another. But in the query, the call seems to only be seeing it as 7, instead of running as 3, then 6 then 7.. Anyone know why this would loop that way? (or lack thereof)

for ($c=0;$c<$compttccategoryDetail;$c++) {

$tmpquery12 = "WHERE tcsub_category.category_id = '".$tccategoryDetail->tccategory_id[$c]."'";

}

ZibingsCoder

Use this instead..


$tmpquery12 = "WHERE ";

for ($c=0;$c<$compttccategoryDetail;$c++) { 

   if ( $c = 0 )
   {
      $tmpquery12 .= "tcsub_category.category_id = '".$tccategoryDetail->tccategory_id[$c]."'";
   }

   else
   {
      $tmpquery12 .= " AND tcsub_category.category_id ='".$tccategoryDetail->tccategory_id[$c]."'";
   }

}

dreams4000

That seems to time out php. Could that be because it might be running a "WHERE AND" tcsub_category.... instead of something before the and?

edit: tried putting something after the where, and still times out. 🙁

tsinka

Hi,

a little typo ...

replace
if ( $c = 0 )
by
if ( $c == 0 )

Thomas

tsinka

If I understood you right you want to get the results for several ids. In this case you need to use OR instead of AND or you can do it like this:

$tmpquery12 = "WHERE tcsub_category.category_id IN ('"; 
$ids=array();
for ($c=0;$c<$compttccategoryDetail;$c++) {  

  $ids[] = $tccategoryDetail->tccategory_id[$c];
}

$tmpquery12 .= implode("','",$ids)."')";

Thomas

dreams4000

That almost gets it, but is doing them all in one query. I tried to explain this one in a little more detail in another post before but no one seemed to know. What I am doing is having another query spit out category listings.. so category 1, category 2.. etc.. each with an id. Then the query above is supposed to loop through the category ids and match up sub categories to them(via a column in the sub cat table that has cat ids).. so in our loop, where subcategory.category id = cat 1 id... where subcategory.category id = cat 2 id... etc. That way it runs a call for each main category to match up its sub categories. Right now, it looks like the call in this post seems to be throwing all of the sub categories under all of the categories. Any ideas on clearing that item up? thanks so much for your time and help with this!

tsinka

Hi,

in this case your code might need some more tweaking. Please post the complete part of the code that deals with the category ids and the subcategories.

Thomas

dreams4000

//Pulls all the available Categories.. each has unique ids
$tmpquery = "WHERE tccategory.id  != '0'";
$tccategoryDetail = new request();
$tccategoryDetail->opentccategory($tmpquery);
$compttccategoryDetail = count($tccategoryDetail->tccategory_id);

//Code below should match up sub categories to the categories found above.  "New Code" is the code from the post above.
//*** New Code
$tmpquery12 = "WHERE tcsub_category.category_id IN ('";  

$ids=array(); 
for ($c=0;$c<$compttccategoryDetail;$c++) {   

  $ids[] = $tccategoryDetail->tccategory_id[$c]; 
} 

$tmpquery12 .= implode("','",$ids)."')";
//*** New Code

$tcsubcategoryDetail = new request();
$tcsubcategoryDetail->opentcsub_category($tmpquery12);
$compttcsubcategoryDetail = count($tcsubcategoryDetail->tcsub_category_id);

After this runs, I have it attempting to loop through the names found and printing those.. there is a bit more to the code, but this is the section that deals with the above calls:

for ($v=0;$v<$compttcsubcategoryDetail;$v++) {	

$name3 = $tcsubcategoryDetail->tcsub_category_name[$v];						echo "['$name3',null\n\n,]";

}

All this is doing is making a setup that displays like:

Cat 1
---Sub Cat 1
---Sub Cat 2

Cat 2
--- Sub cat 3
--- Sub cat 4

Cat 1 and 2 are working fine, and the problem lies in that under those, right now, all of the sub cats are showing in each category instead of matched up where they belong. I hope this helps explain it all. Thanks!

ZibingsCoder

Oooohhh. I get it now. 🙂

This is just pseudo code, but it'll demonstrate what to do to get what you need.


//we'll assume we already have the main category query done

for ( $i = 0; $i < $numrows; $i++ )
{
   $str = "SELECT `subcat_id` FROM `subcats` WHERE `cat_id`='{$categories[$i]['cat_id']}'";

   $query = mysql_query($str);

   while ( $row = mysql_fetch_row($query) )
   {
      $categories[$i]['subcats'][] = $row;
   }
}

This kind of what you were looking for?

PS - Sorry for the typo, I had just left an hour and a half's worth of mind numbing microeconomics...and lemme tell ya that's no fun.

tsinka

Ok,

I don't know what the classes do but generally you can do something like this:

First select the categories and create a array out of them that looks like:

$cats = array("catid1" => "catname1","catid2" => "catname2", ....)

Then get the subcategories (the rows catid,subcatid,subcatname) with the second query, walk through the result set and create an array that looks like

$subcats = array("catid1" => array("subid1" => "subname1","subid2" => "subname2", ....),
                 "catid2" => array("subid3" => "subname3", "subid4" => "subname4",...),
                 ......)

You should then be able to print the data with something like:

foreach ($cats as $key => $value) {
  echo $cats[$key]."<br>\n";
  if (isset($subcats[$key]) && is_array($subcats[$key])) {
    foreach ($subcats[$key] as $key2 => $value2) {
      echo "--".$value2."<br>\n";
    }
  }
}

You might need to tweak the code a little bit to fit into your classes but something like that should work.

Thomas

dreams4000

zibings, is this kind of what you were doing? I am not quite sure how to run that based off the earlier stuff.


//*** New Code
for ($i=0;$i<$compttccategoryDetail;$i++) {

$tmpquery12 = "WHERE tcsub_category.category_id  = '".$tccategoryDetail->tccategory_id[$i]."'";


$tcsubcategoryDetail = new request();
$tcsubcategoryDetail->opentcsub_category($tmpquery12);
$compttcsubcategoryDetail = count($tcsubcategoryDetail->tcsub_category_id);


while ( $row = mysql_fetch_row($compttcsubcategoryDetail) ) 
   { 
      $tcsubcategoryDetail->tccategory_id[] = $row; 
   }
   echo $tcsubcategoryDetail->tcsub_category_id[$i];

}
//*** New Code

tsinka, all the classes are doing are premade mysql queries.. so that all that has to be run is the WHERE clause on.. this wasn't my program so I am just going with how the rest of it is written. would like to stick with the methods it uses if I could.

ZibingsCoder

No, the code in my second post is totally unrelated to that in my first post. The second post is just basically what you do.

It is supposed to show you that you run a query on each category, grabbing all of the subcategories, and then add them to the information for the first category so that they can be looped through.

dreams4000

since I can't match my sql calls like the ones you have there, as the program is using its own sql system, is there any way to do what you are trying to do, but with the code I put in here? Thanks!

ZibingsCoder

Here, guessed a bit with your class structure, but...I think we've got it now.

for ( $c = 0; $c < $compttccategoryDetail; $c++ )
{
	echo ( $tccategoryDetail->tccategory_name[$c]."<br />" );

$tmpquery12 = "WHERE tcsub_category.category_id = '".$tccategoryDetail->tccategory_id[$c]."'";
$tcsubcategoryDetail = new request();
$tcsubcategoryDetail->opentcsub_category($tmpquery12);
$compttcsubcategoryDetail = count($tcsubcategoryDetail->tcsub_category_id);

for ( $c2 = 0; $c2 < $compttcsubcategoryDetail; $c2++ )
{
	echo ( "--{$tcsubcategoryDetail->tcsub_category_name[$c2]}<br />" );
}
}

dreams4000

Thanks for all the help with this man! I do appreciate it. I am going to play with that code and see if I can get it fitting into the doc. I wont bother ya anymore about it🙂 Thanks so much!