return array from function

martincrumlish

Hi,

I have the following function in one of my scripts. It basically runs a mySQL query (a SELECT) and is supposed to return an array of values but I can't seem to get it working. Does anyone see anything wrong with it?

Thanks,
Martin

function getarray($q){
	if(!$result = mysql_query($q)){
		return mysql_error();
	}
	else{
		$item = array();
		while($item = mysql_fetch_array($result)){
			$row[] = $item;
		}
		return $row;
	}
}

//I use it like this
$row = getarray("SELECT title FROM job");
for($i = 0;$i<=sizeOf($row);$i++){
	echo $row['title'];
}

Frederick

Looks like you are trying to do a simple query.

$sql = mysql_query("SELECT * FROM job") or die (mysql_error());
if (mysql_num_rows($sql)) {
    for ($i = 0; $i < $row = mysql_fetch_array($sql); $i++) {
        echo $row["title"] . "<br>\n";
    }
} else {
    echo "No Results Forund\n";
}

I used the $i variable and for loop because of your example above.

mohausa


<?
  	mysql_connect("localhost", "root", "") or die("Could not connect");
	mysql_select_db("databaseName");


function getarray($query){ 
    if(!$result = mysql_query($query)){ 
        return mysql_error(); 
    } 
    else{ 
        while($item = mysql_fetch_array($result)){ 
            $row[] = $item['title']; 
        } 
        return $row; 
    } 
} 

$row = getarray("SELECT * FROM job"); 
for($i = 0;$i<=sizeOf($row);$i++){ 
    echo $row[$i]."<br>"; 
}

?>

martincrumlish

Thanks for the replies Frederick and mohausa.

Frederick - the query I used is just a simple 1 for the purposes of the example. I actually want to get it all encapsulated in a function.

I have got it working now with a few tweaks.

Thanks

function getarray($q){
	if(!$result = mysql_query($q)){
		return mysql_error();
	}
	else{
		$item = array();
		while($item = mysql_fetch_assoc($result)){
			$row = $item;
			$arraycount++;
		}
		return $row;
		return $arraycount;
	}
}

$row = getarray("SELECT * FROM job");
for($i = 0;$i<=$arraycount;$i++){
	echo $row['experience'];
}