2 isn't 2?

Shawazi

Here is my code and for some reason it does not select the right choice.

			$result = mysql_query("select * from subjects order by name");
			while ($row = mysql_fetch_array($result))
			{
				echo "<option value='$row[id]' ";
				if ($row[id] == $prow[sid]) echo "selected";
				echo ">$row[name] if ($row[id] == $prow[sid]) echo \"selected\";</option>";
			}
			?>

The echo shows that 2 == 2 yet selected is never echoed

Shawazi

I fixed it by making it "$row[id]" == "$row[sid]" when I did not need to put those quotes on that code I've used elsewhere. Any idea why it would not work without quotes sometimes?

Weedpacket

Not off-hand, unless one of those 2's is actually 2.000000000000001 or something like that. Incidentally, you should always be quoting your associative array indices in code (but not in strings): if($row['id']==$prow['sid']). That makes me think of another reason: you've got a defined constant named "id" or "sid" hanging around: using quotes on your array indices would fix that.

laserlight

Actually, you probably should quote associative indices in strings as well, if you would normally quote them outside of strings.

$result = mysql_query("SELECT * FROM subjects ORDER BY name");
while ($row = mysql_fetch_array($result))
{
	echo "<option value='{$row['id']}' ";
	if ($row['id'] == $prow['sid']) echo "selected";
	echo ">{$row['name']}";
	if ($row['id'] == $prow['sid']) echo \" selected\";</option>";
}