[Resolved] defined(CONSTANT) generates error when false?!?

[bunner_bob]

I'm using a defined constant as a flag to enable/disable certain site functionality:

define('SHOW_SOMETHING','true');

if (defined(SHOW_SOMETHING)) {
    // do stuff
}

Problem is, when I want to disable this functionality (by commenting out the "define()" line), I get an "undefined constant" Notice error.

Of course the constant is undefined - all I'm doing is checking, which should result in a true/false, not an error - right? Or am I doing this wrong?

• Bob

[Weedpacket]

Originally posted by bunner bob
Or am I doing this wrong?

Only slightly:

defined('SHOW_SOMETHING');

It's a bit subtle, but you're wanting to see if a constant with the given name is defined, which is not the same thing as looking at its value. It's like the use-mention distinction in English.

On the other hand, you could leave it defined and use

define('SHOW_SOMETHING',true);
if(SHOW_SOMETHING)
{...}

And then when you don't want to SHOW_SOMETHING define it to false. That might make things more convenient in your code.

[bunner_bob]

Spiffy - thanks. I'll go with the former option because it's quicker to type a couple of slashes to comment it out, and also more obvious with the color coding in my texteditor.

• Bob