upload a file, and insert info in database, with one form?

Fking

well i have a form which entries are saved in a database

now i added a field in the same form, where the user inputs a file, and it's moved in a directory on the server.

according to this http://www.php.net/manual/en/features.file-upload.php

i have to add enctype="multipart/form-data"
in the <form> tag

well when i add it, the image moving works, but the database insertation doesn't

when remove it, i again can insert info into the databse, but the image moving does not work.....

the file in the ACTION="" tag consist both, the code for image moving, and the code quering and inserting into the databse.....

tsinka

Please post the code you're having problems with.

Thomas

Fking

this is the form which is in index.php

<FORM   METHOD=POST ACTION="addentries.php">

<TABLE width="500">
END;

for ($i=1; $i<=$num_to_loop; $i++) {
echo <<<END
    <TR>
        <TD colspan="2" bgcolor="#666666"><B>Entry $i </B></TD>
    </TR>
    <TR>
        <TD width="150">Title</TD>
        <TD width="350"><INPUT TYPE="text" NAME="search_title[]"></TD>
    </TR>
<TR>
        <TD>TitleBG</TD>
        <TD><INPUT TYPE="text" NAME="search_titlebg[]"></TD>
    </TR>
    <TR>
        <TD>Description</TD>
        <TD><INPUT TYPE="text" NAME="search_description[]"></TD>
    </TR>
    <TR>
        <TD>Artist</TD>
        <TD><INPUT TYPE="text" NAME="search_artists[]"></TD>
		<TD>Artist2</TD>
        <TD><INPUT TYPE="text" NAME="search_artists2[]"></TD>
		<TD>Artist3</TD>
        <TD><INPUT TYPE="text" NAME="search_artists3[]"></TD>
		<TD>Artist4</TD>
        <TD><INPUT TYPE="text" NAME="search_artists4[]"></TD>
    </TR>

<TR>
        <TD>Genre</TD>
        <TD><select name="search_genre[]">
  <option value="Action" selected>Action</option>
  <option value="Comedy">Comedy</option>
   <option value="Thriller">Thriller</option>
    <option value="Horror">Horror</option>
	    <option value="Fantastic>Fantastic</option>
	 <option value="Drama">Drama</option>
	   <option value="Adventure">Adventure</option>
	     <option value="Military">Military</option>
		   <option value="Criminal">Criminal</option>
		     <option value="Romantic">Romantic</option>
	  <option value="Documentary">Documentary</option>	
	   <option value="Erotic">Erotic</option>

</select></TD>

<TD>Genre2</TD>
        <TD><select name="search_genre2[]">
		<option value="" selected></option>
  <option value="Action" >Action</option>
  <option value="Comedy">Comedy</option>
   <option value="Thriller">Thriller</option>
    <option value="Horror">Horror</option>
	    <option value="Fantastic>Fantastic</option>
	 <option value="Drama">Drama</option>
	   <option value="Adventure">Adventure</option>
	     <option value="Military">Military</option>
		   <option value="Criminal">Criminal</option>
		     <option value="Romantic">Romantic</option>
	  <option value="Documentary">Documentary</option>	
	   <option value="Erotic">Erotic</option>

</select></TD>

<TD>Genre3</TD>
        <TD><select name="search_genre3[]">
  <option value="" selected></option>
  <option value="Action" >Action</option>
  <option value="Comedy">Comedy</option>
   <option value="Thriller">Thriller</option>
    <option value="Horror">Horror</option>
	    <option value="Fantastic>Fantastic</option>
	 <option value="Drama">Drama</option>
	   <option value="Adventure">Adventure</option>
	     <option value="Military">Military</option>
		   <option value="Criminal">Criminal</option>
		     <option value="Romantic">Romantic</option>
	  <option value="Documentary">Documentary</option>	
	   <option value="Erotic">Erotic</option>

</select></TD>
    </TR>

<TR>
        <TD>Subs</TD>
        <TD><select name="search_subs[]">
  <option value="Yes" selected>Yes</option>
  <option value="No">No</option>

</select></TD>
    </TR>


<TR>
    <TD>URL</TD>
    <TD><INPUT TYPE="file" NAME="search_url[]"></TD>
<TD>URL2</TD>
        <TD><INPUT TYPE="file" NAME="search_url2[]"></TD>
<TD>URL3</TD>
        <TD><INPUT TYPE="file" NAME="search_url3[]"></TD>

</TR>
<TR>
    <TD>Pic</TD>
    <TD><input type="hidden" name="MAX_FILE_SIZE" value="30000" />
 <input  enctype="multipart/form-data" name="userfile" type="file" /></TD>
    </TR>
END;
}

echo <<<END
    <TR>
        <TD>&nbsp;</TD>
        <TD>$submit_info</TD>
    </TR>
</TABLE>

</FORM>

from the code above

is the field where should be entered the image url
and moved in a direcotry on the server
everything else should be inserted in the database

in addentries.php
this is the code which uploads the image

$uploaddir = '../pic/';
$query="SELECT id FROM movies WHERE 1 ORDER BY id DESC LIMIT 1";
$result= mysql_query($query) or die("Update eror: ".mysql_error());
$lastid = mysql_fetch_array($result, MYSQL_ASSOC);
$lastid['id']++;
$uploadfile = $uploaddir . $lastid['id'] . ".jpg";

print "<pre>";
if (move_uploaded_file($_FILES['userfile']['tmp_name'], $uploadfile)) {
   print "File is valid, and was successfully uploaded. ";
   print "Here's some more debugging info:\n";
   print_r($_FILES);
} else {
   print "Possible file upload attack!  Here's some debugging info:\n";
   print_r($_FILES);
}
print "</pre>";

the rest code in addentries.php is for inserting the another fields from the form into the database, but is too long to post

when add to the form in index.php
enctype="multipart/form-data"
the image upload works
but does not insert anything in the database, and gives a msg that there is a empty field in the form

when remove enctype="multipart/form-data"
inserts everything in the databse, but does not upload the image...

Fking

this is what i got when enctype="multipart/form-data" is added

File is valid, and was successfully uploaded. Here's some more debugging info:
Array
(
[search_url] => Array
(
[name] => Array
(
[0] => fsdfds
)

        [type] => Array
            (
                [0] => application/octet-stream
            )

        [tmp_name] => Array
            (
                [0] => /tmp/php2tRCYa
            )

        [error] => Array
            (
                [0] => 0
            )

        [size] => Array
            (
                [0] => 0
            )

    )

[search_url2] => Array
    (
        [name] => Array
            (
                [0] => 
            )

        [type] => Array
            (
                [0] => 
            )

        [tmp_name] => Array
            (
                [0] => 
            )

        [error] => Array
            (
                [0] => 4
            )

        [size] => Array
            (
                [0] => 0
            )

    )

[search_url3] => Array
    (
        [name] => Array
            (
                [0] => 
            )

        [type] => Array
            (
                [0] => 
            )

        [tmp_name] => Array
            (
                [0] => 
            )

        [error] => Array
            (
                [0] => 4
            )

        [size] => Array
            (
                [0] => 0
            )

    )

[userfile] => Array
    (
        [name] => 11954.jpg
        [type] => application/octet-stream
        [tmp_name] => /tmp/phpWg3oKd
        [error] => 0
        [size] => 0
    )

)

Problem with entry 1 : At least one blank field

tsinka

move enctype="multipart/form-data" from the input to the form tag.

enctype is an attribute of the form tag.

Thomas

Fking

and when the form is without enctype="multipart/form-data"
i got this

Possible file upload attack! Here's some debugging info:
Array
(
)

and the entries of the form are added to the database

so i guess when enctype="multipart/form-data" is added it considers all entries as a files....?

well i need only the Pic field to be considered as file....

Fking

Originally posted by tsinka
move enctype="multipart/form-data" from the input to the form tag.

<form name="theform" method="post" action="addentries.php" enctype="multipart/form-data">

enctype is an attribute of the form tag.

Thomas

oh in the posted code it's in the input tag by mistake

the situation is the same when it's only in the form tag

tsinka

Check the double quotes carefully, I noticed that there are at least two missing in

<option value="Fantastic>Fantastic</option>
It should be
<option value="Fantastic">Fantastic</option>

Thomas

Fking

i fixed that
but the problem is somewhere else

Fking

the problem is that with enctype="multipart/form-data"
in the form tag
it does not want to insert into the database

but without it, don't want to upload the file

tsinka

Hi,

find attached a file (renamed to .txt) I used to test your code. It seems to work like expected.

The entries of the file array with error=4 mean that no file has been submitted with the given file input.

Thomas

tsinka

Forgot to attach the file

Additionally, add the following lines if you want

if (isset($POST) && !empty($POST)) {
print_r($_POST);
}

The submitted post and file variables seem to be ok.

Thomas

Fking

mhm...what to do now ? :<

tsinka

Did my script work in any way ?