problem using a form inside php

Skeelo

I'm sorry that this is a long message but i need help. I had changed a form that i had to add more fields into it and now for some reason i can't submit it anymore. The below is the form that didn't work, below that is one that does.

<?PHP
echo "<form action=\"modules.php?name=$module_name\" method=\"post\">\n"
."<b>".REGNEWUSER."</b> (".ALLREQUIRED.")<br><br>\n"
."<table cellpadding=\"0\" cellspacing=\"10\" border=\"0\">\n"
."<tr><td width=\"120\">".MEMBERACCTYP.":</td><td>"
."<select name=\"user_membership\" size=\"1\" >"
."<option selected value=\"General\">".GENERAL."</option>"
."<option value=\"Student\">".STUDENT."</option>"
."<option value=\"Professional\">".PROFESSIONAL."</option>"
."</select></td></tr>\n"
."<tr><td>".REALNAME.":<br><font class=\"tiny\">(".FIRSTLAST.")</font></td><td><input type=\"text\" name=\"name\" size=\"30\" maxlength=\"25\"></td></tr>\n"
."<tr><td>".UUSERNAME.":</td><td><input type=\"text\" name=\"username\" size=\"30\" maxlength=\"25\"></td></tr>\n"
."<tr><td>".EMAIL.":</td><td><input type=\"text\" name=\"user_email\" size=\"30\" maxlength=\"255\"></td></tr>\n"
."<tr><td>".ADDRESS.":</td><td><input type=\"text\" name=\"user_address\" size=\"30\" maxlength=\"255\"></td></tr>\n"
// STATES
."<tr><td>".STATE.":</td>"
."<td><select name=\"user_state\" size=\"1\">";
while($row = $db->sql_fetchrow($result4)) {
$state = $row['state'];
$state_abbr = $row['state_abbr'];
$state_id = $row['state_id'];
echo "<option value=\"$state_id\">$state_abbr</option>";
}
echo "</select>"
."       ".ZIP.":   <input type=\"text\" name=\"user_zip\" size=\"5\" maxlength=\"5\"></td></tr>\n"
// COUNTRY
."<tr><td>".COUNTRY.":</td>"
."<td><select name=\"user_country\" size=\"1\">";
while($row = $db->sql_fetchrow($result3)) {
$country = $row['country'];
$country_id = $row['country_id'];
echo "<option value=\"$country_id\">$country</option>";
}
echo "<tr><td>".BDAY.":</td><td><input type=\"text\" name=\"user_bday\" value=\"0000-00-00\"size=\"10\" maxlength=\"10\">".BDAYIE."</td></tr>\n"
."<tr><td>".GENDER.":</td><td>"
."<select name=\"user_gender\" size=\"1\">"
."<option selected value=\"select\">select</option>"
."<option value=\"Male\">".MALE."</option>"
."<option value=\"Female\">"._FEMALE."</option>"
."</select></td></tr><br>\n";

    // START OF A NEW TABLE
    // NEW HEADER CHURCH INFORMANTION
    echo "<tr><td><b>"._CHURCHINFO."</b><br><br></td></tr>\n"
    ."<tr><td width=\"120\">"._CHURCHDENOM.":</td><td>"
    ."<select name=\"user_church_denom\" size=\"1\">"
	    ."<option selected value=\"select\">select</option>"
    ."<option value=\"denom1\">DEFINE IN LANG</option>"
    ."<option value=\"denom2\">DEFINE IN LANG</option>"
    ."</select></td></tr>\n"
    ."<tr><td>"._CHURCHNAME.":</td><td><input type=\"text\" name=\"user_church_name\" size=\"25\" maxlength=\"255\"></td></tr>\n"
    ."<tr><td>"._CHURCHSIZE.":</td><td>"
    ."<select name=\"user_church_size\" size=\"1\" >"
    ."<option value=\"0-100\">0 - 100</option>"
    ."<option value=\"101-500\">101 - 500</option>"
    ."<option value=\"501-1000\">501 - 1000</option>"
    ."<option value=\"1001-3000\">1001 - 3000</option>"
    ."<option value=\"3001-5000\">3001 - 5000</option>"
    ."<option value=\"5000+\">5000+</option>"
    ."</select></td></tr><br>\n";

    // START OF A NEW TABLE
    // NEW HEADER CHURCH INVOLVEMENT 	    
     echo "<tr><td><b>"._CHURCHINV."</b><br><br></td></tr>\n"
    ."<tr><td width=\"120\">"._CHURCHSTAFF.":</td><td>"
    ."<select name=\"user_onstaff\" size=\"1\">"
	    ."<option selected value=\"select\">"._SELECT."</option>"
	    ."<option value=\"Full Time\">"._FULLTIME."</option>"
    ."<option value=\"Part-Time\">"._PARTTIME."</option>"
    ."<option value=\"Volunteer\">"._VOLUNTEER."</option>"
    ."<option value=\"No\">"._NO."</option>"
    ."</select><br></td></tr>\n"
    //Check boxes for involvement in worship
    ."<tr><td width=\"120\">"._YRSINVWORSHIP.":</td><td>"
    ."<select name=\"user_yrs_inv_wor\" size=\"1\">"
    ."<option value=\"less than 1yr\">"._LESS1YR."</option>"
    ."<option value=\"1-3yrs\">1 - 3 yrs</option>"
    ."<option value=\"3-5yrs\">3 - 5 yrs</option>"
    ."<option value=\"5-10yrs\">5 - 10 yrs</option>"
    ."<option value=\"10-20yrs\">10 - 20 yrs</option>"
    ."<option value=\"20+yrs\">"._MORE20YRS."</option>"
    ."</select></td></tr><br>\n";

    //START NEW SECTION MISC.
     echo "<tr><td><b>"._FINALSECT."</b><br><br</td></tr>\n"
    ."<table cellpadding=\"0\" cellspacing=\"10\" border=\"0\" >\n"	    
    ."<tr><td>"._HEARNWLA.":</td><td>"
    ."<select name=\"user_hear_nwla\" size=\"1\" >"
    ."<option value=\"word of mouth\">"._WORDMOUTH."</option>"
    ."<option value=\"email\">"._EMAIL."</option>"
    ."<option value=\"church\">"._CHURCH."</option>"
    ."<option value=\"event\">"._EVENT."</option>"
    ."<option value=\"magazine\">"._MAGAZINE."</option>"
    ."<option value=\"website\">"._WEBSITE."</option>"
    ."<option value=\"meeting\">"._MEETING."</option>"
    ."<option value=\"other\">"._OTHER."</option>"
    ."</select></td></tr>\n"
    ."<tr><td>"._DOULISTSERV.":</td><td>"
    ."<select name=\"user_listserv\" size=\"1\" >"
    ."<option value=\"yes\">"._YES."</option>"
    ."<option value=\"no\">"._NO."</option>"
    ."</select></td></tr>\n";
echo "<tr><td>"._RECEIVENEWSLETTER."</td><td>";
echo "<input type=\"radio\" name=\"newsletter\" value=\"1\" checked>"._YES." &nbsp;"
	."<input type=\"radio\" name=\"newsletter\" value=\"0\">"._NO."";
echo "</td></tr>"
    ."<input type=\"hidden\" name=\"user_password\" size=\"11\" maxlength=\"40\">\n"
    ."<input type=\"hidden\" name=\"user_password2\" size=\"11\" maxlength=\"40\">\n";
if (extension_loaded("gd") AND ($gfx_chk == 3 OR $gfx_chk == 4 OR $gfx_chk == 6 OR $gfx_chk == 7)) {
    echo "<tr><td>"._SECURITYCODE.":</td><td><img src='modules.php?name=$module_name&op=gfx&random_num=$random_num' border='1' alt='"._SECURITYCODE."' title='"._SECURITYCODE."'></td></tr>\n"
        ."<tr><td>"._TYPESECCODE.":</td><td><input type=\"text\" NAME=\"gfx_check\" SIZE=\"7\" MAXLENGTH=\"6\"></td></tr>\n"
        ."<input type=\"hidden\" name=\"random_num\" value=\"$random_num\">\n";
}
echo "<tr><td colspan='2'>\n"
    ."<input type=\"hidden\" name=\"op\" value=\"new user\">\n"
	    ."<input type=\"submit\" value=\""._NEWUSER."\">\n"
	    ."</td></tr></table>\n"
	    ."</form>\n"
    ."<br>\n"

below works

<? echo "<form action=\"modules.php?name=$module_name\" method=\"post\">\n"
."<b>".REGNEWUSER."</b> (".ALLREQUIRED.")<br><br>\n"
."<table cellpadding=\"0\" cellspacing=\"10\" border=\"0\">\n"
."<tr><td>".NICKNAME.":</td><td><input type=\"text\" name=\"username\" size=\"30\" maxlength=\"25\"></td></tr>\n"
."<tr><td>".EMAIL.":</td><td><input type=\"text\" name=\"user_email\" size=\"30\" maxlength=\"255\"></td></tr>\n"
."<tr><td>".PASSWORD.":</td><td><input type=\"password\" name=\"user_password\" size=\"11\" maxlength=\"40\"></td></tr>\n"
."<tr><td>".RETYPEPASSWORD.":</td><td><input type=\"password\" name=\"user_password2\" size=\"11\" maxlength=\"40\"><br><font class=\"tiny\">(".BLANKFORAUTO.")</font></td></tr>\n";
if (extension_loaded("gd") AND ($gfx_chk == 3 OR $gfx_chk == 4 OR $gfx_chk == 6 OR $gfx_chk == 7)) {
echo "<tr><td>".SECURITYCODE.":</td><td><img src='modules.php?name=$module_name&op=gfx&random_num=$random_num' border='1' alt='".SECURITYCODE."' title='".SECURITYCODE."'></td></tr>\n"
."<tr><td>".TYPESECCODE.":</td><td><input type=\"text\" NAME=\"gfx_check\" SIZE=\"7\" MAXLENGTH=\"6\"></td></tr>\n"
."<input type=\"hidden\" name=\"random_num\" value=\"$random_num\">\n";
}
echo "<tr><td colspan='2'>\n"
."<input type=\"hidden\" name=\"op\" value=\"new user\">\n"
."<input type=\"submit\" value=\"".NEWUSER."\">\n"
."</td></tr></table>\n"
."</form>\n"
."<br>\n"
?>

If anyone could help me with this I would be soo thankfull...

nemonoman

Please be helpful to your colleagues and tell us what sort of error you are getting. Also what did you change between working and non-working versions?

Frederick

This
while($row = $db->sql_fetchrow($result4)) {
should be
while($row = mysql_fetch_row($result4)) {

no need to call the DB connection if it is already present. ( $db )

Skeelo

Thank you, I found out what the problem was there was a variable being used twice in the php code and it was giving me an error.