vairable being wrongly set, strange

[Paul_Ferrie]

This script check to see if a search has been submitted and then set the vairables for the query

if(empty($pagenum)) 
$pagenum = 1; 
// if string is populated then use that for the query
if (!empty($str))
$str = $str;  

// if orders is empty then set artist as default.  It dosn't!!!	  

if (empty($orders))
$orders = "artists";
// if search has bee submitted get the details        

if ((!empty($select))&& $select=="artists");
$str = $strings;
$orders = "artists";

if ((!empty($select))&& $select=="titler");
$str = $strings;
$orders = "titler";

if ((!empty($select))&& $select=="labeler");
$str = $strings;
$orders = "labeler";

if ((!empty($select))&& $select=="genre");
$str = $strings;
$orders = "genre";

For some reason $orders is constantly genre. i cant see where i am going wrong.
Example:
http://www.ancilehosting.co.uk/~pferrie/records4sale/phpHTML/list.php

The query:

$result = mysql_query("SELECT * FROM records4sale WHERE artists LIKE '%$str%' OR titler LIKE '%$str%' OR labeler LIKE '%$str%' OR genre LIKE '%$str%' ORDER BY '$orders' LIMIT $limitvalue, $limit");

Cheers for any help
Paul

[Weedpacket]

This sounds like the situation covered in the FAQ in the Newbies' Forum. Question One.

[bubblenut]

Where does the variable $strings come from?
Although I think where the actual problem lies is that you have no braces around your conditional blocks. If you don't use braces then only the line directly after the if statment will be in that conditional block, so, in you case, $orders will always be equal to "Genre".

Try this as a start. Also have a read up on register_globals and the $POST, $GET & $_REQUEST superglobals arrays as they would be preferable to relying on register_globals being on as it apears you are.

if(empty($pagenum)) 
$pagenum = 1; 
// if string is populated then use that for the query
if (!empty($str))
$str = $str;  

// if orders is empty then set artist as default.  It dosn't!!!      

if (empty($orders))
$orders = "artists";
// if search has bee submitted get the details        

if ((!empty($select))&& $select=="artists") {
$str = $strings;
$orders = "artists";
}

if ((!empty($select))&& $select=="titler") {
$str = $strings;
$orders = "titler";
}

if ((!empty($select))&& $select=="labeler") {
$str = $strings;
$orders = "labeler";
}

if ((!empty($select))&& $select=="genre") {
$str = $strings;
$orders = "genre";
}

[Paul_Ferrie]

So your saying it should be:

if (empty($_GET['orders'])) 
$orders = "artists";

And so on...
?

Cheers

[Paul_Ferrie]

cheers guys got it sorted 🙂

if(empty($pagenum)) {
  $pagenum = 1; 
  }
if (!empty($str)){
    $strings = $str;   

	}
if (empty($orders)){
   $orders = "artists";
    }
if ((!empty($select))&& $select=="artists"){
    $str = $strings;
	$orders = "artists";
}else if ((!empty($select))&& $select=="titler"){
    $str = $strings;
	$orders = "titler";
}else if ((!empty($select))&& $select=="labeler"){
    $str = $strings;
	$orders = "labeler";
}else if ((!empty($select))&& $select=="genre"){
    $str = $strings;
	$orders = "genre";
	}