[Resolved] Simple Upload Script

stenk

Could some one please tell me why this simple upload script does not work for me

submit_file.html

<HTML>
<HEAD>
<TITLE>File upload</TITLE>
</HEAD>

<BODY>
<H2>Upload</H2>
<FORM ENCTYPE="multipart/form-data" ACTION="upload_file.php" METHOD="POST">
<INPUT TYPE="HIDDEN" NAME="MAX_FILE_SIZE" VALUE="20000">
Filename:
<INPUT NAME="userfile" TYPE="file">
<BR>
<BR>
<INPUT TYPE="submit" VALUE="Send">
</FORM>
</BODY>
</HTML>

upload_file.php

<?
	// check to make sure a file has been submitted
	if ($userfile=="none") {

	// if not, give an error message and quit this script
	echo "No file specified";
	exit;
}

// send the file to a place on the server, and check to see if
// this has been done successfully.
if (move_uploaded_file($userfile, "\\uploads\\".$userfile_name)) {
	echo "Your file has been uploaded.";
} else {
	echo "Could not upload file.";
}
?>

Using PHP 5.0.0 and PHP 4.X.X

Everything looks OK but only echo's "Could not upload file.".
To me there seems to be a problem with the variables. To me they are not declared, but I could be wrong, as I thought this would happen in the submit_file.html.

Kind regards,

stenk

Just a thought. Could this be a Register Globals problem?

In my php.ini file I have REGISTER_GLOBALS => off

Do I need to check in the .htaccess in Apache file also?

Thanks

hyperActive

First of all you should turn the registrar globals on. Theres no such thing as " $userfile_name ". You have to use the global $_FILES to extract your file name / size / type / tmp name.

Your code should look something like this.

 <?
   //check that the submit button is pressed NOTE: Name your submit button "submit"

   if(isset($_POST['submit'])){

     // Shorten the variables. Note you can rename the file here. Justt add any variable or string to newname

     $tmp_name = $_FILES['$userfile']['tmp_name'];
     $new_name = $_FILES['$userfile']['name'];

    // set the directory NOTE Make sure this is CHMODED to 777.

     $dir = "/uploads/";

     // make sure something is being uploaded
     if ($tmp_name != ""){

    // now move the tmp name file to the directory you specified with the new name you specified.

           if (move_uploaded_file($tmp_name, $dir . $new_name)){
           echo "File Uploaded!";
           } else {
           echo " Error during Upload";
            }


    } else {
       echo "Please select a file!";
       exit;
    }

}
?>

Hope that helped!
You can also check php.net's documentation.