grabbing online files problem

tullmejs

Hi, I am new to PHP (and this board), got a little ASP and general programming knowledge.

The below code does work, but doesn't grab all; only the first 19_432 bytes it seems. Why?

<?
$url = "http://uran.nu/nummer.txt";
$file = "grabbat.txt";

ini_set('max_execution_time', '30');
flush ();

$fd= fread(fopen($url, "r"), 10000000);

echo $fd;

$tmpfile = fopen($file,"w+");
$fp = fwrite($tmpfile,$fd);
fclose($tmpfile);
flush ();
?>

(The nummer.txt file contains numbers from 1 upwards, one every row, is just for testing purposes)

The code is live at http://uran.nu/grabbertest.php

LordShryku

The manual page for fread explains this, but I see some other things here. Why are you using ini_set for max execution time? Do you want it to time out after 30 seconds? Also, why use fread? If you're going to just get everything, why not use [man]file_get_contents[/man]? And what's with the flushes? Why are you using them? Flush is used on the output buffer, and in this case, there's nothing to be output.

$url  = "http://uran.nu/nummer.txt";
$file = "grabbat.txt";
if(($fd = file_get_contents($url)) !== false) {
   $tmpfile = fopen($file, "w+");
   fwrite($tmpfile, $fd);
   fclose($tmpfile);
}
else {
   echo 'Could not read '.$url;
}

tullmejs

The code is stolen; the flushes are unknown to me, the timeout was there. Possibly the point of the project I stole from differed from mine (as a matter of fact I know that was the case). Since it worked half way I figured I was on the right track.

I looked into your kind suggestion, it rather works very well, many thanks!

I'll look inte the fread stuff too, amongst other things, for future reference. Thanks again :-)