Confirm on delete problems? No idea why :(

darthmahon

Hey,

Ok using the following code for deleting items:

<a href=\"javascript:;\" onclick=\"confirmDelete('" .$row['fld_id'].",".$section."')\">Delete</a></p>

Reason for the slashes is because it's inside an echo.

Anyway, as you can see I am using Javascript to ask if they are sure they want to delete - here is the code:

function confirmDelete(id,section) {

if (confirm('Are you sure you want to delete this entry?')) {

	window.location = ('admin.php?section=' + section'&type=delete&id=' + id);

} else {

	return false;

}
}

Now, first of all I don't think the javascript is correct. I have different sections that all use the same kind of code to delete, but I don't want to have to create different delete functions for each section, I'd rather pull the name of the section so they can all use the same function.

Any ideas why I am getting an error - it says:

expected ')'

Seems as if I am not putting the variables correctly in the javascript code?

Also when I did get it to work without the sections, it put in something like this for the $id:

fld_id=11,categories - it's putting the id number and the section name in the same variable??

Can anyone help me out here, totally stuck 🙁

Cheers,
Chris

drawmack

function confirmDelete(id,section) {

if (confirm('Are you sure you want to delete this entry?')) {

	window.location = ('admin.php?section=' + section + '&type=delete&id=' + id);

} else {

	return false;

}
}

darthmahon

Yea just realised I needed to put another + sign in.

Problem is with the variables now - it seems to put both the variables put in the javascript below into one variable called $id.

function confirmDelete(id,section) {

if (confirm('Are you sure you want to delete this entry?')) {

	window.location = ('admin.php?section=' + section +'&type=delete&id=' + id);

} else {

	return false;

}
}

This is my delete code:

$sql = "DELETE FROM tbl_mailing_categories WHERE id=$id";

So for example, say I am on section "categories" and the id number of the item I am deleting is "11" - it would put this in the url:

admin.php?section=undefined&type=delete&id=11,categories

Any ideas?

Cheers,
Chris

Weedpacket

You're missing some quotes from your handler. You're not passing two strings 'id','section' - you're passing one string 'id,section'.

You can avoid most if not all of this escaping escaped quotes if instead of using echo you were to use something like

?>
<a href="#" onclick="confirmDelete('<?php echo $row['fld_id']?>','<?php echo $section?>');">Delete</a></p>
<?php

Using a <span> instead of an <a> will also get around the need for an href (although strictly speaking, <a> tags don't need hrefs).

darthmahon

ahh yes, totally forgot to do that 🙂

Thanks a bunch 😃